Eric Dumazet c760089aa9 netfilter: complete validation of user input ...

[ Upstream commit 65acf6e050 ]

In my recent commit, I missed that do_replace() handlers
use copy_from_sockptr() (which I fixed), followed
by unsafe copy_from_sockptr_offset() calls.

In all functions, we can perform the @optlen validation
before even calling xt_alloc_table_info() with the following
check:

if ((u64)optlen < (u64)tmp.size + sizeof(tmp))
        return -EINVAL;

Fixes: 0c83842df4 ("netfilter: validate user input for expected length")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
Link: https://lore.kernel.org/r/20240409120741.3538135-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-04-17 11:18:25 +02:00

..

bpfilter

…

netfilter

netfilter: complete validation of user input

2024-04-17 11:18:25 +02:00

af_inet.c

inet: read sk->sk_family once in inet_recv_error()

2024-02-16 19:06:27 +01:00

ah4.c

…

arp.c

arp: Prevent overflow in arp_req_get().

2024-03-01 13:26:39 +01:00

bpf_tcp_ca.c

…

cipso_ipv4.c

…

datagram.c

ipv4: fix data-races around inet->inet_id

2023-08-30 16:11:02 +02:00

devinet.c

ipv4: properly combine dev_base_seq and ipv4.dev_addr_genid

2024-03-01 13:26:36 +01:00

esp4_offload.c

xfrm: Linearize the skb after offloading if needed.

2023-06-28 11:12:29 +02:00

esp4.c

net: ipv4: fix return value check in esp_remove_trailer

2023-10-25 12:03:06 +02:00

fib_frontend.c

ipv4: Fix incorrect table ID in IOCTL path

2023-03-22 13:33:50 +01:00

fib_lookup.h

…

fib_notifier.c

…

fib_rules.c

…

fib_semantics.c

ipv4/fib: send notify when delete source address routes

2023-10-25 12:03:11 +02:00

fib_trie.c

ipv4/fib: send notify when delete source address routes

2023-10-25 12:03:11 +02:00

fou.c

…

gre_demux.c

…

gre_offload.c

…

icmp.c

icmp: guard against too small mtu

2023-04-13 16:55:21 +02:00

igmp.c

ipv4: igmp: fix refcnt uaf issue when receiving igmp query packet

2023-12-08 08:51:17 +01:00

inet_connection_sock.c

tcp: Fix bind() regression for v6-only wildcard and v4(-mapped-v6) non-wildcard addresses.

2024-04-10 16:28:29 +02:00

inet_diag.c

inet_diag: annotate data-races around inet_diag_table[]

2024-03-26 18:20:31 -04:00

inet_fragment.c

inet: inet_defrag: prevent sk release while still in use

2024-04-10 16:28:23 +02:00

inet_hashtables.c

tcp: Fix refcnt handling in __inet_hash_connect().

2024-03-26 18:20:59 -04:00

inet_timewait_sock.c

tcp: Fix NEW_SYN_RECV handling in inet_twsk_purge()

2024-03-26 18:20:58 -04:00

inetpeer.c

…

ip_forward.c

…

ip_fragment.c

inet: inet_defrag: prevent sk release while still in use

2024-04-10 16:28:23 +02:00

ip_gre.c

erspan: make sure erspan_base_hdr is present in skb->head

2024-04-10 16:28:27 +02:00

ip_input.c

ipv4: ignore dst hint for multipath routes

2023-09-19 12:28:01 +02:00

ip_options.c

…

ip_output.c

net: ipv4: fix a memleak in ip_setup_cork

2024-02-05 20:13:02 +00:00

ip_sockglue.c

ipmr: fix kernel panic when forwarding mcast packets

2024-02-05 20:13:00 +00:00

ip_tunnel_core.c

tunnels: fix out of bounds access when building IPv6 PMTU error

2024-02-16 19:06:26 +01:00

ip_tunnel.c

net: ip_tunnel: make sure to pull inner header in ip_tunnel_rcv()

2024-03-26 18:20:41 -04:00

ip_vti.c

ip_vti: fix potential slab-use-after-free in decode_session6

2023-08-23 17:52:32 +02:00

ipcomp.c

…

ipconfig.c

…

ipip.c

…

ipmr_base.c

…

ipmr.c

ipmr: fix incorrect parameter validation in the ip_mroute_getsockopt() function

2024-03-26 18:20:42 -04:00

Kconfig

tcp: configurable source port perturb table size

2022-11-16 13:02:04 +00:00

Makefile

…

metrics.c

ipv4: prevent potential spectre v1 gadget in ip_metrics_convert()

2023-02-01 08:34:45 +01:00

netfilter.c

…

netlink.c

…

nexthop.c

neighbour: switch to standard rcu, instead of rcu_bh

2023-10-10 22:00:42 +02:00

ping.c

ping: Fix potentail NULL deref for /proc/net/icmp.

2023-04-13 16:55:24 +02:00

proc.c

…

protocol.c

…

raw_diag.c

raw: Fix NULL deref in raw_get_next().

2023-04-13 16:55:23 +02:00

raw.c

ipv4: raw: Fix sending packets from raw sockets via IPsec tunnels

2024-03-26 18:21:00 -04:00

route.c

ipv4/route: avoid unused-but-set-variable warning

2024-04-17 11:18:24 +02:00

syncookies.c

tcp: fix cookie_init_timestamp() overflows

2023-11-20 11:51:54 +01:00

sysctl_net_ipv4.c

tcp: enforce receive buffer memory limits by allowing the tcp window to shrink

2023-10-19 23:08:54 +02:00

tcp_bbr.c

…

tcp_bic.c

…

tcp_bpf.c

tcp_bpf: properly release resources on error paths

2023-10-25 12:03:13 +02:00

tcp_cdg.c

Merge tag 'random-6.1-rc1-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/crng/random

2022-10-16 15:27:07 -07:00

tcp_cong.c

…

tcp_cubic.c

…

tcp_dctcp.c

…

tcp_dctcp.h

…

tcp_diag.c

…

tcp_fastopen.c

tcp: annotate data-races around fastopenq.max_qlen

2023-07-27 08:50:49 +02:00

tcp_highspeed.c

…

tcp_htcp.c

…

tcp_hybla.c

…

tcp_illinois.c

…

tcp_input.c

tcp: do not accept ACK of bytes we never sent

2023-12-13 18:39:11 +01:00

tcp_ipv4.c

ipv4, ipv6: Use splice_eof() to flush

2024-01-10 17:10:27 +01:00

tcp_lp.c

…

tcp_metrics.c

tcp_metrics: do not create an entry from tcp_init_metrics()

2023-11-20 11:51:53 +01:00

tcp_minisocks.c

rds: tcp: Fix use-after-free of net in reqsk_timer_handler().

2024-03-26 18:20:58 -04:00

tcp_nv.c

…

tcp_offload.c

tcp: gso: really support BIG TCP

2023-06-14 11:15:20 +02:00

tcp_output.c

net: Remove acked SYN flag from packet in the transmit queue correctly

2023-12-20 17:00:18 +01:00

tcp_rate.c

…

tcp_recovery.c

tcp: fix excessive TLP and RACK timeouts from HZ rounding

2023-10-25 12:03:06 +02:00

tcp_scalable.c

…

tcp_timer.c

net: tcp: fix unexcepted socket die when snd_wnd is 0

2023-09-13 09:42:32 +02:00

tcp_ulp.c

net/ulp: use consistent error code when blocking ULP

2023-01-24 07:24:43 +01:00

tcp_vegas.c

…

tcp_vegas.h

…

tcp_veno.c

…

tcp_westwood.c

…

tcp_yeah.c

…

tcp.c

tcp: properly terminate timers for kernel sockets

2024-04-10 16:28:21 +02:00

tunnel4.c

…

udp_bpf.c

bpf, sockmap: Fix an infinite loop error when len is 0 in tcp_bpf_recvmsg_parser()

2023-03-17 08:50:24 +01:00

udp_diag.c

…

udp_impl.h

…

udp_offload.c

udp: prevent local UDP tunnel packets from being GROed

2024-04-10 16:28:27 +02:00

udp_tunnel_core.c

udp: lockless UDP_ENCAP_L2TPINUDP / UDP_GRO

2024-01-10 17:10:28 +01:00

udp_tunnel_nic.c

…

udp_tunnel_stub.c

…

udp.c

udp: do not accept non-tunnel GSO skbs landing in a tunnel

2024-04-10 16:28:27 +02:00

udplite.c

udplite: Fix NULL pointer dereference in __sk_mem_raise_allocated().

2023-05-30 14:03:20 +01:00

xfrm4_input.c

udp: annotate data-races around udp->encap_type

2024-01-10 17:10:28 +01:00

xfrm4_output.c

…

xfrm4_policy.c

…

xfrm4_protocol.c

…

xfrm4_state.c

…

xfrm4_tunnel.c

…