Pablo Neira Ayuso f1c3c61701 netfilter: flowtable: incorrect pppoe tuple ...

[ Upstream commit 6db5dc7b35 ]

pppoe traffic reaching ingress path does not match the flowtable entry
because the pppoe header is expected to be at the network header offset.
This bug causes a mismatch in the flow table lookup, so pppoe packets
enter the classical forwarding path.

Fixes: 72efd585f7 ("netfilter: flowtable: add pppoe support")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-04-27 17:07:08 +02:00

..

ipset

netfilter: ipset: Missing gc cancellations fixed

2024-02-23 09:12:50 +01:00

ipvs

ipvs: avoid stat macros calls from preemptible context

2024-01-25 15:27:51 -08:00

core.c

netfilter: let reset rules clean out conntrack entries

2024-03-06 14:45:08 +00:00

Kconfig

netfilter: conntrack: NF_CONNTRACK_PROCFS should no longer default to y

2022-08-17 08:46:30 +02:00

Makefile

net: netfilter: move bpf_ct_set_nat_info kfunc in nf_nat_bpf.c

2022-10-03 09:17:32 -07:00

nf_conncount.c

netfilter: nf_conncount: reduce unnecessary GC

2022-05-16 13:05:40 +02:00

nf_conntrack_acct.c

…

nf_conntrack_amanda.c

…

nf_conntrack_bpf.c

netfilter, bpf: Adjust timeouts of non-confirmed CTs in bpf_ct_insert_entry()

2023-10-06 14:56:38 +02:00

nf_conntrack_broadcast.c

netfilter: nf_conntrack: use rcu accessors where needed

2022-07-11 16:25:15 +02:00

nf_conntrack_core.c

netfilter: bridge: confirm multicast packets before passing them up the stack

2024-03-06 14:45:08 +00:00

nf_conntrack_ecache.c

netfilter: ctnetlink: make event listener tracking global

2023-03-11 13:55:24 +01:00

nf_conntrack_expect.c

…

nf_conntrack_extend.c

netfilter: conntrack: fix extension size table

2023-10-06 14:56:36 +02:00

nf_conntrack_ftp.c

netfilter: nf_ct_ftp: fix deadlock when nat rewrite is needed

2022-09-20 23:50:03 +02:00

nf_conntrack_h323_asn1.c

netfilter: nf_conntrack_h323: Add protection for bmp length out of range

2024-03-15 10:48:16 -04:00

nf_conntrack_h323_main.c

netfilter: nf_ct_h323: cap packet size at 64k

2022-08-11 16:50:49 +02:00

nf_conntrack_h323_types.c

…

nf_conntrack_helper.c

netfilter: conntrack: Avoid nf_ct_helper_hash uses after free

2023-07-19 16:22:16 +02:00

nf_conntrack_irc.c

netfilter: nf_conntrack_irc: Tighten matching on DCC message

2022-09-07 15:55:23 +02:00

nf_conntrack_labels.c

…

nf_conntrack_netbios_ns.c

…

nf_conntrack_netlink.c

netfilter: conntrack: define variables exp_nat_nla_policy and any_addr with CONFIG_NF_NAT

2023-06-09 10:34:15 +02:00

nf_conntrack_pptp.c

netfilter: nf_conntrack: add missing __rcu annotations

2022-07-11 16:25:15 +02:00

nf_conntrack_proto_dccp.c

netfilter: conntrack: dccp: copy entire header to stack buffer, not just basic one

2023-07-19 16:21:13 +02:00

nf_conntrack_proto_generic.c

…

nf_conntrack_proto_gre.c

…

nf_conntrack_proto_icmp.c

…

nf_conntrack_proto_icmpv6.c

netfilter: conntrack: set icmpv6 redirects as RELATED

2022-12-31 13:32:19 +01:00

nf_conntrack_proto_sctp.c

netfilter: conntrack: check SCTP_CID_SHUTDOWN_ACK for vtag setting in sctp_new

2024-03-01 13:26:27 +01:00

nf_conntrack_proto_tcp.c

netfilter: let reset rules clean out conntrack entries

2024-03-06 14:45:08 +00:00

nf_conntrack_proto_udp.c

…

nf_conntrack_proto.c

netfilter: conntrack: add nf_ct_iter_data object for nf_ct_iterate_cleanup*()

2022-05-13 18:56:27 +02:00

nf_conntrack_sane.c

netfilter: nf_ct_sane: remove pseudo skb linearization

2022-08-11 16:50:25 +02:00

nf_conntrack_seqadj.c

…

nf_conntrack_sip.c

netfilter: nf_conntrack_sip: fix the ct_sip_parse_numerical_param() return value.

2023-07-19 16:21:13 +02:00

nf_conntrack_snmp.c

…

nf_conntrack_standalone.c

netfilter: conntrack: fix possible bug_on with enable_hooks=1

2023-05-24 17:32:32 +01:00

nf_conntrack_tftp.c

…

nf_conntrack_timeout.c

netfilter: nf_conntrack: use rcu accessors where needed

2022-07-11 16:25:15 +02:00

nf_conntrack_timestamp.c

…

nf_dup_netdev.c

netfilter: nf_dup_netdev: add and use recursion counter

2022-06-21 10:50:41 +02:00

nf_flow_table_core.c

netfilter: nft_flow_offload: release dst in case direct xmit path is used

2024-03-01 13:26:37 +01:00

nf_flow_table_inet.c

netfilter: flowtable: validate pppoe header

2024-04-27 17:07:07 +02:00

nf_flow_table_ip.c

netfilter: flowtable: incorrect pppoe tuple

2024-04-27 17:07:08 +02:00

nf_flow_table_offload.c

netfilter: flowtable: cache info of last offload

2024-01-10 17:10:34 +01:00

nf_flow_table_procfs.c

netfilter: nf_flow_table: count pending offload workqueue tasks

2022-07-11 16:25:14 +02:00

nf_hooks_lwtunnel.c

…

nf_internals.h

…

nf_log_syslog.c

netfilter: propagate net to nf_bridge_get_physindev

2024-01-25 15:27:51 -08:00

nf_log.c

netfilter: nf_log: replace BUG_ON by WARN_ON_ONCE when putting logger

2024-02-05 20:13:02 +00:00

nf_nat_amanda.c

netfilter: nat: move repetitive nat port reserve loop to a helper

2022-09-07 16:46:04 +02:00

nf_nat_bpf.c

net: netfilter: move bpf_ct_set_nat_info kfunc in nf_nat_bpf.c

2022-10-03 09:17:32 -07:00

nf_nat_core.c

netfilter: nf_nat: Fix possible memory leak in nf_nat_init()

2022-11-02 10:47:22 +01:00

nf_nat_ftp.c

netfilter: nat: move repetitive nat port reserve loop to a helper

2022-09-07 16:46:04 +02:00

nf_nat_helper.c

netfilter: nat: avoid long-running port range loop

2022-09-07 16:46:04 +02:00

nf_nat_irc.c

netfilter: nat: move repetitive nat port reserve loop to a helper

2022-09-07 16:46:04 +02:00

nf_nat_masquerade.c

netfilter: conntrack: add nf_ct_iter_data object for nf_ct_iterate_cleanup*()

2022-05-13 18:56:27 +02:00

nf_nat_proto.c

…

nf_nat_redirect.c

netfilter: nat: fix ipv6 nat redirect with mapped and scoped addresses

2023-11-20 11:52:17 +01:00

nf_nat_sip.c

netfilter: nat: move repetitive nat port reserve loop to a helper

2022-09-07 16:46:04 +02:00

nf_nat_tftp.c

…

nf_queue.c

netfilter: propagate net to nf_bridge_get_physindev

2024-01-25 15:27:51 -08:00

nf_sockopt.c

…

nf_synproxy_core.c

ip: Fix data-races around sysctl_ip_default_ttl.

2022-07-15 11:49:55 +01:00

nf_tables_api.c

netfilter: nf_tables: Fix potential data-race in __nft_obj_type_get()

2024-04-27 17:07:07 +02:00

nf_tables_core.c

netfilter: nf_tables: set transport offset from mac header for netdev/egress

2024-01-10 17:10:21 +01:00

nf_tables_offload.c

netfilter: nf_tables: bail out early if hardware offload is not supported

2022-06-06 19:19:15 +02:00

nf_tables_trace.c

netfilter: nf_tables: avoid skb access on nf_stolen

2022-06-27 19:22:54 +02:00

nfnetlink_acct.c

…

nfnetlink_cthelper.c

netfilter: nf_conntrack: use rcu accessors where needed

2022-07-11 16:25:15 +02:00

nfnetlink_cttimeout.c

netfilter: cttimeout: fix slab-out-of-bounds read typo in cttimeout_net_exit

2022-06-17 23:31:20 +02:00

nfnetlink_hook.c

Remove DECnet support from kernel

2022-08-22 14:26:30 +01:00

nfnetlink_log.c

netfilter: nfnetlink_log: use proper helper for fetching physinif

2024-01-25 15:27:50 -08:00

nfnetlink_osf.c

netfilter: nfnetlink_osf: avoid OOB read

2023-09-19 12:28:03 +02:00

nfnetlink_queue.c

netfilter: nf_queue: do not allow packet truncation below transport header offset

2022-07-26 21:12:42 +02:00

nfnetlink.c

netfilter: nfnetlink: skip error delivery on batch in case of ENOMEM

2023-06-21 16:00:58 +02:00

nft_bitwise.c

netfilter: nft_bitwise: fix register tracking

2023-06-14 11:15:20 +02:00

nft_byteorder.c

netfilter: nf_tables: fix pointer math issue in nft_byteorder_eval()

2023-11-28 17:07:05 +00:00

nft_chain_filter.c

netfilter: nft_chain_filter: handle NETDEV_UNREGISTER for inet/ingress basechain

2024-01-31 16:17:07 -08:00

nft_chain_nat.c

…

nft_chain_route.c

…

nft_cmp.c

netfilter: nf_tables: upfront validation of data via nft_data_init()

2022-08-09 20:13:29 +02:00

nft_compat.c

netfilter: nf_tables: allow NFPROTO_INET in nft_(match/target)_validate()

2024-03-06 14:45:08 +00:00

nft_connlimit.c

…

nft_counter.c

…

nft_ct.c

netfilter: nft_ct: fix l3num expectations with inet pseudo family

2024-03-15 10:48:16 -04:00

nft_dup_netdev.c

…

nft_dynset.c

netfilter: nf_tables: bail out on mismatching dynset and set expressions

2023-12-13 18:39:11 +01:00

nft_exthdr.c

netfilter: nf_tables: fix 'exist' matching on bigendian arches

2023-12-13 18:39:11 +01:00

nft_fib_inet.c

…

nft_fib_netdev.c

…

nft_fib.c

netfilter: nf_tables: fix 'exist' matching on bigendian arches

2023-12-13 18:39:11 +01:00

nft_flow_offload.c

netfilter: flowtable: simplify route logic

2024-03-01 13:26:37 +01:00

nft_fwd_netdev.c

…

nft_hash.c

…

nft_immediate.c

netfilter: nft_immediate: drop chain reference counter on error

2024-01-10 17:10:24 +01:00

nft_last.c

netfilter: nft_last: copy content when cloning expression

2023-03-17 08:50:23 +01:00

nft_limit.c

netfilter: nft_limit: reject configurations that cause integer overflow

2024-01-31 16:17:05 -08:00

nft_log.c

…

nft_lookup.c

netfilter: nf_tables: deactivate anonymous set from preparation phase

2023-05-11 23:03:42 +09:00

nft_masq.c

netfilter: nft_masq: correct length for loading protocol registers

2023-03-22 13:33:42 +01:00

nft_meta.c

netfilter: nf_tables: fix pointer math issue in nft_byteorder_eval()

2023-11-28 17:07:05 +00:00

nft_nat.c

netfilter: nf_tables: validate NFPROTO_* family

2024-01-31 16:17:06 -08:00

nft_numgen.c

netfilter: use get_random_u32 instead of prandom

2022-06-08 12:30:59 +02:00

nft_objref.c

netfilter: nf_tables: report use refcount overflow

2023-08-16 18:27:30 +02:00

nft_osf.c

netfilter: move from strlcpy with unused retval to strscpy

2022-09-07 16:46:03 +02:00

nft_payload.c

netfilter: nft_payload: fix wrong mac header matching

2023-10-25 12:03:05 +02:00

nft_queue.c

netfilter: nft_queue: only allow supported familes and hooks

2022-07-26 21:12:42 +02:00

nft_quota.c

netfilter: nft_quota: copy content when cloning expression

2023-03-17 08:50:23 +01:00

nft_range.c

netfilter: nf_tables: upfront validation of data via nft_data_init()

2022-08-09 20:13:29 +02:00

nft_redir.c

netfilter: nft_redir: use struct nf_nat_range2 throughout and deduplicate eval call-backs

2023-11-20 11:52:17 +01:00

nft_reject_inet.c

…

nft_reject_netdev.c

…

nft_reject.c

…

nft_rt.c

netfilter: nf_tables: validate NFPROTO_* family

2024-01-31 16:17:06 -08:00

nft_set_bitmap.c

netfilter: nf_tables: drop map element references from preparation phase

2023-06-28 11:12:32 +02:00

nft_set_hash.c

netfilter: nft_set_hash: try later when GC hits EAGAIN on iteration

2023-10-06 14:56:35 +02:00

nft_set_pipapo_avx2.c

work around gcc bugs with 'asm goto' with outputs

2024-02-23 09:12:28 +01:00

nft_set_pipapo_avx2.h

…

nft_set_pipapo.c

netfilter: nft_set_pipapo: do not free live element

2024-04-27 17:07:07 +02:00

nft_set_pipapo.h

netfilter: nft_set_pipapo: remove scratch_aligned pointer

2024-02-16 19:06:28 +01:00

nft_set_rbtree.c

netfilter: nft_set_rbtree: skip end interval element from gc

2024-02-16 19:06:32 +01:00

nft_socket.c

netfilter: nf_tables: validate NFPROTO_* family

2024-01-31 16:17:06 -08:00

nft_synproxy.c

netfilter: nf_tables: validate NFPROTO_* family

2024-01-31 16:17:06 -08:00

nft_tproxy.c

netfilter: nf_tables: validate NFPROTO_* family

2024-01-31 16:17:06 -08:00

nft_tunnel.c

netfilter: nf_tables: restrict tunnel object to NFPROTO_NETDEV

2024-02-05 20:13:01 +00:00

nft_xfrm.c

netfilter: nf_tables: validate NFPROTO_* family

2024-01-31 16:17:06 -08:00

utils.c

…

x_tables.c

netfilter: move from strlcpy with unused retval to strscpy

2022-09-07 16:46:03 +02:00

xt_addrtype.c

…

xt_AUDIT.c

…

xt_bpf.c

…

xt_cgroup.c

…

xt_CHECKSUM.c

…

xt_CLASSIFY.c

…

xt_cluster.c

…

xt_comment.c

…

xt_connbytes.c

…

xt_connlabel.c

…

xt_connlimit.c

netfilter: x_tables: use correct integer types

2022-07-11 16:40:45 +02:00

xt_connmark.c

netfilter: conntrack: Fix data-races around ct mark

2022-11-18 15:21:00 +01:00

xt_CONNSECMARK.c

…

xt_conntrack.c

…

xt_cpu.c

…

xt_CT.c

netfilter: nf_conntrack: use rcu accessors where needed

2022-07-11 16:25:15 +02:00

xt_dccp.c

…

xt_devgroup.c

…

xt_dscp.c

…

xt_DSCP.c

netfilter: x_tables: use correct integer types

2022-07-11 16:40:45 +02:00

xt_ecn.c

…

xt_esp.c

…

xt_hashlimit.c

…

xt_helper.c

…

xt_hl.c

…

xt_HL.c

…

xt_HMARK.c

…

xt_IDLETIMER.c

…

xt_ipcomp.c

…

xt_iprange.c

…

xt_ipvs.c

…

xt_l2tp.c

…

xt_LED.c

…

xt_length.c

netfilter: use skb_ip_totlen and iph_totlen

2024-01-10 17:10:21 +01:00

xt_limit.c

…

xt_LOG.c

…

xt_mac.c

…

xt_mark.c

…

xt_MASQUERADE.c

…

xt_multiport.c

…

xt_nat.c

…

xt_NETMAP.c

…

xt_nfacct.c

…

xt_NFLOG.c

…

xt_NFQUEUE.c

…

xt_osf.c

netfilter: nfnetlink_osf: fix module autoload

2023-06-28 11:12:33 +02:00

xt_owner.c

netfilter: xt_owner: Fix for unsafe access of sk->sk_socket

2023-12-13 18:39:11 +01:00

xt_physdev.c

netfilter: propagate net to nf_bridge_get_physindev

2024-01-25 15:27:51 -08:00

xt_pkttype.c

…

xt_policy.c

…

xt_quota.c

…

xt_rateest.c

…

xt_RATEEST.c

netfilter: move from strlcpy with unused retval to strscpy

2022-09-07 16:46:03 +02:00

xt_realm.c

…

xt_recent.c

netfilter: xt_recent: fix (increase) ipv6 literal buffer length

2023-11-20 11:52:17 +01:00

xt_REDIRECT.c

netfilter: nft_redir: use struct nf_nat_range2 throughout and deduplicate eval call-backs

2023-11-20 11:52:17 +01:00

xt_repldata.h

…

xt_sctp.c

netfilter: xt_sctp: validate the flag_info count

2023-09-13 09:42:59 +02:00

xt_SECMARK.c

…

xt_set.c

…

xt_socket.c

net: annotate data-races around sk->sk_mark

2023-08-11 12:08:14 +02:00

xt_state.c

…

xt_statistic.c

treewide: use get_random_u32() when possible

2022-10-11 17:42:58 -06:00

xt_string.c

…

xt_tcpmss.c

…

xt_TCPMSS.c

netfilter: x_tables: use correct integer types

2022-07-11 16:40:45 +02:00

xt_TCPOPTSTRIP.c

…

xt_tcpudp.c

…

xt_TEE.c

…

xt_time.c

…

xt_TPROXY.c

netfilter: xt_TPROXY: remove pr_debug invocations

2022-07-21 00:56:00 +02:00

xt_TRACE.c

…

xt_u32.c

netfilter: xt_u32: validate user space input

2023-09-13 09:42:59 +02:00