Eric Dumazet 4c6c11ea0f
net: refine dev_put()/dev_hold() debugging ...
We are still chasing some syzbot reports where we think a rogue dev_put()
is called with no corresponding prior dev_hold().
Unfortunately it eats a reference on dev->dev_refcnt taken by innocent
dev_hold_track(), meaning that the refcount saturation splat comes
too late to be useful.
Make sure that 'not tracked' dev_put() and dev_hold() better use
CONFIG_NET_DEV_REFCNT_TRACKER=y debug infrastructure:
Prior patch in the series allowed ref_tracker_alloc() and ref_tracker_free()
to be called with a NULL @trackerp parameter, and to use a separate refcount
only to detect too many put() even in the following case:
dev_hold_track(dev, tracker_1, GFP_ATOMIC);
dev_hold(dev);
dev_put(dev);
dev_put(dev); // Should complain loudly here.
dev_put_track(dev, tracker_1); // instead of here
Add clarification about netdev_tracker_alloc() role.
v2: I replaced the dev_put() in linkwatch_do_dev()
with __dev_put() because callers called netdev_tracker_free().
Signed-off-by: Eric Dumazet <edumazet@google.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2022-02-05 15:22:45 +00:00
2022-01-05 12:09:06 +01:00
2022-01-20 13:46:20 +02:00
2022-01-03 17:05:02 +05:30
2022-02-02 14:43:59 +00:00
2022-01-14 16:02:28 +01:00
2022-01-08 14:42:01 -05:00
2022-01-12 17:02:27 -08:00
2022-01-27 12:37:35 -08:00
2021-12-31 13:31:34 +01:00
2022-02-03 13:13:50 -08:00
2022-01-09 23:30:13 +01:00
2022-01-26 11:20:37 +00:00
2022-01-17 08:07:57 +02:00
2022-01-06 08:37:03 -08:00
2022-01-11 12:17:45 -08:00
2022-01-22 08:33:34 +02:00
2022-01-13 09:05:29 -08:00
2021-12-24 14:06:45 +00:00
2022-01-07 17:14:30 +00:00
2022-01-28 14:47:55 +00:00
2022-01-20 08:52:53 +02:00
2022-01-25 18:30:15 +01:00
2022-01-12 15:57:59 -08:00
2022-01-22 08:33:34 +02:00
2021-12-30 17:27:44 -08:00
2021-12-22 13:56:19 +01:00
2022-01-12 12:51:41 -08:00
2022-01-15 08:47:31 -08:00
2022-01-15 08:47:31 -08:00
2022-01-09 10:36:51 -07:00
2021-12-22 23:38:29 -05:00
2022-01-28 12:28:15 -07:00
2022-01-06 12:27:03 +01:00
2021-12-29 17:54:40 -08:00
2022-01-24 15:42:29 -08:00
2021-12-29 20:03:05 -08:00
2022-01-24 15:42:29 -08:00
2022-01-18 14:26:41 -08:00
2022-01-18 14:26:41 -08:00
2022-01-11 09:14:37 -08:00
2021-12-21 15:09:46 -08:00
2022-01-22 08:33:36 +02:00
2021-12-30 17:44:07 +01:00
2022-01-15 08:47:31 -08:00
2021-12-23 22:35:00 +11:00
2022-01-15 16:30:33 +02:00
2022-01-22 08:33:36 +02:00
2022-01-20 08:52:55 +02:00
2022-01-22 08:33:34 +02:00
2021-12-23 16:55:20 +01:00
2022-01-18 08:51:51 +02:00
2022-01-20 08:52:53 +02:00
2022-01-20 08:52:53 +02:00
2022-01-28 14:43:47 +00:00
2022-01-08 14:42:01 -05:00
2022-01-22 08:33:35 +02:00
2021-12-31 08:57:45 -05:00
2022-01-19 12:51:30 -08:00
2022-01-15 08:47:31 -08:00
2022-01-22 08:33:38 +02:00
2022-01-17 09:40:29 +02:00
2022-02-01 11:13:24 -08:00
2022-01-07 13:43:18 +00:00
2022-01-21 21:36:28 +00:00
2022-01-24 14:16:46 +01:00
2022-01-15 16:30:29 +02:00
2022-01-20 08:52:54 +02:00
2022-01-10 09:49:13 +01:00
2022-01-04 13:15:33 -05:00
2022-01-15 16:30:29 +02:00
2022-01-15 16:30:29 +02:00
2021-12-26 15:02:06 -08:00
2022-02-01 20:59:43 -08:00
2021-12-24 10:24:30 -05:00
2022-01-22 08:33:35 +02:00
2021-12-21 15:09:46 -08:00
2022-01-12 15:46:11 -08:00
2022-02-05 15:20:34 +00:00
2022-01-15 20:37:06 +02:00
2022-01-20 10:41:01 +02:00
2022-01-04 14:36:06 +01:00
2022-01-22 08:33:36 +02:00
2022-01-20 10:41:01 +02:00
2022-01-07 10:44:44 -05:00
2022-01-22 09:40:01 +02:00
2022-01-07 10:44:44 -05:00
2022-01-14 15:17:17 +09:00
2022-01-27 13:53:26 +00:00
2022-01-20 08:52:53 +02:00
2022-01-29 08:52:27 +02:00
2022-01-16 23:34:43 +01:00
2022-01-05 11:22:17 +00:00
2022-01-11 12:36:47 +02:00
2022-01-15 20:37:06 +02:00
2022-01-15 16:30:30 +02:00
2022-01-15 20:37:06 +02:00
2022-01-22 08:33:34 +02:00
2022-01-28 14:36:56 +00:00
2022-01-15 16:30:27 +02:00
2022-01-30 09:56:58 +02:00
2022-01-30 09:56:58 +02:00
2022-01-15 16:30:29 +02:00
2022-01-17 07:32:51 +02:00
2022-01-22 08:33:36 +02:00
2022-02-05 15:22:45 +00:00
2022-01-09 23:35:16 +01:00
2022-01-09 23:30:13 +01:00
2022-01-07 09:22:19 +00:00
2022-01-27 13:53:27 +00:00
2022-01-25 20:16:03 +02:00
2022-01-25 20:16:03 +02:00
2022-01-13 09:30:48 -05:00
2022-01-12 10:14:09 -06:00
2022-01-20 12:55:26 -06:00
2022-01-15 16:30:31 +02:00
2022-01-15 16:30:28 +02:00
2022-01-18 06:40:47 +02:00
2022-01-12 12:37:02 -08:00
2022-01-13 16:50:50 -05:00
2022-01-16 08:08:11 +02:00
2022-01-16 08:08:11 +02:00
2022-01-02 18:48:47 +00:00
2022-01-20 08:52:52 +02:00
2022-01-18 12:09:47 +01:00
2022-01-15 16:30:28 +02:00
2022-01-31 11:30:56 +00:00
2022-02-05 15:15:20 +00:00
2022-01-26 18:57:09 -08:00
2022-01-22 08:33:36 +02:00
2022-01-03 21:24:34 -07:00
2022-01-12 19:59:05 +01:00
2022-01-12 19:59:05 +01:00
2021-12-23 22:35:00 +11:00
2022-01-22 08:33:35 +02:00
2022-01-11 11:26:57 -08:00
2022-01-22 08:33:36 +02:00
2022-01-22 08:33:37 +02:00
2022-01-08 12:43:57 -06:00
2022-01-14 16:02:28 +01:00
2022-01-18 12:09:57 +01:00
2022-01-30 09:56:58 +02:00
2022-01-06 12:18:08 +00:00
2022-01-24 14:45:02 +01:00
2022-01-07 00:25:25 +01:00
2022-02-05 15:22:44 +00:00
2022-01-22 08:33:37 +02:00
2022-01-22 08:33:37 +02:00
2022-01-22 08:33:37 +02:00
2022-01-13 12:52:14 -07:00
2021-12-22 09:21:43 +01:00
2022-02-03 11:20:34 -08:00
2022-01-22 08:33:37 +02:00
2021-12-31 13:42:30 +01:00
2021-12-30 13:23:44 +01:00
2022-01-22 08:33:38 +02:00
2022-01-27 12:54:16 -08:00
2022-01-06 12:26:13 +01:00
2022-01-19 11:15:19 +02:00
2022-01-06 12:26:13 +01:00
2022-01-22 08:33:37 +02:00
2022-01-22 08:33:37 +02:00
2022-01-22 08:33:35 +02:00
2022-01-25 18:34:08 +01:00
2022-01-15 16:30:28 +02:00
2022-01-22 08:33:38 +02:00
2022-01-11 15:38:59 -05:00
2022-01-15 16:30:30 +02:00
2022-01-30 09:56:58 +02:00
2022-01-10 08:13:52 -08:00
2022-01-09 00:18:47 +02:00
2022-01-13 16:23:04 -05:00
2022-01-08 12:43:58 -06:00
2022-01-27 13:53:27 +00:00
2022-02-04 10:14:07 +00:00
2021-12-30 12:13:04 +01:00
2022-01-14 18:50:54 -05:00
2022-01-14 18:50:52 -05:00
2022-01-15 16:30:29 +02:00
2022-01-15 16:30:25 +02:00
2022-01-07 09:22:19 +00:00
2021-12-23 11:21:53 +00:00
2022-01-08 00:28:41 -05:00
4c6c11ea0f