Files
linux-stable-mirror/drivers
Jesper Juhl 3f61cd879c bnx2x: Fix mem leak in bnx2x_tpa_stop() if build_skb() fails.
We allocate memory for 'new_data' with kmalloc(). If we get the memory
we then try to build_skb() and if that should fail (which it can) we
do not enter 'if (likely(skb)) {' and actually use 'new_data' but
instead fall through to the 'drop:' label and end up returning from
the function without ever assigning 'new'data' to anything or freeing
it. That leaks the memory allocated to 'new_data'.

This patch fixes the memory leak by doing a kfree(new_data) in the
case where build_skb() fails (or where allocation of 'new_data' itself
fails, but in taht case it's just a harmless kfree(NULL)).

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2012-02-07 13:13:33 -05:00
..
2012-01-26 18:36:48 +00:00
2012-01-14 15:07:24 -08:00
2012-01-22 21:10:40 +00:00
2012-01-23 08:44:53 -08:00
2012-01-24 21:33:26 +00:00
2012-02-01 15:26:00 -05:00
2012-01-26 11:19:46 -08:00
2012-01-13 10:12:23 -08:00
2012-01-11 23:58:47 -05:00