Luis ChamberlainandGreg Kroah-Hartman 9d5c7b0eee block: fix device_add_disk() kobject_create_and_add() error handling ...

[ Upstream commit fe7d064fa3 ]

Commit 83cbce9574 ("block: add error handling for device_add_disk /
add_disk") added error handling to device_add_disk(), however the goto
label for the kobject_create_and_add() failure did not set the return
value correctly, and so we can end up in a situation where
kobject_create_and_add() fails but we report success.

Fixes: 83cbce9574 ("block: add error handling for device_add_disk / add_disk")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20211103164023.1384821-1-mcgrof@kernel.org
[axboe: fold in followup fix from Wu Bo <wubo40@huawei.com>]
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2021-11-18 19:17:08 +01:00

..

partitions

block: fix incorrect references to disk objects

2021-10-18 11:20:38 -06:00

badblocks.c

…

bdev.c

block: genhd: fix double kfree() in __alloc_disk_node()

2021-10-02 07:29:20 -06:00

bfq-cgroup.c

block, bfq: reset last_bfqq_created on group change

2021-10-17 07:03:02 -06:00

bfq-iosched.c

Revert "block, bfq: honor already-setup queue merges"

2021-09-28 06:33:15 -06:00

bfq-iosched.h

block, bfq: cleanup the repeated declaration

2021-08-25 06:45:33 -06:00

bfq-wf2q.c

block: Introduce IOPRIO_NR_LEVELS

2021-08-18 07:21:12 -06:00

bio-integrity.c

block: use bvec_virt in bio_integrity_{process,free}

2021-08-16 10:50:32 -06:00

bio.c

block: don't call rq_qos_ops->done_bio if the bio isn't tracked

2021-09-24 11:04:39 -06:00

blk-cgroup-rwstat.c

blk-cgroup: Fix the recursive blkg rwstat

2021-03-05 11:32:15 -07:00

blk-cgroup-rwstat.h

…

blk-cgroup.c

blk-cgroup: synchronize blkg creation against policy deactivation

2021-11-18 19:16:41 +01:00

blk-core.c

block: drain file system I/O on del_gendisk

2021-10-15 21:02:50 -06:00

blk-crypto-fallback.c

block: rename BIO_MAX_PAGES to BIO_MAX_VECS

2021-03-11 07:47:48 -07:00

blk-crypto-internal.h

…

blk-crypto.c

blk-crypto: fix check for too-large dun_bytes

2021-08-25 06:45:00 -06:00

blk-exec.c

block: return errors from blk_execute_rq()

2021-06-30 15:35:45 -06:00

blk-flush.c

blk-mq: fix is_flush_rq

2021-08-17 20:17:34 -06:00

blk-integrity.c

block: flush the integrity workqueue in blk_integrity_unregister

2021-09-14 20:03:30 -06:00

blk-ioc.c

…

blk-iocost.c

Merge tag 'for-5.15/block-2021-08-30' of git://git.kernel.dk/linux-block

2021-08-30 18:52:11 -07:00

blk-iolatency.c

Merge tag 'for-5.15/block-2021-08-30' of git://git.kernel.dk/linux-block

2021-08-30 18:52:11 -07:00

blk-ioprio.c

block: Introduce the ioprio rq-qos policy

2021-06-21 15:03:40 -06:00

blk-ioprio.h

block: Introduce the ioprio rq-qos policy

2021-06-21 15:03:40 -06:00

blk-lib.c

block: export blk_next_bio()

2021-06-17 15:51:20 +02:00

blk-map.c

Merge branch 'akpm' (patches from Andrew)

2021-09-03 10:08:28 -07:00

blk-merge.c

Merge tag 'io_uring-bio-cache.5-2021-08-30' of git://git.kernel.dk/linux-block

2021-08-30 19:30:30 -07:00

blk-mq-cpumap.c

…

blk-mq-debugfs-zoned.c

…

blk-mq-debugfs.c

block: decode QUEUE_FLAG_HCTX_ACTIVE in debugfs output

2021-10-04 06:58:39 -06:00

blk-mq-debugfs.h

…

blk-mq-pci.c

…

blk-mq-rdma.c

…

blk-mq-sched.c

blk-mq-sched: Fix blk_mq_sched_alloc_tags() error handling

2021-07-27 16:44:38 -06:00

blk-mq-sched.h

blk: Fix lock inversion between ioc lock and bfqd lock

2021-06-24 18:43:55 -06:00

blk-mq-sysfs.c

block: remove blk-mq-sysfs dead code

2021-08-02 13:37:29 -06:00

blk-mq-tag.c

blk-mq: avoid to iterate over stale request

2021-09-12 19:32:43 -06:00

blk-mq-tag.h

blk-mq: Some tag allocation code refactoring

2021-05-24 06:47:22 -06:00

blk-mq-virtio.c

…

blk-mq.c

block: remove inaccurate requeue check

2021-11-18 19:16:17 +01:00

blk-mq.h

blk: Fix lock inversion between ioc lock and bfqd lock

2021-06-24 18:43:55 -06:00

blk-pm.c

scsi: block: Fix a race in the runtime power management code

2020-12-09 11:41:41 -05:00

blk-pm.h

block: Remove unused blk_pm_*() function definitions

2021-02-22 06:33:48 -07:00

blk-rq-qos.c

rq-qos: fix missed wake-ups in rq_qos_throttle try two

2021-06-08 15:12:57 -06:00

blk-rq-qos.h

block: Introduce the ioprio rq-qos policy

2021-06-21 15:03:40 -06:00

blk-settings.c

block: Fix partition check for host-aware zoned block devices

2021-10-27 06:58:01 -06:00

blk-stat.c

…

blk-stat.h

…

blk-sysfs.c

block: call blk_register_queue earlier in device_add_disk

2021-08-23 12:55:45 -06:00

blk-throttle.c

blk-throttle: fix UAF by deleteing timer in blk_throtl_exit()

2021-09-07 08:36:56 -06:00

blk-timeout.c

…

blk-wbt.c

blk-wbt: prevent NULL pointer dereference in wb_timer_fn

2021-11-18 19:16:34 +01:00

blk-wbt.h

blk-wbt: introduce a new disable state to prevent false positive by rwb_enabled()

2021-06-21 15:03:41 -06:00

blk-zoned.c

blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN

2021-08-24 10:12:36 -06:00

blk.h

block: bump max plugged deferred size from 16 to 32

2021-11-18 19:16:16 +01:00

bounce.c

block: use memcpy_from_bvec in __blk_queue_bounce

2021-08-02 13:37:28 -06:00

bsg-lib.c

scsi: bsg-lib: Fix commands without data transfer in bsg_transport_sg_io_fn()

2021-08-01 13:21:40 -04:00

bsg.c

scsi: bsg: Fix device unregistration

2021-09-14 00:22:15 -04:00

disk-events.c

block: return errors from disk_alloc_events

2021-08-23 12:55:45 -06:00

elevator.c

block: return ELEVATOR_DISCARD_MERGE if possible

2021-08-09 14:37:47 -06:00

fops.c

block: hold ->invalidate_lock in blkdev_fallocate

2021-09-24 11:06:58 -06:00

genhd.c

block: fix device_add_disk() kobject_create_and_add() error handling

2021-11-18 19:17:08 +01:00

holder.c

block: add back the bd_holder_dir reference in bd_link_disk_holder

2021-08-20 21:14:26 -06:00

ioctl.c

block: pass a gendisk to bdev_resize_partition

2021-08-12 10:31:36 -06:00

ioprio.c

block: fix default IO priority handling

2021-08-18 07:23:15 -06:00

Kconfig

Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi

2021-09-02 15:09:46 -07:00

Kconfig.iosched

Revert "block/mq-deadline: Add cgroup support"

2021-08-11 13:47:26 -06:00

keyslot-manager.c

Merge tag 'for-5.12/dm-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2021-02-22 10:22:54 -08:00

kyber-iosched.c

kyber: avoid q->disk dereferences in trace points

2021-10-15 21:02:57 -06:00

Makefile

Merge tag 'block-5.15-2021-09-11' of git://git.kernel.dk/linux-block

2021-09-11 10:19:51 -07:00

mq-deadline.c

block/mq-deadline: Move dd_queued() to fix defined but not used warning

2021-09-02 06:34:45 -06:00

opal_proto.h

…

sed-opal.c

…

t10-pi.c

block: use bvec_kmap_local in t10_pi_type1_{prepare,complete}

2021-08-02 13:37:28 -06:00