Geert Uytterhoeven 5b984e538b ALSA: firewire-tascam: Fix integer overflow in midi_port_work() ...

commit 9f65df9c58 upstream.

As snd_fw_async_midi_port.consume_bytes is unsigned int, and
NSEC_PER_SEC is 1000000000L, the second multiplication in

    port->consume_bytes * 8 * NSEC_PER_SEC / 31250

always overflows on 32-bit platforms, truncating the result.  Fix this
by precalculating "NSEC_PER_SEC / 31250", which is an integer constant.

Note that this assumes port->consume_bytes <= 16777.

Fixes: 531f471834 ("ALSA: firewire-lib/firewire-tascam: localize async midi port")
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20210111130251.361335-3-geert+renesas@glider.be
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2021-01-19 18:27:33 +01:00

..

amdtp-tascam.c

…

Makefile

…

tascam-hwdep.c

…

tascam-midi.c

…

tascam-pcm.c

…

tascam-proc.c

…

tascam-stream.c

…

tascam-transaction.c

ALSA: firewire-tascam: Fix integer overflow in midi_port_work()

2021-01-19 18:27:33 +01:00

tascam.c

ALSA; firewire-tascam: exclude Tascam FE-8 from detection

2020-08-23 10:00:34 +02:00

tascam.h

…