
Eric DumazetandGreg Kroah-Hartman
572777a258
ptr_ring: do not block hard interrupts in ptr_ring_resize_multiple()
[ Upstream commit a126061c80 ]
Jakub added a lockdep_assert_no_hardirq() check in __page_pool_put_page()
to increase test coverage.
syzbot found a splat caused by hard irq blocking in
ptr_ring_resize_multiple() [1]
As current users of ptr_ring_resize_multiple() do not require
hard irqs being masked, replace it to only block BH.
Rename helpers to better reflect they are safe against BH only.
- ptr_ring_resize_multiple() to ptr_ring_resize_multiple_bh()
- skb_array_resize_multiple() to skb_array_resize_multiple_bh()
[1]
WARNING: CPU: 1 PID: 9150 at net/core/page_pool.c:709 __page_pool_put_page net/core/page_pool.c:709 [inline]
WARNING: CPU: 1 PID: 9150 at net/core/page_pool.c:709 page_pool_put_unrefed_netmem+0x157/0xa40 net/core/page_pool.c:780
Modules linked in:
CPU: 1 UID: 0 PID: 9150 Comm: syz.1.1052 Not tainted 6.11.0-rc3-syzkaller-00202-gf8669d7b5f5d #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
RIP: 0010:__page_pool_put_page net/core/page_pool.c:709 [inline]
RIP: 0010:page_pool_put_unrefed_netmem+0x157/0xa40 net/core/page_pool.c:780
Code: 74 0e e8 7c aa fb f7 eb 43 e8 75 aa fb f7 eb 3c 65 8b 1d 38 a8 6a 76 31 ff 89 de e8 a3 ae fb f7 85 db 74 0b e8 5a aa fb f7 90 <0f> 0b 90 eb 1d 65 8b 1d 15 a8 6a 76 31 ff 89 de e8 84 ae fb f7 85
RSP: 0018:ffffc9000bda6b58 EFLAGS: 00010083
RAX: ffffffff8997e523 RBX: 0000000000000000 RCX: 0000000000040000
RDX: ffffc9000fbd0000 RSI: 0000000000001842 RDI: 0000000000001843
RBP: 0000000000000000 R08: ffffffff8997df2c R09: 1ffffd40003a000d
R10: dffffc0000000000 R11: fffff940003a000e R12: ffffea0001d00040
R13: ffff88802e8a4000 R14: dffffc0000000000 R15: 00000000ffffffff
FS: 00007fb7aaf716c0(0000) GS:ffff8880b9300000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fa15a0d4b72 CR3: 00000000561b0000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
tun_ptr_free drivers/net/tun.c:617 [inline]
__ptr_ring_swap_queue include/linux/ptr_ring.h:571 [inline]
ptr_ring_resize_multiple_noprof include/linux/ptr_ring.h:643 [inline]
tun_queue_resize drivers/net/tun.c:3694 [inline]
tun_device_event+0xaaf/0x1080 drivers/net/tun.c:3714
notifier_call_chain+0x19f/0x3e0 kernel/notifier.c:93
call_netdevice_notifiers_extack net/core/dev.c:2032 [inline]
call_netdevice_notifiers net/core/dev.c:2046 [inline]
dev_change_tx_queue_len+0x158/0x2a0 net/core/dev.c:9024
do_setlink+0xff6/0x41f0 net/core/rtnetlink.c:2923
rtnl_setlink+0x40d/0x5a0 net/core/rtnetlink.c:3201
rtnetlink_rcv_msg+0x73f/0xcf0 net/core/rtnetlink.c:6647
netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2550
Fixes: ff4e538c8c ("page_pool: add a lockdep check for recycling in hardirq")
Reported-by: syzbot+f56a5c5eac2b28439810@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/671e10df.050a0220.2b8c0f.01cf.GAE@google.com/T/
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Link: https://patch.msgid.link/20241217135121.326370-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[ 2c321f3f70 ("mm: change inlined allocation helpers to account at the call site")
is not ported to Linux-6.6.y. So remove the suffix "_noprof". ]
Signed-off-by: Alva Lan <alvalan9@foxmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-02-06 16:48:29 +01:00
..
2024-12-09 10:32:02 +01:00
2025-01-02 10:31:59 +01:00
2024-12-19 18:11:29 +01:00
2024-10-22 15:46:19 +02:00
2025-11-02 22:14:42 +09:00
2024-12-14 19:59:46 +01:00
2026-01-30 10:27:41 +01:00
2024-10-22 15:46:35 +02:00
2025-02-08 09:51:57 +01:00
2025-06-04 14:42:09 +02:00
2025-09-25 11:00:06 +02:00
2025-06-27 11:08:51 +01:00
2025-05-09 09:43:58 +02:00
2026-01-11 15:21:30 +01:00
2024-09-12 11:11:32 +02:00
2026-01-11 15:22:30 +01:00
2024-09-08 07:54:43 +02:00
2025-12-07 06:18:50 +09:00
2025-03-07 16:45:36 +01:00
2026-01-30 10:27:27 +01:00
2025-06-27 11:08:52 +01:00
2024-09-12 11:11:40 +02:00
2025-08-28 16:28:42 +02:00
2025-06-19 15:28:08 +02:00
2024-11-14 13:19:38 +01:00
2025-12-01 11:41:47 +01:00
2025-12-01 11:41:40 +01:00
2025-09-04 15:30:21 +02:00
2025-11-02 22:14:40 +09:00
2025-04-25 10:45:45 +02:00
2026-01-11 15:22:28 +01:00
2025-02-17 09:40:03 +01:00
2025-06-19 15:28:44 +02:00
2024-10-04 16:29:59 +02:00
2025-11-02 22:14:42 +09:00
2025-11-02 22:14:42 +09:00
2026-01-11 15:21:38 +01:00
2025-02-21 13:57:09 +01:00
2024-12-09 10:32:56 +01:00
2025-05-09 09:43:54 +02:00
2025-09-09 18:56:18 +02:00
2025-10-15 11:57:54 +02:00
2025-02-08 09:52:26 +01:00
2025-06-19 15:28:44 +02:00
2025-02-21 13:57:17 +01:00
2025-11-24 10:29:21 +01:00
2025-01-09 13:31:53 +01:00
2025-03-13 12:58:27 +01:00
2024-12-09 10:32:46 +01:00
2026-01-11 15:22:17 +01:00
2025-09-19 16:32:03 +02:00
2024-11-08 16:28:20 +01:00
2025-10-02 13:42:55 +02:00
2025-07-06 11:00:10 +02:00
2025-04-10 14:37:36 +02:00
2025-06-04 14:42:24 +02:00
2025-04-10 14:37:32 +02:00
2026-01-11 15:21:40 +01:00
2025-09-11 17:20:27 +02:00
2025-10-23 16:16:26 +02:00
2024-11-22 15:38:35 +01:00
2025-10-12 12:56:22 +02:00
2024-09-04 13:28:24 +02:00
2025-06-04 14:41:53 +02:00
2024-12-14 20:00:16 +01:00
2025-02-21 13:57:17 +01:00
2025-08-28 16:28:42 +02:00
2024-12-14 19:59:58 +01:00
2024-08-29 17:33:31 +02:00
2025-07-10 16:03:18 +02:00
2024-10-04 16:29:37 +02:00
2024-12-14 20:00:05 +01:00
2025-11-24 10:29:11 +01:00
2024-10-10 11:58:00 +02:00
2026-01-11 15:21:25 +01:00
2025-08-15 12:08:39 +02:00
2025-08-28 16:28:39 +02:00
2024-09-08 07:54:44 +02:00
2025-04-10 14:37:29 +02:00
2026-01-11 15:22:07 +01:00
2025-06-19 15:28:44 +02:00
2025-06-04 14:42:21 +02:00
2024-12-09 10:31:48 +01:00
2025-06-04 14:42:22 +02:00
2024-11-08 16:28:27 +01:00
2025-06-27 11:09:00 +01:00
2024-09-08 07:54:43 +02:00
2025-07-06 11:00:09 +02:00
2025-08-28 16:28:11 +02:00
2024-10-10 11:58:01 +02:00
2025-03-22 12:50:37 -07:00
2026-01-11 15:21:30 +01:00
2026-01-11 15:22:25 +01:00
2025-08-28 16:28:23 +02:00
2024-12-09 10:32:59 +01:00
2024-10-17 15:24:26 +02:00
2025-04-10 14:37:26 +02:00
2025-06-19 15:28:44 +02:00
2024-12-27 13:58:55 +01:00
2024-11-08 16:28:19 +01:00
2025-08-28 16:28:47 +02:00
2025-07-06 11:00:16 +02:00
2025-08-01 09:47:29 +01:00
2026-01-11 15:21:56 +01:00
2024-12-09 10:31:50 +01:00
2025-02-08 09:52:27 +01:00
2026-01-11 15:22:17 +01:00
2025-12-01 11:41:47 +01:00
2026-01-30 10:27:25 +01:00
2025-10-19 16:30:58 +02:00
2025-02-17 09:40:16 +01:00
2024-12-14 20:00:12 +01:00
2025-07-10 16:03:15 +02:00
2024-12-09 10:32:45 +01:00
2025-06-04 14:42:01 +02:00
2025-11-24 10:30:07 +01:00
2025-07-17 18:35:22 +02:00
2025-06-19 15:28:19 +02:00
2025-01-09 13:31:40 +01:00
2025-11-24 10:30:13 +01:00
2025-08-28 16:28:39 +02:00
2025-11-24 10:30:14 +01:00
2024-10-17 15:24:10 +02:00
2025-10-02 13:42:56 +02:00
2025-01-17 13:36:26 +01:00
2026-01-11 15:22:24 +01:00
2024-11-22 15:38:37 +01:00
2024-12-09 10:32:59 +01:00
2025-05-18 08:24:11 +02:00
2025-08-15 12:08:57 +02:00
2025-02-08 09:52:02 +01:00
2025-06-04 14:42:06 +02:00
2025-01-09 13:31:41 +01:00
2026-01-17 16:29:58 +01:00
2024-10-17 15:24:29 +02:00
2025-11-24 10:30:10 +01:00
2026-01-17 16:30:00 +01:00
2026-01-11 15:21:37 +01:00
2025-09-04 15:30:20 +02:00
2026-01-11 15:21:37 +01:00
2025-04-25 10:45:46 +02:00
2025-11-24 10:30:04 +01:00
2025-01-17 13:36:09 +01:00
2025-03-22 12:50:43 -07:00
2026-01-30 10:27:42 +01:00
2024-09-18 19:24:04 +02:00
2025-02-27 04:10:47 -08:00
2024-12-09 10:31:56 +01:00
2025-02-08 09:51:51 +01:00
2024-12-09 10:32:59 +01:00
2025-10-15 11:57:54 +02:00
2025-06-04 14:42:21 +02:00
2025-09-25 11:00:10 +02:00
2024-10-17 15:24:22 +02:00
2025-11-24 10:29:27 +01:00
2025-06-04 14:42:13 +02:00
2025-09-19 16:32:01 +02:00
2025-09-19 16:32:01 +02:00
2025-06-19 15:28:19 +02:00
2025-10-23 16:16:39 +02:00
2025-01-23 17:21:14 +01:00
2026-01-30 10:27:30 +01:00
2025-08-15 12:08:42 +02:00
2025-08-15 12:08:54 +02:00
2024-09-18 19:24:03 +02:00
2025-01-23 17:21:12 +01:00
2025-08-15 12:08:46 +02:00
2026-02-06 16:48:29 +01:00
2025-10-23 16:16:41 +02:00
2026-01-11 15:21:14 +01:00
2025-06-04 14:42:13 +02:00
2025-03-07 16:45:47 +01:00
2025-06-04 14:42:13 +02:00
2026-01-11 15:21:52 +01:00
2025-04-25 10:45:06 +02:00
2025-01-09 13:31:41 +01:00
2024-10-04 16:29:38 +02:00
2024-12-14 19:59:50 +01:00
2026-02-06 16:48:28 +01:00
2025-02-01 18:37:51 +01:00
2025-01-09 13:32:05 +01:00
2024-12-09 10:31:51 +01:00
2025-02-27 04:10:45 -08:00
2025-11-24 10:29:32 +01:00
2026-02-06 16:48:29 +01:00
2025-08-28 16:28:23 +02:00
2025-02-27 04:10:50 -08:00
2024-08-29 17:33:23 +02:00
2024-12-09 10:32:10 +01:00
2024-11-22 15:38:32 +01:00
2025-01-09 13:31:41 +01:00
2025-08-01 09:47:30 +01:00
2024-12-19 18:11:37 +01:00
2024-10-10 11:58:08 +02:00
2025-12-01 11:41:47 +01:00
2025-11-24 10:30:14 +01:00
2024-11-01 01:58:20 +01:00
2024-10-17 15:24:23 +02:00
2026-01-30 10:27:25 +01:00
2024-11-08 16:28:16 +01:00
2024-11-14 13:19:37 +01:00
2026-01-11 15:22:20 +01:00
2025-04-10 14:37:41 +02:00
2025-06-04 14:41:54 +02:00
2025-06-04 14:41:54 +02:00
2026-01-11 15:22:33 +01:00
2025-05-18 08:24:09 +02:00
2024-11-08 16:28:26 +01:00
2024-10-10 11:57:36 +02:00
2024-11-14 13:19:39 +01:00
2024-12-09 10:33:06 +01:00
2026-01-11 15:21:32 +01:00
2024-10-10 11:57:17 +02:00
2025-08-28 16:28:25 +02:00
2025-11-24 10:30:12 +01:00
2025-09-09 18:56:26 +02:00
2025-01-02 10:32:00 +01:00
2025-08-15 12:09:01 +02:00
2024-12-27 13:58:57 +01:00
2024-10-04 16:30:02 +02:00