Eduard Zingerman and Greg Kroah-Hartman
7197fc4acd
bpf: check changes_pkt_data property for extension programs
...
commit 81f6d0530b upstream.
When processing calls to global sub-programs, verifier decides whether
to invalidate all packet pointers in current state depending on the
changes_pkt_data property of the global sub-program.
Because of this, an extension program replacing a global sub-program
must be compatible with changes_pkt_data property of the sub-program
being replaced.
This commit:
- adds changes_pkt_data flag to struct bpf_prog_aux:
- this flag is set in check_cfg() for main sub-program;
- in jit_subprogs() for other sub-programs;
- modifies bpf_check_attach_btf_id() to check changes_pkt_data flag;
- moves call to check_attach_btf_id() after the call to check_cfg(),
because it needs changes_pkt_data flag to be set:
bpf_check:
... ...
- check_attach_btf_id resolve_pseudo_ldimm64
resolve_pseudo_ldimm64 --> bpf_prog_is_offloaded
bpf_prog_is_offloaded check_cfg
check_cfg + check_attach_btf_id
... ...
The following fields are set by check_attach_btf_id():
- env->ops
- prog->aux->attach_btf_trace
- prog->aux->attach_func_name
- prog->aux->attach_func_proto
- prog->aux->dst_trampoline
- prog->aux->mod
- prog->aux->saved_dst_attach_type
- prog->aux->saved_dst_prog_type
- prog->expected_attach_type
Neither of these fields are used by resolve_pseudo_ldimm64() or
bpf_prog_offload_verifier_prep() (for netronome and netdevsim
drivers), so the reordering is safe.
Suggested-by: Alexei Starovoitov <alexei.starovoitov@gmail.com >
Signed-off-by: Eduard Zingerman <eddyz87@gmail.com >
Link: https://lore.kernel.org/r/20241210041100.1898468-6-eddyz87@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org >
[ shung-hsi.yu: adapt to missing fields in "struct bpf_prog_aux". Context
difference in jit_subprogs() because BPF Exception is not supported. Context
difference in bpf_check() because commit 5b5f51bff1 "bpf:
no_caller_saved_registers attribute for helper calls" is not present. ]
Signed-off-by: Shung-Hsi Yu <shung-hsi.yu@suse.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2025-05-09 09:43:54 +02:00
..
2024-06-27 13:49:11 +02:00
2024-12-09 10:32:02 +01:00
2025-01-02 10:31:59 +01:00
2024-12-19 18:11:29 +01:00
2024-06-12 11:12:23 +02:00
2024-10-22 15:46:19 +02:00
2024-04-27 17:11:33 +02:00
2024-12-14 19:59:46 +01:00
2024-06-12 11:12:21 +02:00
2024-10-22 15:46:35 +02:00
2025-02-08 09:51:57 +01:00
2025-02-17 09:40:08 +01:00
2024-12-14 20:00:00 +01:00
2024-04-03 15:28:58 +02:00
2024-02-23 09:25:18 +01:00
2024-04-03 15:28:28 +02:00
2025-02-08 09:51:54 +01:00
2024-06-21 14:38:34 +02:00
2024-09-12 11:11:32 +02:00
2025-04-10 14:37:36 +02:00
2024-09-08 07:54:43 +02:00
2024-07-25 09:50:47 +02:00
2025-03-07 16:45:36 +01:00
2025-02-08 09:52:37 +01:00
2024-06-12 11:11:37 +02:00
2024-09-12 11:11:40 +02:00
2024-11-14 13:19:38 +01:00
2024-02-23 09:25:16 +01:00
2025-04-25 10:45:45 +02:00
2025-02-17 09:40:03 +01:00
2024-10-04 16:29:59 +02:00
2024-06-12 11:11:38 +02:00
2024-08-14 13:59:02 +02:00
2025-02-21 13:57:09 +01:00
2024-12-09 10:32:56 +01:00
2024-04-27 17:11:43 +02:00
2024-05-25 16:22:53 +02:00
2025-05-09 09:43:54 +02:00
2024-09-12 11:11:34 +02:00
2025-05-09 09:43:54 +02:00
2025-02-08 09:52:26 +01:00
2024-03-06 14:48:44 +00:00
2024-07-25 09:50:40 +02:00
2025-02-21 13:57:17 +01:00
2025-01-09 13:31:53 +01:00
2024-08-14 13:58:56 +02:00
2025-03-13 12:58:27 +01:00
2024-07-05 09:34:04 +02:00
2024-12-09 10:32:46 +01:00
2024-12-09 10:32:46 +01:00
2024-11-08 16:28:20 +01:00
2024-12-19 18:11:36 +01:00
2025-04-10 14:37:36 +02:00
2025-04-10 14:37:32 +02:00
2024-06-12 11:12:14 +02:00
2024-06-12 11:11:24 +02:00
2025-05-09 09:43:53 +02:00
2024-08-29 17:33:14 +02:00
2024-11-22 15:38:35 +01:00
2024-06-12 11:11:57 +02:00
2024-11-08 16:28:24 +01:00
2024-03-26 18:20:13 -04:00
2024-05-17 12:02:27 +02:00
2024-09-04 13:28:24 +02:00
2024-02-16 19:10:42 +01:00
2024-12-14 20:00:16 +01:00
2025-02-21 13:57:17 +01:00
2025-05-02 07:50:41 +02:00
2024-05-02 16:32:46 +02:00
2024-12-14 19:59:58 +01:00
2024-08-29 17:33:31 +02:00
2024-10-04 16:29:37 +02:00
2024-12-14 20:00:05 +01:00
2024-06-12 11:11:56 +02:00
2024-10-10 11:58:00 +02:00
2025-05-09 09:43:54 +02:00
2024-06-12 11:12:51 +02:00
2025-03-22 12:50:44 -07:00
2024-07-25 09:50:57 +02:00
2024-09-08 07:54:44 +02:00
2024-07-11 12:49:16 +02:00
2025-04-10 14:37:29 +02:00
2024-05-17 12:02:15 +02:00
2024-04-03 15:28:44 +02:00
2025-04-25 10:45:12 +02:00
2024-12-09 10:31:48 +01:00
2025-01-23 17:21:17 +01:00
2024-11-08 16:28:27 +01:00
2025-03-13 12:58:38 +01:00
2024-09-08 07:54:43 +02:00
2024-12-27 13:58:54 +01:00
2024-10-10 11:58:01 +02:00
2025-03-22 12:50:37 -07:00
2025-02-08 09:51:58 +01:00
2025-01-09 13:32:02 +01:00
2024-12-09 10:32:59 +01:00
2024-04-03 15:28:19 +02:00
2024-04-03 15:28:18 +02:00
2024-10-17 15:24:26 +02:00
2025-04-10 14:37:26 +02:00
2025-03-22 12:50:45 -07:00
2024-12-27 13:58:55 +01:00
2024-11-08 16:28:19 +01:00
2024-06-21 14:38:30 +02:00
2024-02-05 20:14:17 +00:00
2024-04-17 11:19:36 +02:00
2024-10-17 15:24:13 +02:00
2024-12-09 10:31:50 +01:00
2025-02-08 09:52:27 +01:00
2024-06-27 13:49:13 +02:00
2024-04-13 13:07:38 +02:00
2024-06-27 13:49:03 +02:00
2024-06-16 13:47:41 +02:00
2024-06-12 11:12:52 +02:00
2025-02-17 09:40:16 +01:00
2024-12-14 20:00:12 +01:00
2024-07-05 09:33:57 +02:00
2024-12-09 10:32:45 +01:00
2024-07-11 12:49:18 +02:00
2025-01-09 13:31:40 +01:00
2024-11-01 01:58:25 +01:00
2024-10-17 15:24:10 +02:00
2024-02-05 20:14:21 +00:00
2025-01-17 13:36:26 +01:00
2025-01-17 13:36:26 +01:00
2024-11-22 15:38:37 +01:00
2024-12-09 10:32:59 +01:00
2024-07-18 13:21:10 +02:00
2024-06-27 13:49:14 +02:00
2024-03-26 18:19:55 -04:00
2025-02-08 09:52:02 +01:00
2025-01-09 13:31:41 +01:00
2025-02-27 04:10:49 -08:00
2024-03-06 14:48:36 +00:00
2024-10-17 15:24:29 +02:00
2024-12-09 10:32:12 +01:00
2024-10-17 15:24:23 +02:00
2024-04-03 15:28:29 +02:00
2025-04-25 10:45:46 +02:00
2025-01-17 13:36:09 +01:00
2025-03-22 12:50:43 -07:00
2024-07-05 09:33:53 +02:00
2024-09-18 19:24:04 +02:00
2025-02-27 04:10:47 -08:00
2024-08-03 08:53:38 +02:00
2024-12-09 10:31:56 +01:00
2025-02-08 09:51:51 +01:00
2024-12-09 10:32:59 +01:00
2024-12-09 10:32:59 +01:00
2024-04-13 13:07:32 +02:00
2024-07-25 09:50:56 +02:00
2024-05-02 16:32:47 +02:00
2024-07-18 13:21:20 +02:00
2024-10-17 15:24:22 +02:00
2024-12-14 20:00:14 +01:00
2025-02-08 09:51:44 +01:00
2025-04-25 10:45:31 +02:00
2024-07-11 12:49:11 +02:00
2025-04-10 14:37:26 +02:00
2025-01-23 17:21:14 +01:00
2025-02-08 09:52:38 +01:00
2024-06-12 11:11:56 +02:00
2025-03-28 21:59:55 +01:00
2024-08-14 13:58:47 +02:00
2024-09-18 19:24:03 +02:00
2025-01-23 17:21:12 +01:00
2024-02-23 09:24:53 +01:00
2024-06-12 11:12:24 +02:00
2024-04-13 13:07:40 +02:00
2025-04-10 14:37:36 +02:00
2025-03-07 16:45:47 +01:00
2024-05-17 12:01:59 +02:00
2024-04-03 15:28:32 +02:00
2025-04-25 10:45:06 +02:00
2025-01-09 13:31:41 +01:00
2024-10-04 16:29:38 +02:00
2024-12-14 19:59:50 +01:00
2025-03-13 12:58:27 +01:00
2024-08-11 12:47:16 +02:00
2025-02-01 18:37:51 +01:00
2024-04-10 16:36:04 +02:00
2024-07-11 12:49:18 +02:00
2025-01-09 13:32:05 +01:00
2024-12-09 10:31:51 +01:00
2024-07-05 09:34:00 +02:00
2025-02-27 04:10:45 -08:00
2024-04-27 17:11:42 +02:00
2024-05-17 12:02:20 +02:00
2025-02-27 04:10:50 -08:00
2024-08-29 17:33:23 +02:00
2024-06-16 13:47:49 +02:00
2024-12-09 10:32:10 +01:00
2024-11-22 15:38:32 +01:00
2025-01-09 13:31:41 +01:00
2024-12-19 18:11:37 +01:00
2024-10-10 11:58:08 +02:00
2024-03-01 13:35:00 +01:00
2024-04-27 17:11:42 +02:00
2024-07-05 09:34:04 +02:00
2024-08-11 12:47:13 +02:00
2024-11-01 01:58:20 +01:00
2024-10-17 15:24:23 +02:00
2024-11-08 16:28:16 +01:00
2024-11-14 13:19:37 +01:00
2025-04-25 10:45:20 +02:00
2025-04-10 14:37:41 +02:00
2025-01-09 13:31:55 +01:00
2025-04-10 14:37:41 +02:00
2024-06-12 11:12:35 +02:00
2024-06-27 13:49:05 +02:00
2024-04-17 11:19:28 +02:00
2024-11-08 16:28:26 +01:00
2024-04-27 17:11:32 +02:00
2024-10-10 11:57:36 +02:00
2024-11-14 13:19:39 +01:00
2024-12-09 10:33:06 +01:00
2024-04-03 15:28:49 +02:00
2024-10-10 11:57:17 +02:00
2025-01-02 10:32:00 +01:00
2024-12-27 13:58:57 +01:00
2024-07-05 09:33:45 +02:00
2024-10-04 16:30:02 +02:00