Javier Carrasco 387f5b8ad3 cpuidle: riscv-sbi: fix device node release in early exit of for_each_possible_cpu ...

[ Upstream commit 7e25044b80 ]

The 'np' device_node is initialized via of_cpu_device_node_get(), which
requires explicit calls to of_node_put() when it is no longer required
to avoid leaking the resource.

Instead of adding the missing calls to of_node_put() in all execution
paths, use the cleanup attribute for 'np' by means of the __free()
macro, which automatically calls of_node_put() when the variable goes
out of scope. Given that 'np' is only used within the
for_each_possible_cpu(), reduce its scope to release the nood after
every iteration of the loop.

Fixes: 6abf32f1d9 ("cpuidle: Add RISC-V SBI CPU idle driver")
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20241116-cpuidle-riscv-sbi-cleanup-v3-1-a3a46372ce08@gmail.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2025-01-17 13:36:16 +01:00

..

governors

…

coupled.c

…

cpuidle-arm.c

…

cpuidle-at91.c

…

cpuidle-big_little.c

…

cpuidle-calxeda.c

…

cpuidle-clps711x.c

…

cpuidle-cps.c

…

cpuidle-exynos.c

…

cpuidle-haltpoll.c

…

cpuidle-kirkwood.c

…

cpuidle-mvebu-v7.c

…

cpuidle-powernv.c

…

cpuidle-psci-domain.c

…

cpuidle-psci.c

…

cpuidle-psci.h

…

cpuidle-pseries.c

…

cpuidle-qcom-spm.c

…

cpuidle-riscv-sbi.c

…

cpuidle-tegra.c

…

cpuidle-ux500.c

…

cpuidle-zynq.c

…

cpuidle.c

…

cpuidle.h

…

driver.c

…

dt_idle_genpd.c

…

dt_idle_genpd.h

…

dt_idle_states.c

…

dt_idle_states.h

…

governor.c

…

Kconfig

…

Kconfig.arm

…

Kconfig.mips

…

Kconfig.powerpc

…

Kconfig.riscv

…

Makefile

…

poll_state.c

…

sysfs.c

…