Mauro Carvalho Chehab f7503fd2d7 media: v4l2-ctrls-api: fix error handling for v4l2_g_ctrl() ...

commit 4c76f331a9 upstream.

As detected by Coverity, the error check logic at get_ctrl() is
broken: if ptr_to_user() fails to fill a control due to an error,
no errors are returned and v4l2_g_ctrl() returns success on a
failed operation, which may cause applications to fail.

Add an error check at get_ctrl() and ensure that it will
be returned to userspace without filling the control value if
get_ctrl() fails.

Fixes: 71c689dc2e ("media: v4l2-ctrls: split up into four source files")
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2024-11-14 13:15:14 +01:00

..

cec

media: pulse8-cec: fix data timestamp at pulse8_setup()

2024-11-14 13:15:14 +01:00

common

media: v4l2-tpg: prevent the risk of a division by zero

2024-11-14 13:15:14 +01:00

dvb-core

media: dvb_frontend: don't play tricks with underflow values

2024-11-14 13:15:12 +01:00

dvb-frontends

media: cx24116: prevent overflows on SNR calculus

2024-11-14 13:15:13 +01:00

firewire

…

i2c

media: ar0521: don't overflow when checking PLL values

2024-11-14 13:15:13 +01:00

mc

…

mmc

…

pci

…

platform

media: s5p-jpeg: prevent buffer overflows

2024-11-14 13:15:13 +01:00

radio

…

rc

…

spi

…

test-drivers

…

tuners

Revert "media: tuners: fix error return code of hybrid_tuner_request_state()"

2024-10-17 15:21:16 +02:00

usb

media: usbtv: Remove useless locks in usbtv_video_free()

2024-10-17 15:21:33 +02:00

v4l2-core

media: v4l2-ctrls-api: fix error handling for v4l2_g_ctrl()

2024-11-14 13:15:14 +01:00

Kconfig

…

Makefile

…