Tetsuo Handa df1b53bc79 Input: iforce - wake up after clearing IFORCE_XMIT_RUNNING flag ...

commit 98e0121570 upstream.

syzbot is reporting hung task at __input_unregister_device() [1], for
iforce_close() waiting at wait_event_interruptible() with dev->mutex held
is blocking input_disconnect_device() from __input_unregister_device().

It seems that the cause is simply that commit c2b27ef672 ("Input:
iforce - wait for command completion when closing the device") forgot to
call wake_up() after clear_bit().

Fix this problem by introducing a helper that calls clear_bit() followed
by wake_up_all().

Reported-by: syzbot <syzbot+deb6abc36aad4008f407@syzkaller.appspotmail.com>
Fixes: c2b27ef672 ("Input: iforce - wait for command completion when closing the device")
Tested-by: syzbot <syzbot+deb6abc36aad4008f407@syzkaller.appspotmail.com>
Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Co-developed-by: Hillf Danton <hdanton@sina.com>
Signed-off-by: Hillf Danton <hdanton@sina.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Link: https://lore.kernel.org/r/887021c3-4f13-40ce-c8b9-aa6e09faa3a7@I-love.SAKURA.ne.jp
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2022-09-08 12:28:03 +02:00

..

iforce

…

a3d.c

…

adc-joystick.c

…

adi.c

…

amijoy.c

…

analog.c

…

as5011.c

…

cobra.c

…

db9.c

…

fsia6b.c

…

gamecon.c

…

gf2k.c

…

grip_mp.c

…

grip.c

…

guillemot.c

…

interact.c

…

joydump.c

…

Kconfig

…

magellan.c

…

Makefile

…

maplecontrol.c

…

n64joy.c

…

psxpad-spi.c

…

pxrc.c

…

qwiic-joystick.c

…

sidewinder.c

…

spaceball.c

…

spaceorb.c

…

stinger.c

…

tmdc.c

…

turbografx.c

…

twidjoy.c

…

walkera0701.c

…

warrior.c

…

xpad.c

…

zhenhua.c

…