Namhyung Kim ce1ecccd6d perf tools: Fix build-id event recording ...

[ Upstream commit 23c44f6c83 ]

The build-id events written at the end of the record session are broken
due to unexpected data.  The write_buildid() writes the fixed length
event first and then variable length filename.

But a recent change made it write more data in the padding area
accidentally.  So readers of the event see zero-filled data for the
next entry and treat it incorrectly.  This resulted in wrong kernel
symbols because the kernel DSO loaded a random vmlinux image in the
path as it didn't have a valid build-id.

Fixes: ae39ba1655 ("perf inject: Fix build ID injection")
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/Z0aRFFW9xMh3mqKB@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-12-19 18:13:10 +01:00

..

arm-spe-decoder

move asm/unaligned.h to linux/unaligned.h

2024-10-02 17:23:23 -04:00

bpf_skel

perf trace augmented_raw_syscalls: Add more checks to pass the verifier

2024-10-23 11:34:56 -03:00

cs-etm-decoder

perf: cs-etm: Print queue number in raw trace dump

2024-08-29 15:56:37 -03:00

hisi-ptt-decoder

perf util: Make util its own library

2024-06-26 11:07:42 -07:00

include

perf annotate: Update parameters for reg extract functions to use raw instruction on powerpc

2024-07-31 16:12:59 -03:00

intel-pt-decoder

move asm/unaligned.h to linux/unaligned.h

2024-10-02 17:23:23 -04:00

libunwind

…

perf-regs-arch

perf util: Make util its own library

2024-06-26 11:07:42 -07:00

scripting-engines

perf script python: Avoid buffer overflow in python PEBS register interface

2024-09-06 11:44:58 -03:00

addr_location.c

…

addr_location.h

…

affinity.c

…

affinity.h

…

amd-sample-raw.c

…

annotate-data.c

perf annotate-data: Add pr_debug_scope()

2024-09-10 17:32:47 -03:00

annotate-data.h

perf annotate-data: Copy back variable types after move

2024-08-22 12:38:18 -03:00

annotate.c

perf env: Find correct branch counter info on hybrid

2024-09-11 13:08:46 -03:00

annotate.h

perf annotate: Display the branch counter histogram

2024-08-14 10:20:40 -03:00

archinsn.h

…

arm64-frame-pointer-unwind-support.c

…

arm64-frame-pointer-unwind-support.h

…

arm-spe.c

perf tool: Constify tool pointers

2024-08-12 18:05:14 -03:00

arm-spe.h

…

auxtrace.c

perf auxtrace: Use evsel__is_aux_event() for checking AUX event

2024-08-28 18:14:42 -03:00

auxtrace.h

perf auxtrace: Remove unused 'pmu' pointer from struct auxtrace_record

2024-08-28 18:15:16 -03:00

block-info.c

perf report: Display the branch counter histogram

2024-08-14 10:20:40 -03:00

block-info.h

perf report: Display the branch counter histogram

2024-08-14 10:20:40 -03:00

block-range.c

…

block-range.h

…

bpf_counter_cgroup.c

perf stat: Constify control data for BPF

2024-09-03 11:43:16 -03:00

bpf_counter.c

…

bpf_counter.h

…

bpf_ftrace.c

perf ftrace latency: Constify control data for BPF

2024-09-03 11:47:02 -03:00

bpf_kwork_top.c

perf kwork: Constify control data for BPF

2024-09-03 11:50:20 -03:00

bpf_kwork.c

perf kwork: Constify control data for BPF

2024-09-03 11:50:20 -03:00

bpf_lock_contention.c

perf lock contention: Constify control data for BPF

2024-09-03 11:53:15 -03:00

bpf_map.c

perf bpf: Remove redundant check that map is NULL

2024-08-21 11:39:51 -03:00

bpf_map.h

…

bpf_off_cpu.c

perf record offcpu: Constify control data for BPF

2024-09-03 11:54:47 -03:00

bpf-event.c

perf tool: Constify tool pointers

2024-08-12 18:05:14 -03:00

bpf-event.h

…

bpf-filter.c

perf bpf-filter: Return -ENOMEM directly when pfi allocation fails

2024-12-05 14:02:27 +01:00

bpf-filter.h

perf bpf-filter: Support pin/unpin BPF object

2024-08-01 12:11:33 -03:00

bpf-filter.l

perf bpf-filter: Support filtering on cgroups

2024-08-28 18:21:49 -03:00

bpf-filter.y

perf bpf-filter: Support filtering on cgroups

2024-08-28 18:21:49 -03:00

bpf-prologue.h

…

bpf-utils.c

…

bpf-utils.h

…

branch.c

…

branch.h

perf annotate: Save branch counters for each block

2024-08-14 10:20:40 -03:00

Build

perf report: Support LLVM for addr2line()

2024-09-03 10:15:16 -03:00

build-id.c

perf tools: Fix build-id event recording

2024-12-19 18:13:10 +01:00

build-id.h

perf buildid-list: Use perf_tool__init

2024-08-12 18:07:10 -03:00

cache.h

…

cacheline.c

…

cacheline.h

…

call-path.c

…

call-path.h

…

callchain.c

perf callchain: Allow symbols to be optional when resolving a callchain

2024-09-10 17:32:47 -03:00

callchain.h

perf callchain: Allow symbols to be optional when resolving a callchain

2024-09-10 17:32:47 -03:00

cap.c

perf cap: Add __NR_capget to arch/x86 unistd

2024-10-28 13:04:52 -03:00

cap.h

perf cap: Tidy up and improve capability testing

2024-08-20 17:53:12 -03:00

cgroup.c

perf tools: Ignore deleted cgroups

2024-05-10 10:52:46 -03:00

cgroup.h

…

clockid.c

…

clockid.h

…

cloexec.c

…

cloexec.h

…

color_config.c

…

color.c

…

color.h

…

comm.c

perf comm str: Avoid sort during insert

2024-07-03 14:59:15 -07:00

comm.h

…

compress.h

…

config.c

…

config.h

…

copyfile.c

…

copyfile.h

…

counts.c

…

counts.h

…

cpu-set-sched.h

…

cpumap.c

perf cpumap: Remove refcnt from 'struct cpu_aggr_map'

2024-05-07 18:06:44 -03:00

cpumap.h

perf cpumap: Remove refcnt from 'struct cpu_aggr_map'

2024-05-07 18:06:44 -03:00

cputopo.c

…

cputopo.h

…

cs-etm-base.c

…

cs-etm.c

perf cs-etm: Don't flush when packet_queue fills up

2024-12-05 14:02:17 +01:00

cs-etm.h

perf: cs-etm: Create decoders based on the trace ID mappings

2024-08-29 15:55:24 -03:00

data-convert-bt.c

perf data convert ctf: Use perf_tool__init()

2024-08-12 18:13:00 -03:00

data-convert-json.c

perf data convert json: Use perf_tool__init()

2024-08-12 18:12:44 -03:00

data-convert.h

…

data.c

perf data: Allow to use given fd in data->file.fd

2024-08-12 18:15:39 -03:00

data.h

…

db-export.c

perf dso: Add reference count checking and accessor functions

2024-05-06 15:28:49 -03:00

db-export.h

…

debug.c

…

debug.h

…

debuginfo.c

…

debuginfo.h

perf debuginfo: Fix the build with !HAVE_DWARF_SUPPORT

2024-08-09 17:37:03 -03:00

demangle-cxx.cpp

…

demangle-cxx.h

…

demangle-java.c

…

demangle-java.h

…

demangle-ocaml.c

…

demangle-ocaml.h

…

demangle-rust.c

…

demangle-rust.h

…

disasm_bpf.c

perf bpf: Move BPF disassembly routines to separate file to avoid clash with capstone bpf headers

2024-08-01 18:54:19 -03:00

disasm_bpf.h

perf bpf: Move BPF disassembly routines to separate file to avoid clash with capstone bpf headers

2024-08-01 18:54:19 -03:00

disasm.c

perf disasm: Fix not cleaning up disasm_line in symbol__disassemble_raw()

2024-12-05 14:02:21 +01:00

disasm.h

perf annotate: Set instruction name to be used with insn-stat when using raw instruction

2024-07-31 16:12:59 -03:00

dlfilter.c

perf dso: Add reference count checking and accessor functions

2024-05-06 15:28:49 -03:00

dlfilter.h

…

dso.c

perf dso: Constify dso_id

2024-08-19 14:52:13 -03:00

dso.h

perf dso: Constify dso_id

2024-08-19 14:52:13 -03:00

dsos.c

perf dso: Constify dso_id

2024-08-19 14:52:13 -03:00

dsos.h

perf dso: Constify dso_id

2024-08-19 14:52:13 -03:00

dump-insn.c

perf script: Minimize "not reaching sample" for '-F +brstackinsn'

2024-09-03 12:22:01 -03:00

dump-insn.h

perf script: Minimize "not reaching sample" for '-F +brstackinsn'

2024-09-03 12:22:01 -03:00

dwarf-aux.c

perf dwarf-aux: Handle bitfield members from pointer access

2024-08-22 12:32:18 -03:00

dwarf-aux.h

perf dwarf-aux: Fix build with !HAVE_DWARF_GETLOCATIONS_SUPPORT

2024-10-02 18:21:49 -03:00

dwarf-regs.c

…

env.c

perf env: Find correct branch counter info on hybrid

2024-09-11 13:08:46 -03:00

env.h

perf env: Find correct branch counter info on hybrid

2024-09-11 13:08:46 -03:00

event.c

perf buildid-list: Use perf_tool__init

2024-08-12 18:07:10 -03:00

event.h

perf buildid-list: Use perf_tool__init

2024-08-12 18:07:10 -03:00

events_stats.h

perf tools: Print lost samples due to BPF filter

2024-08-28 18:07:20 -03:00

evlist.c

perf stat: Close cork_fd when create_perf_stat_counter() failed

2024-12-05 14:02:18 +01:00

evlist.h

perf stat: Close cork_fd when create_perf_stat_counter() failed

2024-12-05 14:02:18 +01:00

evsel_config.h

…

evsel_fprintf.c

perf python: Remove PYTHON_PERF ifdefs

2024-08-01 18:55:55 -03:00

evsel_fprintf.h

…

evsel.c

perf evsel: Add accessor for tool_event

2024-09-11 11:28:27 -03:00

evsel.h

perf evsel: Add accessor for tool_event

2024-09-11 11:28:27 -03:00

evswitch.c

…

evswitch.h

…

expr.c

perf: parse-events: Fix compilation error while defining DEBUG_PARSER

2024-06-06 00:19:36 -07:00

expr.h

…

expr.l

…

expr.y

…

find-map.c

…

fncache.c

…

fncache.h

…

ftrace.h

perf ftrace: Add 'profile' command

2024-07-31 16:58:18 -03:00

genelf_debug.c

…

genelf.c

perf genelf: remove unused struct 'options'

2024-06-03 22:07:52 -07:00

genelf.h

…

generate-cmdlist.sh

…

get_current_dir_name.c

…

get_current_dir_name.h

…

hashmap.c

…

hashmap.h

…

header.c

perf header: Remove repipe option

2024-08-30 09:24:27 -03:00

header.h

perf header: Remove repipe option

2024-08-30 09:24:27 -03:00

help-unknown-cmd.c

…

help-unknown-cmd.h

…

hisi-ptt.c

perf tool: Constify tool pointers

2024-08-12 18:05:14 -03:00

hisi-ptt.h

…

hist.c

perf report: Fix segfault when 'sym' sort key is not used

2024-08-28 18:20:38 -03:00

hist.h

perf tools: Print lost samples due to BPF filter

2024-08-28 18:07:20 -03:00

intel-bts.c

perf tool: Constify tool pointers

2024-08-12 18:05:14 -03:00

intel-bts.h

…

intel-pt.c

perf tool: Constify tool pointers

2024-08-12 18:05:14 -03:00

intel-pt.h

…

intel-tpebs.c

perf stat: Fork and launch 'perf record' when 'perf stat' needs to get retire latency value for a metric.

2024-08-13 15:24:48 -03:00

intel-tpebs.h

perf stat: Fork and launch 'perf record' when 'perf stat' needs to get retire latency value for a metric.

2024-08-13 15:24:48 -03:00

intlist.c

…

intlist.h

…

iostat.c

…

iostat.h

…

jit.h

perf jit: Constify filename argument

2024-08-19 14:51:46 -03:00

jitdump.c

perf jit: Constify filename argument

2024-08-19 14:51:46 -03:00

jitdump.h

…

kvm-stat.h

…

kwork.h

…

levenshtein.c

…

levenshtein.h

…

llvm-c-helpers.cpp

perf annotate: LLVM-based disassembler

2024-09-03 10:39:20 -03:00

llvm-c-helpers.h

perf annotate: LLVM-based disassembler

2024-09-03 10:39:20 -03:00

lock-contention.h

…

lzma.c

…

machine.c

perf dso: Fix symtab_type for kmod compression

2024-12-05 14:02:20 +01:00

machine.h

perf callchain: Allow symbols to be optional when resolving a callchain

2024-09-10 17:32:47 -03:00

map_symbol.c

perf hist: Correct hist_entry->mem_info refcounts

2024-08-01 18:55:55 -03:00

map_symbol.h

perf hist: Correct hist_entry->mem_info refcounts

2024-08-01 18:55:55 -03:00

map.c

perf inject: Lazy build-id mmap2 event insertion

2024-09-10 17:32:47 -03:00

map.h

perf inject: Lazy build-id mmap2 event insertion

2024-09-10 17:32:47 -03:00

maps.c

perf maps: Add/use a sorted insert for fixup overlap and insert

2024-06-06 23:31:30 -07:00

maps.h

…

mem2node.c

…

mem2node.h

…

mem-events.c

perf mem: Fix printing PERF_MEM_LVLNUM_{L2_MHB|MSC}

2024-12-05 14:02:18 +01:00

mem-events.h

perf mem: Fix missed p-core mem events on ADL and RPL

2024-09-06 11:45:17 -03:00

mem-info.c

perf hist: Correct hist_entry->mem_info refcounts

2024-08-01 18:55:55 -03:00

mem-info.h

perf hist: Correct hist_entry->mem_info refcounts

2024-08-01 18:55:55 -03:00

memswap.c

…

memswap.h

…

metricgroup.c

perf pmus: Fake PMU clean up

2024-09-11 11:27:42 -03:00

metricgroup.h

…

mmap.c

perf python: Remove PYTHON_PERF ifdefs

2024-08-01 18:55:55 -03:00

mmap.h

…

mutex.c

…

mutex.h

…

namespaces.c

…

namespaces.h

…

off_cpu.h

…

ordered-events.c

…

ordered-events.h

…

parse-branch-options.c

…

parse-branch-options.h

…

parse-events.c

perf pmus: Fake PMU clean up

2024-09-11 11:27:42 -03:00

parse-events.h

perf pmus: Fake PMU clean up

2024-09-11 11:27:42 -03:00

parse-events.l

perf parse-events: Add a retirement latency modifier

2024-08-12 18:15:27 -03:00

parse-events.y

Revert "perf parse-events: Prefer sysfs/JSON hardware events over legacy"

2024-05-26 08:41:34 -03:00

parse-regs-options.c

…

parse-regs-options.h

…

parse-sublevel-options.c

…

parse-sublevel-options.h

…

path.c

…

path.h

…

perf_api_probe.c

…

perf_api_probe.h

…

perf_event_attr_fprintf.c

…

perf_regs.c

…

perf_regs.h

…

perf-hooks-list.h

…

perf-hooks.c

…

perf-hooks.h

…

PERF-VERSION-GEN

…

pfm.c

perf list: Fix topic and pmu_name argument order

2024-12-05 14:02:24 +01:00

pfm.h

…

pmu.c

perf pmu: To info add event_type_desc

2024-09-11 11:29:20 -03:00

pmu.h

perf pmu: To info add event_type_desc

2024-09-11 11:29:20 -03:00

pmu.l

…

pmu.y

…

pmus.c

perf list: Fix topic and pmu_name argument order

2024-12-05 14:02:24 +01:00

pmus.h

perf pmus: Fake PMU clean up

2024-09-11 11:27:42 -03:00

print_binary.c

…

print_binary.h

…

print_insn.c

perf annotate: Use capstone_init and remove open_capstone_handle from disasm.c

2024-07-31 16:12:59 -03:00

print_insn.h

perf annotate: Use capstone_init and remove open_capstone_handle from disasm.c

2024-07-31 16:12:59 -03:00

print-events.c

perf list: Give clues if failed to open tracing events directory

2024-08-01 12:11:33 -03:00

print-events.h

…

probe-event.c

perf dso: Add reference count checking and accessor functions

2024-05-06 15:28:49 -03:00

probe-event.h

…

probe-file.c

…

probe-file.h

…

probe-finder.c

perf probe: Correct demangled symbols in C++ program

2024-12-05 14:02:20 +01:00

probe-finder.h

perf probe: Fix libdw memory leak

2024-12-05 14:02:20 +01:00

pstack.c

…

pstack.h

…

python.c

perf python: Fix up the build on architectures without HAVE_KVM_STAT_SUPPORT

2024-10-23 19:29:50 -03:00

rb_resort.h

…

rblist.c

…

rblist.h

…

record.c

…

record.h

…

rlimit.c

…

rlimit.h

…

rwsem.c

…

rwsem.h

…

s390-cpumcf-kernel.h

…

s390-cpumsf-kernel.h

…

s390-cpumsf.c

perf tool: Constify tool pointers

2024-08-12 18:05:14 -03:00

s390-cpumsf.h

…

s390-sample-raw.c

…

sample-raw.c

…

sample-raw.h

…

sample.h

…

session.c

perf env: Find correct branch counter info on hybrid

2024-09-11 13:08:46 -03:00

session.h

perf inject: Overhaul handling of pipe files

2024-08-30 09:23:51 -03:00

setns.c

…

setup.py

perf python: Disable -Wno-cast-function-type-mismatch if present on clang

2024-08-22 17:26:50 -03:00

sharded_mutex.c

…

sharded_mutex.h

…

sideband_evlist.c

…

smt.c

…

smt.h

…

sort.c

perf annotate-data: Add 'typecln' sort key

2024-08-21 11:48:43 -03:00

sort.h

perf annotate-data: Add 'typecln' sort key

2024-08-21 11:48:43 -03:00

spark.c

…

spark.h

…

srccode.c

…

srccode.h

…

srcline.c

perf report: Support LLVM for addr2line()

2024-09-03 10:15:16 -03:00

srcline.h

…

stat-display.c

perf stat: Display iostat headers correctly

2024-08-16 19:35:18 -03:00

stat-shadow.c

perf evsel: Add accessor for tool_event

2024-09-11 11:28:27 -03:00

stat.c

…

stat.h

…

strbuf.c

…

strbuf.h

…

stream.c

…

stream.h

…

strfilter.c

…

strfilter.h

…

string2.h

…

string.c

…

strlist.c

…

strlist.h

…

svghelper.c

…

svghelper.h

…

symbol_conf.h

perf script: add --addr2line option

2024-08-12 13:59:22 -03:00

symbol_fprintf.c

perf dso: Add reference count checking and accessor functions

2024-05-06 15:28:49 -03:00

symbol-elf.c

perf symbol-elf: dso__load_sym_internal() reference count fixes

2024-05-06 16:07:30 -03:00

symbol-minimal.c

perf dso: Add reference count checking and accessor functions

2024-05-06 15:28:49 -03:00

symbol.c

perf symbol: Set binary_type of dso when loading

2024-09-22 23:46:18 +02:00

symbol.h

perf mem-info: Move mem-info out of mem-events and symbol

2024-05-07 18:06:44 -03:00

symsrc.h

…

synthetic-events.c

perf inject: Add new mmap2-buildid-all option

2024-09-10 17:32:47 -03:00

synthetic-events.h

perf inject: Add new mmap2-buildid-all option

2024-09-10 17:32:47 -03:00

syscalltbl.c

perf trace: Fix non-listed archs in the syscalltbl routines

2024-10-23 11:34:56 -03:00

syscalltbl.h

perf trace: Fix iteration of syscall ids in syscalltbl->entries

2024-07-12 09:49:02 -07:00

target.c

…

target.h

…

term.c

…

term.h

…

thread_map.c

…

thread_map.h

…

thread-stack.c

…

thread-stack.h

…

thread.c

perf callchain: Fix stitch LBR memory leaks

2024-08-08 17:30:27 -03:00

thread.h

perf callchain: Fix stitch LBR memory leaks

2024-08-08 17:30:27 -03:00

threads.c

…

threads.h

…

time-utils.c

perf time-utils: Fix 32-bit nsec parsing

2024-09-03 11:21:55 -03:00

time-utils.h

…

tool.c

perf tool: Remove perf_tool__fill_defaults()

2024-08-12 18:13:58 -03:00

tool.h

perf tool: Remove perf_tool__fill_defaults()

2024-08-12 18:13:58 -03:00

top.c

…

top.h

…

topdown.c

…

topdown.h

…

trace_augment.h

perf trace: Pretty print buffer data

2024-09-10 09:52:13 -03:00

trace-event-info.c

…

trace-event-parse.c

…

trace-event-read.c

…

trace-event-scripting.c

…

trace-event.c

…

trace-event.h

…

tracepoint.c

perf tracepoint: Don't scan all tracepoints to test if one exists

2024-05-09 18:46:43 -03:00

tracepoint.h

perf tracepoint: Don't scan all tracepoints to test if one exists

2024-05-09 18:46:43 -03:00

trigger.h

…

tsc.c

perf tool: Constify tool pointers

2024-08-12 18:05:14 -03:00

tsc.h

…

units.c

…

units.h

…

unwind-libdw.c

perf dso: Fix address sanitizer build

2024-07-12 09:38:41 -07:00

unwind-libdw.h

…

unwind-libunwind-local.c

perf dso: Fix build when libunwind is enabled

2024-07-17 13:17:57 -07:00

unwind-libunwind.c

perf dso: Add reference count checking and accessor functions

2024-05-06 15:28:49 -03:00

unwind.h

…

usage.c

…

util.c

perf cap: Tidy up and improve capability testing

2024-08-20 17:53:12 -03:00

util.h

…

values.c

…

values.h

…

vdso.c

perf vdso: Missed put on 32-bit dsos

2024-09-27 15:38:52 -03:00

vdso.h

…

zlib.c

…

zstd.c

…