Ioana Ciornei 1d5baab39e bus: fsl-mc: fix double-free on mc_dev ...

[ Upstream commit d694bf8a9a ]

The blamed commit tried to simplify how the deallocations are done but,
in the process, introduced a double-free on the mc_dev variable.

In case the MC device is a DPRC, a new mc_bus is allocated and the
mc_dev variable is just a reference to one of its fields. In this
circumstance, on the error path only the mc_bus should be freed.

This commit introduces back the following checkpatch warning which is a
false-positive.

WARNING: kfree(NULL) is safe and this check is probably not required
+       if (mc_bus)
+               kfree(mc_bus);

Fixes: a042fbed02 ("staging: fsl-mc: simplify couple of deallocations")
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/20250408105814.2837951-2-ioana.ciornei@nxp.com
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2025-06-19 15:32:01 +02:00

..

fsl-mc

bus: fsl-mc: fix double-free on mc_dev

2025-06-19 15:32:01 +02:00

mhi

bus: mhi: host: Fix race between unprepare and queue_buf

2025-04-20 10:15:42 +02:00

arm-cci.c

…

arm-integrator-lm.c

…

brcmstb_gisb.c

…

bt1-apb.c

…

bt1-axi.c

…

da8xx-mstpri.c

…

hisi_lpc.c

…

imx-weim.c

…

intel-ixp4xx-eb.c

…

Kconfig

…

Makefile

…

mips_cdmm.c

…

moxtet.c

…

mvebu-mbus.c

…

omap_l3_noc.c

…

omap_l3_noc.h

…

omap_l3_smx.c

…

omap_l3_smx.h

…

omap-ocp2scp.c

…

qcom-ebi2.c

…

qcom-ssc-block-bus.c

…

simple-pm-bus.c

…

stm32_etzpc.c

…

stm32_firewall.c

…

stm32_firewall.h

…

stm32_rifsc.c

…

sun50i-de2.c

…

sunxi-rsb.c

…

tegra-aconnect.c

…

tegra-gmi.c

…

ti-pwmss.c

…

ti-sysc.c

…

ts-nbus.c

…

uniphier-system-bus.c

…

vexpress-config.c

…