mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-03-03 18:28:01 +01:00
39e94fdce4
We have only two users of fixed_phy_add(), both use address 0 and ignore the return value. So simplify fixed_phy_add() accordingly. Whilst at it, constify the fixed_phy_status configs. Note: fixed_phy_add() is a legacy function which shouldn't be used in new code, as it's use may be problematic: - No check whether a fixed phy exists already at the given address - If fixed_phy_register() is called afterwards by any other driver, then it will also use phy_addr 0, because fixed_phy_add() ignores the ida which manages address assignment Drivers using a fixed phy created by fixed_phy_add() in platform code, should dynamically create a fixed phy with fixed_phy_register() instead. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Link: https://patch.msgid.link/762700e5-a0b1-41af-aa03-929822a39475@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
53 lines
1.3 KiB
C
53 lines
1.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __PHY_FIXED_H
|
|
#define __PHY_FIXED_H
|
|
|
|
#include <linux/types.h>
|
|
|
|
struct fixed_phy_status {
|
|
int link;
|
|
int speed;
|
|
int duplex;
|
|
int pause;
|
|
int asym_pause;
|
|
};
|
|
|
|
struct device_node;
|
|
struct net_device;
|
|
|
|
#if IS_ENABLED(CONFIG_FIXED_PHY)
|
|
extern int fixed_phy_change_carrier(struct net_device *dev, bool new_carrier);
|
|
void fixed_phy_add(const struct fixed_phy_status *status);
|
|
struct phy_device *fixed_phy_register(const struct fixed_phy_status *status,
|
|
struct device_node *np);
|
|
|
|
extern void fixed_phy_unregister(struct phy_device *phydev);
|
|
extern int fixed_phy_set_link_update(struct phy_device *phydev,
|
|
int (*link_update)(struct net_device *,
|
|
struct fixed_phy_status *));
|
|
#else
|
|
static inline void fixed_phy_add(const struct fixed_phy_status *status) {}
|
|
static inline struct phy_device *
|
|
fixed_phy_register(const struct fixed_phy_status *status,
|
|
struct device_node *np)
|
|
{
|
|
return ERR_PTR(-ENODEV);
|
|
}
|
|
|
|
static inline void fixed_phy_unregister(struct phy_device *phydev)
|
|
{
|
|
}
|
|
static inline int fixed_phy_set_link_update(struct phy_device *phydev,
|
|
int (*link_update)(struct net_device *,
|
|
struct fixed_phy_status *))
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline int fixed_phy_change_carrier(struct net_device *dev, bool new_carrier)
|
|
{
|
|
return -EINVAL;
|
|
}
|
|
#endif /* CONFIG_FIXED_PHY */
|
|
|
|
#endif /* __PHY_FIXED_H */
|