Kuniyuki Iwashima
33f9e6dc66
atm: atmtcp: Prevent arbitrary write in atmtcp_recv_control().
[ Upstream commit ec79003c5f ]
syzbot reported the splat below. [0]
When atmtcp_v_open() or atmtcp_v_close() is called via connect()
or close(), atmtcp_send_control() is called to send an in-kernel
special message.
The message has ATMTCP_HDR_MAGIC in atmtcp_control.hdr.length.
Also, a pointer of struct atm_vcc is set to atmtcp_control.vcc.
The notable thing is struct atmtcp_control is uAPI but has a
space for an in-kernel pointer.
struct atmtcp_control {
struct atmtcp_hdr hdr; /* must be first */
...
atm_kptr_t vcc; /* both directions */
...
} __ATM_API_ALIGN;
typedef struct { unsigned char _[8]; } __ATM_API_ALIGN atm_kptr_t;
The special message is processed in atmtcp_recv_control() called
from atmtcp_c_send().
atmtcp_c_send() is vcc->dev->ops->send() and called from 2 paths:
1. .ndo_start_xmit() (vcc->send() == atm_send_aal0())
2. vcc_sendmsg()
The problem is sendmsg() does not validate the message length and
userspace can abuse atmtcp_recv_control() to overwrite any kptr
by atmtcp_control.
Let's add a new ->pre_send() hook to validate messages from sendmsg().
[0]:
Oops: general protection fault, probably for non-canonical address 0xdffffc00200000ab: 0000 [#1] SMP KASAN PTI
KASAN: probably user-memory-access in range [0x0000000100000558-0x000000010000055f]
CPU: 0 UID: 0 PID: 5865 Comm: syz-executor331 Not tainted 6.17.0-rc1-syzkaller-00215-gbab3ce404553 #0 PREEMPT(full)
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
RIP: 0010:atmtcp_recv_control drivers/atm/atmtcp.c:93 [inline]
RIP: 0010:atmtcp_c_send+0x1da/0x950 drivers/atm/atmtcp.c:297
Code: 4d 8d 75 1a 4c 89 f0 48 c1 e8 03 42 0f b6 04 20 84 c0 0f 85 15 06 00 00 41 0f b7 1e 4d 8d b7 60 05 00 00 4c 89 f0 48 c1 e8 03 <42> 0f b6 04 20 84 c0 0f 85 13 06 00 00 66 41 89 1e 4d 8d 75 1c 4c
RSP: 0018:ffffc90003f5f810 EFLAGS: 00010203
RAX: 00000000200000ab RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff88802a510000 RSI: 00000000ffffffff RDI: ffff888030a6068c
RBP: ffff88802699fb40 R08: ffff888030a606eb R09: 1ffff1100614c0dd
R10: dffffc0000000000 R11: ffffffff8718fc40 R12: dffffc0000000000
R13: ffff888030a60680 R14: 000000010000055f R15: 00000000ffffffff
FS: 00007f8d7e9236c0(0000) GS:ffff888125c1c000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000045ad50 CR3: 0000000075bde000 CR4: 00000000003526f0
Call Trace:
<TASK>
vcc_sendmsg+0xa10/0xc60 net/atm/common.c:645
sock_sendmsg_nosec net/socket.c:714 [inline]
__sock_sendmsg+0x219/0x270 net/socket.c:729
____sys_sendmsg+0x505/0x830 net/socket.c:2614
___sys_sendmsg+0x21f/0x2a0 net/socket.c:2668
__sys_sendmsg net/socket.c:2700 [inline]
__do_sys_sendmsg net/socket.c:2705 [inline]
__se_sys_sendmsg net/socket.c:2703 [inline]
__x64_sys_sendmsg+0x19b/0x260 net/socket.c:2703
do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f8d7e96a4a9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8d7e923198 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f8d7e9f4308 RCX: 00007f8d7e96a4a9
RDX: 0000000000000000 RSI: 0000200000000240 RDI: 0000000000000005
RBP: 00007f8d7e9f4300 R08: 65732f636f72702f R09: 65732f636f72702f
R10: 65732f636f72702f R11: 0000000000000246 R12: 00007f8d7e9c10ac
R13: 00007f8d7e9231a0 R14: 0000200000000200 R15: 0000200000000250
</TASK>
Modules linked in:
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Reported-by: syzbot+1741b56d54536f4ec349@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/68a6767c.050a0220.3d78fd.0011.GAE@google.com/
Tested-by: syzbot+1741b56d54536f4ec349@syzkaller.appspotmail.com
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20250821021901.2814721-1-kuniyu@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2025-09-04 15:31:47 +02:00
..
2025-06-27 11:11:19 +01:00
2025-05-29 11:03:15 +02:00
2024-12-19 18:13:14 +01:00
2024-12-14 20:03:12 +01:00
2024-12-14 20:03:26 +01:00
2025-05-29 11:02:43 +02:00
2025-05-29 11:02:49 +02:00
2025-08-28 16:31:15 +02:00
2025-06-27 11:11:26 +01:00
2025-02-17 10:04:53 +01:00
2025-02-27 04:30:17 -08:00
2025-04-10 14:39:28 +02:00
2025-05-29 11:03:24 +02:00
2025-03-07 18:25:27 +01:00
2025-08-20 18:30:29 +02:00
2025-08-20 18:30:58 +02:00
2024-12-27 14:02:13 +01:00
2024-12-27 14:01:57 +01:00
2025-06-19 15:31:38 +02:00
2025-09-04 15:31:47 +02:00
2025-08-15 12:13:31 +02:00
2025-04-25 10:47:49 +02:00
2025-02-17 10:04:43 +01:00
2025-06-19 15:32:33 +02:00
2025-08-20 18:30:16 +02:00
2025-05-02 07:58:54 +02:00
2025-08-20 18:30:51 +02:00
2025-07-10 16:05:00 +02:00
2025-05-29 11:02:17 +02:00
2025-04-25 10:48:07 +02:00
2025-02-08 09:57:30 +01:00
2025-05-29 11:02:00 +02:00
2025-06-19 15:32:33 +02:00
2025-08-28 16:31:06 +02:00
2025-04-20 10:15:04 +02:00
2025-04-20 10:15:04 +02:00
2024-12-14 20:03:38 +01:00
2024-12-14 20:04:16 +01:00
2025-03-13 13:01:58 +01:00
2025-03-07 18:25:35 +01:00
2025-08-28 16:31:10 +02:00
2025-04-10 14:39:28 +02:00
2025-06-04 14:43:52 +02:00
2025-06-19 15:32:12 +02:00
2025-07-10 16:05:14 +02:00
2025-05-09 09:50:35 +02:00
2025-07-10 16:05:08 +02:00
2025-05-29 11:03:15 +02:00
2025-09-04 15:31:45 +02:00
2025-05-29 11:01:59 +02:00
2024-12-14 20:04:09 +01:00
2025-02-21 14:01:34 +01:00
2025-05-02 07:58:52 +02:00
2025-05-29 11:03:25 +02:00
2025-03-13 13:02:07 +01:00
2024-12-14 20:03:35 +01:00
2025-05-18 08:24:59 +02:00
2025-07-10 16:05:08 +02:00
2025-06-27 11:11:32 +01:00
2024-12-14 20:03:48 +01:00
2025-01-09 13:33:47 +01:00
2025-08-15 12:13:49 +02:00
2025-08-15 12:13:31 +02:00
2025-07-10 16:05:09 +02:00
2025-04-10 14:39:17 +02:00
2025-06-19 15:32:34 +02:00
2025-05-29 11:03:22 +02:00
2025-02-17 10:05:31 +01:00
2025-01-23 17:23:03 +01:00
2025-06-27 11:11:40 +01:00
2025-05-22 14:29:48 +02:00
2025-08-20 18:30:14 +02:00
2025-07-17 18:37:16 +02:00
2025-08-20 18:30:37 +02:00
2025-04-10 14:39:12 +02:00
2025-04-20 10:15:40 +02:00
2024-12-27 14:02:17 +01:00
2025-05-29 11:03:25 +02:00
2025-01-17 13:40:34 +01:00
2025-05-09 09:50:34 +02:00
2025-08-15 12:14:05 +02:00
2025-08-28 16:31:12 +02:00
2025-08-28 16:31:05 +02:00
2025-05-29 11:02:23 +02:00
2025-08-01 09:48:42 +01:00
2025-02-08 09:57:58 +01:00
2024-12-09 10:41:08 +01:00
2025-08-28 16:31:09 +02:00
2025-03-28 22:03:30 +01:00
2025-05-22 14:29:36 +02:00
2024-12-14 20:04:01 +01:00
2025-08-20 18:30:57 +02:00
2025-05-29 11:02:25 +02:00
2025-07-17 18:37:24 +02:00
2025-06-19 15:31:54 +02:00
2025-01-09 13:33:54 +01:00
2025-08-20 18:30:16 +02:00
2025-01-09 13:33:54 +01:00
2025-07-17 18:37:13 +02:00
2025-05-29 11:03:23 +02:00
2024-12-05 14:03:08 +01:00
2025-05-18 08:24:59 +02:00
2025-08-15 12:13:59 +02:00
2025-01-17 13:40:50 +01:00
2025-02-08 09:57:23 +01:00
2025-05-29 11:02:41 +02:00
2024-12-19 18:13:19 +01:00
2025-02-27 04:30:18 -08:00
2025-08-28 16:31:04 +02:00
2025-02-08 09:57:59 +01:00
2025-06-04 14:43:53 +02:00
2025-08-28 16:31:05 +02:00
2025-04-25 10:47:50 +02:00
2025-04-10 14:39:11 +02:00
2025-03-13 13:02:03 +01:00
2025-06-19 15:32:18 +02:00
2024-12-05 14:03:08 +01:00
2024-12-05 14:03:08 +01:00
2025-06-19 15:32:37 +02:00
2025-08-20 18:30:35 +02:00
2025-05-29 11:03:22 +02:00
2025-04-20 10:15:25 +02:00
2025-05-29 11:02:04 +02:00
2025-06-19 15:32:11 +02:00
2025-08-20 18:30:57 +02:00
2025-05-29 11:03:02 +02:00
2025-04-20 10:15:49 +02:00
2025-06-19 15:31:54 +02:00
2025-03-13 13:02:07 +01:00
2025-06-19 15:32:22 +02:00
2025-04-10 14:39:11 +02:00
2025-05-29 11:02:20 +02:00
2025-06-19 15:31:42 +02:00
2025-01-23 17:22:57 +01:00
2025-08-15 12:13:35 +02:00
2025-04-20 10:15:12 +02:00
2025-08-15 12:13:53 +02:00
2025-01-23 17:22:53 +01:00
2025-08-15 12:13:42 +02:00
2025-07-17 18:37:08 +02:00
2025-02-08 09:57:07 +01:00
2025-05-29 11:03:02 +02:00
2025-03-07 18:25:43 +01:00
2025-05-29 11:03:02 +02:00
2025-08-15 12:13:46 +02:00
2025-08-20 18:30:49 +02:00
2024-12-14 20:03:18 +01:00
2025-03-13 13:01:58 +01:00
2025-02-01 18:39:35 +01:00
2025-02-27 04:30:14 -08:00
2025-02-08 09:57:07 +01:00
2025-08-20 18:30:36 +02:00
2025-02-27 04:30:19 -08:00
2025-03-07 18:25:32 +01:00
2025-07-10 16:04:54 +02:00
2025-08-01 09:48:43 +01:00
2024-12-14 20:03:32 +01:00
2024-12-19 18:13:24 +01:00
2025-06-27 11:11:30 +01:00
2025-04-10 14:39:26 +02:00
2024-12-14 20:04:16 +01:00
2025-05-22 14:29:50 +02:00
2025-04-10 14:39:35 +02:00
2025-05-29 11:02:04 +02:00
2025-05-29 11:02:04 +02:00
2025-05-18 08:24:56 +02:00
2025-04-10 14:39:37 +02:00
2025-07-10 16:05:11 +02:00
2025-01-23 17:23:02 +01:00
2024-12-09 10:41:06 +01:00
2025-08-20 18:30:40 +02:00
2025-05-22 14:29:38 +02:00
2025-05-18 08:24:51 +02:00
2025-01-02 10:34:10 +01:00
2025-08-15 12:14:04 +02:00
2024-12-27 14:02:20 +01:00
2025-01-17 13:40:33 +01:00