mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-01-23 15:12:55 +01:00
013e484dbd
Call kobject_put() for the failure path to release the kobject v2: remove extra newline. (Matt) Fixes:e3d0839aa5("drm/xe/tile: Abort driver load for sysfs creation failure") Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> Reviewed-by: Matthew Brost <matthew.brost@intel.com> Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com> Link: https://lore.kernel.org/r/20250819153950.2973344-2-shuicheng.lin@intel.com Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> (cherry picked from commitb98775bca9) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
62 lines
1.2 KiB
C
62 lines
1.2 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright © 2023 Intel Corporation
|
|
*/
|
|
|
|
#include <linux/kobject.h>
|
|
#include <linux/sysfs.h>
|
|
#include <drm/drm_managed.h>
|
|
|
|
#include "xe_pm.h"
|
|
#include "xe_tile.h"
|
|
#include "xe_tile_sysfs.h"
|
|
#include "xe_vram_freq.h"
|
|
|
|
static void xe_tile_sysfs_kobj_release(struct kobject *kobj)
|
|
{
|
|
kfree(kobj);
|
|
}
|
|
|
|
static const struct kobj_type xe_tile_sysfs_kobj_type = {
|
|
.release = xe_tile_sysfs_kobj_release,
|
|
.sysfs_ops = &kobj_sysfs_ops,
|
|
};
|
|
|
|
static void tile_sysfs_fini(void *arg)
|
|
{
|
|
struct xe_tile *tile = arg;
|
|
|
|
kobject_put(tile->sysfs);
|
|
}
|
|
|
|
int xe_tile_sysfs_init(struct xe_tile *tile)
|
|
{
|
|
struct xe_device *xe = tile_to_xe(tile);
|
|
struct device *dev = xe->drm.dev;
|
|
struct kobj_tile *kt;
|
|
int err;
|
|
|
|
kt = kzalloc(sizeof(*kt), GFP_KERNEL);
|
|
if (!kt)
|
|
return -ENOMEM;
|
|
|
|
kobject_init(&kt->base, &xe_tile_sysfs_kobj_type);
|
|
kt->tile = tile;
|
|
|
|
err = kobject_add(&kt->base, &dev->kobj, "tile%d", tile->id);
|
|
if (err)
|
|
goto err_object;
|
|
|
|
tile->sysfs = &kt->base;
|
|
|
|
err = xe_vram_freq_sysfs_init(tile);
|
|
if (err)
|
|
goto err_object;
|
|
|
|
return devm_add_action_or_reset(xe->drm.dev, tile_sysfs_fini, tile);
|
|
|
|
err_object:
|
|
kobject_put(&kt->base);
|
|
return err;
|
|
}
|