mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-12-26 12:21:01 +01:00
With the introduction of clone3 in commit 7f192e3cd3 ("fork: add
clone3") the effective bit width of clone_flags on all architectures was
increased from 32-bit to 64-bit, with a new type of u64 for the flags.
However, for most consumers of clone_flags the interface was not
changed from the previous type of unsigned long.
While this works fine as long as none of the new 64-bit flag bits
(CLONE_CLEAR_SIGHAND and CLONE_INTO_CGROUP) are evaluated, this is still
undesirable in terms of the principle of least surprise.
Thus, this commit fixes all relevant interfaces of callees to
sys_clone3/copy_process (excluding the architecture-specific
copy_thread) to consistently pass clone_flags as u64, so that
no truncation to 32-bit integers occurs on 32-bit architectures.
Signed-off-by: Simon Schuster <schuster.simon@siemens-energy.com>
Link: https://lore.kernel.org/20250901-nios2-implement-clone3-v2-2-53fcf5577d57@siemens-energy.com
Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
85 lines
1.7 KiB
C
85 lines
1.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Copyright (c) 2022, Microsoft Corporation.
|
|
*
|
|
* Authors:
|
|
* Beau Belgrave <beaub@linux.microsoft.com>
|
|
*/
|
|
|
|
#ifndef _LINUX_USER_EVENTS_H
|
|
#define _LINUX_USER_EVENTS_H
|
|
|
|
#include <linux/list.h>
|
|
#include <linux/refcount.h>
|
|
#include <linux/mm_types.h>
|
|
#include <linux/workqueue.h>
|
|
#include <uapi/linux/user_events.h>
|
|
|
|
#ifdef CONFIG_USER_EVENTS
|
|
struct user_event_mm {
|
|
struct list_head mms_link;
|
|
struct list_head enablers;
|
|
struct mm_struct *mm;
|
|
/* Used for one-shot lists, protected by event_mutex */
|
|
struct user_event_mm *next;
|
|
refcount_t refcnt;
|
|
refcount_t tasks;
|
|
struct rcu_work put_rwork;
|
|
};
|
|
|
|
extern void user_event_mm_dup(struct task_struct *t,
|
|
struct user_event_mm *old_mm);
|
|
|
|
extern void user_event_mm_remove(struct task_struct *t);
|
|
|
|
static inline void user_events_fork(struct task_struct *t,
|
|
u64 clone_flags)
|
|
{
|
|
struct user_event_mm *old_mm;
|
|
|
|
if (!t || !current->user_event_mm)
|
|
return;
|
|
|
|
old_mm = current->user_event_mm;
|
|
|
|
if (clone_flags & CLONE_VM) {
|
|
t->user_event_mm = old_mm;
|
|
refcount_inc(&old_mm->tasks);
|
|
return;
|
|
}
|
|
|
|
user_event_mm_dup(t, old_mm);
|
|
}
|
|
|
|
static inline void user_events_execve(struct task_struct *t)
|
|
{
|
|
if (!t || !t->user_event_mm)
|
|
return;
|
|
|
|
user_event_mm_remove(t);
|
|
}
|
|
|
|
static inline void user_events_exit(struct task_struct *t)
|
|
{
|
|
if (!t || !t->user_event_mm)
|
|
return;
|
|
|
|
user_event_mm_remove(t);
|
|
}
|
|
#else
|
|
static inline void user_events_fork(struct task_struct *t,
|
|
u64 clone_flags)
|
|
{
|
|
}
|
|
|
|
static inline void user_events_execve(struct task_struct *t)
|
|
{
|
|
}
|
|
|
|
static inline void user_events_exit(struct task_struct *t)
|
|
{
|
|
}
|
|
#endif /* CONFIG_USER_EVENTS */
|
|
|
|
#endif /* _LINUX_USER_EVENTS_H */
|