Michael Chan 2b7c5eed19 net: Prevent infinite while loop in skb_tx_hash() ...

commit 0c57eeecc5 upstream.

Drivers call netdev_set_num_tc() and then netdev_set_tc_queue()
to set the queue count and offset for each TC.  So the queue count
and offset for the TCs may be zero for a short period after dev->num_tc
has been set.  If a TX packet is being transmitted at this time in the
code path netdev_pick_tx() -> skb_tx_hash(), skb_tx_hash() may see
nonzero dev->num_tc but zero qcount for the TC.  The while loop that
keeps looping while hash >= qcount will not end.

Fix it by checking the TC's qcount to be nonzero before using it.

Fixes: eadec877ce ("net: Add support for subordinate traffic classes to netdev_pick_tx")
Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2021-11-02 19:48:22 +01:00

..

bpf_sk_storage.c

…

datagram.c

…

datagram.h

…

dev_addr_lists.c

…

dev_ioctl.c

…

dev.c

net: Prevent infinite while loop in skb_tx_hash()

2021-11-02 19:48:22 +01:00

devlink.c

devlink: Clear whole devlink_flash_notify struct

2021-09-15 09:50:40 +02:00

drop_monitor.c

…

dst_cache.c

…

dst.c

net, bpf: Fix ip6ip6 crash with collect_md populated skbs

2021-03-30 14:32:05 +02:00

failover.c

…

fib_notifier.c

…

fib_rules.c

fib: Return the correct errno code

2021-06-18 10:00:06 +02:00

filter.c

bpf: Do not change gso_size during bpf_skb_change_proto()

2021-07-14 16:56:27 +02:00

flow_dissector.c

flow_dissector: Fix out-of-bounds warnings

2021-09-18 13:40:22 +02:00

flow_offload.c

net: Fix offloading indirect devices dependency on qdisc order creation

2021-09-18 13:40:30 +02:00

gen_estimator.c

…

gen_stats.c

…

gro_cells.c

…

hwbm.c

…

link_watch.c

net: linkwatch: fix failure to restore device state across suspend/resume

2021-08-18 08:59:13 +02:00

lwt_bpf.c

…

lwtunnel.c

…

Makefile

…

neighbour.c

neighbour: allow NUD_NOARP entries to be forced GCed

2021-06-10 13:39:29 +02:00

net_namespace.c

net: make get_net_ns return error if NET_NS is disabled

2021-06-23 14:42:44 +02:00

net-procfs.c

…

net-sysfs.c

net-sysfs: initialize uid and gid before calling net_ns_get_ownership

2021-11-02 19:48:22 +01:00

net-sysfs.h

…

net-traces.c

…

netclassid_cgroup.c

…

netevent.c

…

netpoll.c

…

netprio_cgroup.c

…

page_pool.c

mm: fix struct page layout on 32-bit systems

2021-05-19 10:13:17 +02:00

pktgen.c

…

ptp_classifier.c

…

request_sock.c

…

rtnetlink.c

rtnetlink: fix if_nlmsg_stats_size() under estimation

2021-10-13 10:04:28 +02:00

scm.c

…

secure_seq.c

…

skbuff.c

net: Fix zero-copy head len calculation.

2021-08-08 09:05:23 +02:00

skmsg.c

skmsg: Make sk_psock_destroy() static

2021-08-04 12:46:44 +02:00

sock_diag.c

…

sock_map.c

…

sock_reuseport.c

…

sock.c

af_unix: fix races in sk_peer_pid and sk_peer_cred accesses

2021-10-06 15:55:58 +02:00

stream.c

…

sysctl_net_core.c

…

timestamping.c

…

tso.c

…

utils.c

…

xdp.c

xdp: fix xdp_return_frame() kernel BUG throw for page_pool memory model

2021-04-14 08:42:09 +02:00