Vladislav Efanov f03bc01360 udp6: Fix race condition in udp6_sendmsg & connect ...

[ Upstream commit 448a5ce112 ]

Syzkaller got the following report:
BUG: KASAN: use-after-free in sk_setup_caps+0x621/0x690 net/core/sock.c:2018
Read of size 8 at addr ffff888027f82780 by task syz-executor276/3255

The function sk_setup_caps (called by ip6_sk_dst_store_flow->
ip6_dst_store) referenced already freed memory as this memory was
freed by parallel task in udpv6_sendmsg->ip6_sk_dst_lookup_flow->
sk_dst_check.

          task1 (connect)              task2 (udp6_sendmsg)
        sk_setup_caps->sk_dst_set |
                                  |  sk_dst_check->
                                  |      sk_dst_set
                                  |      dst_release
        sk_setup_caps references  |
        to already freed dst_entry|

The reason for this race condition is: sk_setup_caps() keeps using
the dst after transferring the ownership to the dst cache.

Found by Linux Verification Center (linuxtesting.org) with syzkaller.

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Vladislav Efanov <VEfanov@ispras.ru>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-06-09 10:30:06 +02:00

..

bpf_sk_storage.c

net: Fix data-races around sysctl_optmem_max.

2022-08-31 17:15:20 +02:00

datagram.c

net: datagram: fix data-races in datagram_poll()

2023-05-30 12:57:46 +01:00

datagram.h

…

dev_addr_lists.c

…

dev_ioctl.c

net: socket: remove register_gifconf

2022-09-28 11:10:35 +02:00

dev.c

net: Catch invalid index in XPS mapping

2023-05-30 12:57:48 +01:00

devlink.c

devlink: Fix use-after-free after a failed reload

2022-08-25 11:37:57 +02:00

drop_monitor.c

drop_monitor: fix data-race in dropmon_net_event / trace_napi_poll_hit

2022-02-23 12:01:02 +01:00

dst_cache.c

…

dst.c

…

failover.c

…

fib_notifier.c

…

fib_rules.c

…

filter.c

bpf: bpf_fib_lookup should not return neigh in NUD_FAILED state

2023-03-03 11:44:51 +01:00

flow_dissector.c

netfilter: conntrack: Fix data-races around ct mark

2022-12-02 17:40:00 +01:00

flow_offload.c

netfilter: nf_tables: bail out early if hardware offload is not supported

2022-06-14 18:32:40 +02:00

gen_estimator.c

…

gen_stats.c

…

gro_cells.c

net: Fix data-races around netdev_max_backlog.

2022-08-31 17:15:19 +02:00

hwbm.c

…

link_watch.c

…

lwt_bpf.c

bpf, lwt: Fix crash when using bpf_skb_set_tunnel_key() from bpf_xmit lwt hook

2022-05-09 09:05:02 +02:00

lwtunnel.c

lwtunnel: Validate RTA_ENCAP_TYPE attribute length

2022-01-11 15:25:00 +01:00

Makefile

…

neighbour.c

neigh: make sure used and confirmed times are valid

2023-03-03 11:44:51 +01:00

net_namespace.c

net: fix UaF in netns ops registration error path

2023-02-01 08:23:24 +01:00

net-procfs.c

net-procfs: show net devices bound packet types

2022-02-01 17:25:44 +01:00

net-sysfs.c

net-sysfs: add check for netdevice being present to speed_show

2022-03-16 14:16:00 +01:00

net-sysfs.h

…

net-traces.c

…

netclassid_cgroup.c

…

netevent.c

…

netpoll.c

net: don't let netpoll invoke NAPI if in xmit context

2023-04-20 12:10:21 +02:00

netprio_cgroup.c

…

page_pool.c

…

pktgen.c

…

ptp_classifier.c

…

request_sock.c

…

rtnetlink.c

net: make free_netdev() more lenient with unregistering devices

2022-07-29 17:19:07 +02:00

scm.c

…

secure_seq.c

tcp: Fix data-races around sysctl knobs related to SYN option.

2022-07-29 17:19:21 +02:00

skbuff.c

net: fix skb leak in __skb_tstamp_tx()

2023-05-30 12:57:58 +01:00

skmsg.c

net: fix refcount bug in sk_psock_get (2)

2022-09-05 10:28:56 +02:00

sock_diag.c

…

sock_map.c

bpf, sockmap: Revert buggy deadlock fix in the sockhash and sockmap

2023-05-17 11:47:52 +02:00

sock_reuseport.c

udp: Update reuse->has_conns under reuseport_lock.

2022-10-30 09:41:19 +01:00

sock.c

udp6: Fix race condition in udp6_sendmsg & connect

2023-06-09 10:30:06 +02:00

stream.c

net: deal with most data-races in sk_wait_event()

2023-05-30 12:57:46 +01:00

sysctl_net_core.c

net: Fix data-races around weight_p and dev_weight_[rt]x_bias.

2022-08-31 17:15:19 +02:00

timestamping.c

…

tso.c

…

utils.c

…

xdp.c

…