Haiqing Bai b68d53c361 tipc: fix the big/little endian issue in tipc_dest ...

[ Upstream commit 30935198b7 ]

In function tipc_dest_push, the 32bit variables 'node' and 'port'
are stored separately in uppper and lower part of 64bit 'value'.
Then this value is assigned to dst->value which is a union like:
union
{
  struct {
    u32 port;
    u32 node;
  };
  u64 value;
}
This works on little-endian machines like x86 but fails on big-endian
machines.

The fix remove the 'value' stack parameter and even the 'value'
member of the union in tipc_dest, assign the 'node' and 'port' member
directly with the input parameter to avoid the endian issue.

Fixes: a80ae5306a ("tipc: improve destination linked list")
Signed-off-by: Zhenbo Gao <zhenbo.gao@windriver.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Haiqing Bai <Haiqing.Bai@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-09-15 09:46:42 +02:00

..

addr.c

tipc: handle collisions of 32-bit node address hash values

2018-03-23 13:12:18 -04:00

addr.h

tipc: add 128-bit node identifier

2018-03-23 13:12:18 -04:00

bcast.c

…

bcast.h

…

bearer.c

tipc: confgiure and apply UDP bearer MTU on running links

2018-04-20 11:04:05 -04:00

bearer.h

tipc: implement configuration of UDP media MTU

2018-04-20 11:04:05 -04:00

core.c

net: Drop pernet_operations::async

2018-03-27 13:18:09 -04:00

core.h

tipc: replace name table service range array with rb tree

2018-03-31 22:19:52 -04:00

diag.c

tipc: use the right skb in tipc_sk_fill_sock_diag()

2018-04-08 12:34:29 -04:00

discover.c

tipc: fix correct setting of message type in second discoverer

2018-07-07 19:49:01 +09:00

discover.h

tipc: some cleanups in the file discover.c

2018-03-23 13:12:17 -04:00

eth_media.c

…

group.c

…

group.h

…

ib_media.c

…

Kconfig

tipc: implement socket diagnostics for AF_TIPC

2018-03-22 14:43:35 -04:00

link.c

tipc: avoid possible string overflow

2018-03-31 22:19:52 -04:00

link.h

tipc: handle collisions of 32-bit node address hash values

2018-03-23 13:12:18 -04:00

Makefile

tipc: implement socket diagnostics for AF_TIPC

2018-03-22 14:43:35 -04:00

monitor.c

tipc: fix infinite loop when dumping link monitor summary

2018-04-18 13:48:43 -04:00

monitor.h

…

msg.c

tipc: obsolete TIPC_ZONE_SCOPE

2018-03-17 17:11:46 -04:00

msg.h

tipc: handle collisions of 32-bit node address hash values

2018-03-23 13:12:18 -04:00

name_distr.c

tipc: permit overlapping service ranges in name table

2018-03-31 22:19:52 -04:00

name_distr.h

tipc: permit overlapping service ranges in name table

2018-03-31 22:19:52 -04:00

name_table.c

tipc: fix the big/little endian issue in tipc_dest

2018-09-15 09:46:42 +02:00

name_table.h

tipc: fix the big/little endian issue in tipc_dest

2018-09-15 09:46:42 +02:00

net.c

tipc: fix an interrupt unsafe locking scenario

2018-08-07 13:15:35 -07:00

net.h

tipc: obtain node identity from interface by default

2018-03-23 13:12:18 -04:00

netlink_compat.c

treewide: kmalloc() -> kmalloc_array()

2018-06-12 16:19:22 -07:00

netlink.c

tipc: fix possible crash in __tipc_nl_net_set()

2018-04-16 18:08:18 -04:00

netlink.h

…

node.c

tipc: fix wrong return value from function tipc_node_try_addr()

2018-07-07 19:49:01 +09:00

node.h

tipc: introduce ioctl for fetching node identity

2018-04-27 11:05:41 -04:00

socket.c

tipc: fix a missing rhashtable_walk_exit()

2018-09-15 09:46:42 +02:00

socket.h

tipc: use the right skb in tipc_sk_fill_sock_diag()

2018-04-08 12:34:29 -04:00

subscr.c

tipc: fix unbalanced reference counter

2018-04-12 21:46:10 -04:00

subscr.h

tipc: replace name table service range array with rb tree

2018-03-31 22:19:52 -04:00

sysctl.c

…

topsrv.c

…

topsrv.h

…

udp_media.c

tipc: set default MTU for UDP media

2018-04-20 11:04:05 -04:00

udp_media.h

tipc: implement configuration of UDP media MTU

2018-04-20 11:04:05 -04:00