Christoph Jaeger 46d2cfb192 packet: bail out of packet_snd() if L2 header creation fails ...

Due to a misplaced parenthesis, the expression

  (unlikely(offset) < 0),

which expands to

  (__builtin_expect(!!(offset), 0) < 0),

never evaluates to true. Therefore, when sending packets with
PF_PACKET/SOCK_DGRAM, packet_snd() does not abort as intended
if the creation of the layer 2 header fails.

Spotted by Coverity - CID 1259975 ("Operands don't affect result").

Fixes: 9c7077622d ("packet: make packet_snd fail on len smaller than l2 header")
Signed-off-by: Christoph Jaeger <cj@linux.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Acked-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2015-01-11 21:54:03 -05:00

..

af_packet.c

packet: bail out of packet_snd() if L2 header creation fails

2015-01-11 21:54:03 -05:00

diag.c

net: Use netlink_ns_capable to verify the permisions of netlink messages

2014-04-24 13:44:54 -04:00

internal.h

packet: handle too big packets for PACKET_V3

2014-08-21 16:44:28 -07:00

Kconfig

…

Makefile

…