Cong Wang 4514a597aa netfilter: ipt_CLUSTERIP: fix a race condition of proc file creation ...

commit b3e456fce9 upstream.

There is a race condition between clusterip_config_entry_put()
and clusterip_config_init(), after we release the spinlock in
clusterip_config_entry_put(), a new proc file with a same IP could
be created immediately since it is already removed from the configs
list, therefore it triggers this warning:

------------[ cut here ]------------
proc_dir_entry 'ipt_CLUSTERIP/172.20.0.170' already registered
WARNING: CPU: 1 PID: 4152 at fs/proc/generic.c:330 proc_register+0x2a4/0x370 fs/proc/generic.c:329
Kernel panic - not syncing: panic_on_warn set ...

As a quick fix, just move the proc_remove() inside the spinlock.

Reported-by: <syzbot+03218bcdba6aa76441a3@syzkaller.appspotmail.com>
Fixes: 6c5d5cfbe3 ("netfilter: ipt_CLUSTERIP: check duplicate config when initializing")
Tested-by: Paolo Abeni <pabeni@redhat.com>
Cc: Xin Long <lucien.xin@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-03-15 10:54:23 +01:00

..

netfilter

netfilter: ipt_CLUSTERIP: fix a race condition of proc file creation

2018-03-15 10:54:23 +01:00

af_inet.c

net: accept UFO datagrams from tuntap and packet

2017-12-17 15:07:58 +01:00

ah4.c

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next

2017-06-23 14:17:31 -04:00

arp.c

ipv4: Make neigh lookup keys for loopback/point-to-point devices be INADDR_ANY

2018-01-31 14:03:44 +01:00

cipso_ipv4.c

tcp/dccp: fix ireq->opt races

2017-10-21 01:33:19 +01:00

datagram.c

…

devinet.c

ipv4: igmp: guard against silly MTU values

2018-01-02 20:31:06 +01:00

esp4_offload.c

esp: Fix GRO when the headers not fully in the linear part of the skb.

2018-02-25 11:07:46 +01:00

esp4.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2017-09-01 17:42:05 -07:00

fib_frontend.c

ipv4: Fix use-after-free when flushing FIB tables

2018-01-02 20:31:09 +01:00

fib_lookup.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

fib_notifier.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

fib_rules.c

net: fib_rules: Implement notification logic in core

2017-08-03 15:35:59 -07:00

fib_semantics.c

fib_semantics: Don't match route with mismatching tclassid

2018-03-08 22:41:07 -08:00

fib_trie.c

ipv4: do metrics match when looking up and deleting a route

2017-08-23 20:37:10 -07:00

fou.c

gue: fix remcsum when GRO on and CHECKSUM_PARTIAL boundary is outer UDP

2017-08-01 16:09:14 -07:00

gre_demux.c

…

gre_offload.c

gso: fix payload length when gso_size is zero

2017-10-08 10:12:15 -07:00

icmp.c

icmp: don't fail on fragment reassembly time exceeded

2017-12-20 10:10:37 +01:00

igmp.c

net: igmp: add a missing rcu locking section

2018-02-13 10:19:47 +01:00

inet_connection_sock.c

Revert "defer call to mem_cgroup_sk_alloc()"

2018-02-13 10:19:48 +01:00

inet_diag.c

inet_diag: allow protocols to provide additional data

2017-09-01 18:38:09 -07:00

inet_fragment.c

Revert "net: use lib/percpu_counter API for fragmentation mem accounting"

2017-09-03 11:01:05 -07:00

inet_hashtables.c

soreuseport: fix initialization race

2017-10-22 02:03:51 +01:00

inet_timewait_sock.c

kmemcheck: remove annotations

2018-02-22 15:42:23 +01:00

inetpeer.c

inetpeer: fix RCU lookup() again

2017-09-28 09:39:34 -07:00

ip_forward.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

ip_fragment.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

ip_gre.c

ip_gre: remove the incorrect mtu limit for ipgre tap

2018-03-03 10:24:27 +01:00

ip_input.c

IPv4: early demux can return an error code

2017-10-01 03:55:47 +01:00

ip_options.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

ip_output.c

udp: remove unreachable ufo branches

2017-08-22 14:27:18 -07:00

ip_sockglue.c

netfilter: drop outermost socket lock in getsockopt()

2018-02-28 10:19:38 +01:00

ip_tunnel_core.c

net: store port/representator id in metadata_dst

2017-06-25 11:42:01 -04:00

ip_tunnel.c

ipv4: igmp: guard against silly MTU values

2018-01-02 20:31:06 +01:00

ip_vti.c

vti: fix use after free in vti_tunnel_xmit/vti6_tnl_xmit

2017-09-26 09:58:21 -07:00

ipcomp.c

…

ipconfig.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

ipip.c

ipip: only increase err_count for some certain type icmp in ipip_err

2017-10-27 23:43:31 +09:00

ipmr.c

rtnetlink: make rtnl_register accept a flags parameter

2017-08-09 16:57:38 -07:00

Kconfig

ip: update policy routing config help

2017-10-12 22:57:11 -07:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

netfilter.c

…

ping.c

net: convert sock.sk_refcnt from atomic_t to refcount_t

2017-07-01 07:39:08 -07:00

proc.c

tcp: Revert "tcp: remove header prediction"

2017-08-30 11:20:09 -07:00

protocol.c

net: Add sysctl to toggle early demux for tcp and udp

2017-03-24 13:17:07 -07:00

raw_diag.c

net: ipv6: add second dif to raw socket lookups

2017-08-07 11:39:22 -07:00

raw.c

net: ipv4: fix for a race condition in raw_sendmsg

2018-01-02 20:31:08 +01:00

route.c

net: ipv4: Set addr_type in hash_keys for forwarded case

2018-03-08 22:41:15 -08:00

syncookies.c

tcp/dccp: fix ireq->opt races

2017-10-21 01:33:19 +01:00

sysctl_net_ipv4.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

tcp_bbr.c

tcp_bbr: fix pacing_gain to always be unity when using lt_bw

2018-02-13 10:19:48 +01:00

tcp_bic.c

tcp: consolidate congestion control undo functions

2017-08-06 21:25:10 -07:00

tcp_cdg.c

tcp: consolidate congestion control undo functions

2017-08-06 21:25:10 -07:00

tcp_cong.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2017-09-01 17:42:05 -07:00

tcp_cubic.c

tcp: consolidate congestion control undo functions

2017-08-06 21:25:10 -07:00

tcp_dctcp.c

…

tcp_diag.c

tcp_diag: report TCP MD5 signing keys and addresses

2017-09-01 18:38:09 -07:00

tcp_fastopen.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

tcp_highspeed.c

tcp: consolidate congestion control undo functions

2017-08-06 21:25:10 -07:00

tcp_htcp.c

tcp: fix cwnd undo in Reno and HTCP congestion controls

2017-08-06 21:25:10 -07:00

tcp_hybla.c

…

tcp_illinois.c

tcp: consolidate congestion control undo functions

2017-08-06 21:25:10 -07:00

tcp_input.c

tcp: purge write queue upon RST

2018-03-08 22:41:17 -08:00

tcp_ipv4.c

tcp md5sig: Use skb's saddr when replying to an incoming segment

2018-01-02 20:31:07 +01:00

tcp_lp.c

tcp: switch TCP TS option (RFC 7323) to 1ms clock

2017-05-17 16:06:01 -04:00

tcp_metrics.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

tcp_minisocks.c

tcp/dccp: block bh before arming time_wait timer

2017-12-17 15:07:57 +01:00

tcp_nv.c

tcp_nv: fix division by zero in tcpnv_acked()

2017-11-02 16:16:27 +09:00

tcp_offload.c

gso: validate gso_type in GSO handlers

2018-01-31 14:03:47 +01:00

tcp_output.c

tcp_bbr: better deal with suboptimal GSO

2018-03-08 22:41:13 -08:00

tcp_probe.c

tcp: remove redundant argument from tcp_rcv_established()

2017-07-24 17:28:12 -07:00

tcp_rate.c

tcp: invalidate rate samples during SACK reneging

2018-01-02 20:31:09 +01:00

tcp_recovery.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

tcp_scalable.c

tcp: consolidate congestion control undo functions

2017-08-06 21:25:10 -07:00

tcp_timer.c

net: tcp: close sock if net namespace is exiting

2018-01-31 14:03:45 +01:00

tcp_ulp.c

tcp: ulp: avoid module refcnt leak in tcp_set_ulp

2017-08-14 22:17:05 -07:00

tcp_vegas.c

tcp: fix under-evaluated ssthresh in TCP Vegas

2017-12-25 14:26:30 +01:00

tcp_vegas.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

tcp_veno.c

tcp: consolidate congestion control undo functions

2017-08-06 21:25:10 -07:00

tcp_westwood.c

tcp: Revert "tcp: remove CA_ACK_SLOWPATH"

2017-08-30 11:20:08 -07:00

tcp_yeah.c

tcp: consolidate congestion control undo functions

2017-08-06 21:25:10 -07:00

tcp.c

tcp: release sk_frag.page in tcp_disconnect

2018-02-13 10:19:47 +01:00

tunnel4.c

…

udp_diag.c

net: ipv6: add second dif to udp socket lookups

2017-08-07 11:39:22 -07:00

udp_impl.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

udp_offload.c

gso: validate gso_type in GSO handlers

2018-01-31 14:03:47 +01:00

udp_tunnel.c

net: add infrastructure to un-offload UDP tunnel port

2017-07-24 13:52:59 -07:00

udp.c

udplite: fix partial checksum initialization

2018-03-08 22:41:10 -08:00

udplite.c

…

xfrm4_input.c

xfrm: Reinject transport-mode packets through tasklet

2018-03-03 10:24:25 +01:00

xfrm4_mode_beet.c

networking: make skb_pull & friends return void pointers

2017-06-16 11:48:39 -04:00

xfrm4_mode_transport.c

xfrm: Add encapsulation header offsets while SKB is not encrypted

2017-04-14 10:07:39 +02:00

xfrm4_mode_tunnel.c

xfrm: Add encapsulation header offsets while SKB is not encrypted

2017-04-14 10:07:39 +02:00

xfrm4_output.c

xfrm: Add an IPsec hardware offloading API

2017-04-14 10:06:10 +02:00

xfrm4_policy.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

xfrm4_protocol.c

…

xfrm4_state.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

xfrm4_tunnel.c

…