averello/linux-stable-mirror
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2026-09-22 09:34:56 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
v4.14.41
linux-stable-mirror/net/ipv4
T
History
Eric Dumazet 8c12bd91b5 tcp: fix TCP_REPAIR_QUEUE bound checking 
commit bf2acc943a upstream.

syzbot is able to produce a nasty WARN_ON() in tcp_verify_left_out()
with following C-repro :

socket(PF_INET, SOCK_STREAM, IPPROTO_IP) = 3
setsockopt(3, SOL_TCP, TCP_REPAIR, [1], 4) = 0
setsockopt(3, SOL_TCP, TCP_REPAIR_QUEUE, [-1], 4) = 0
bind(3, {sa_family=AF_INET, sin_port=htons(20002), sin_addr=inet_addr("0.0.0.0")}, 16) = 0
sendto(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"...,
	1242, MSG_FASTOPEN, {sa_family=AF_INET, sin_port=htons(20002), sin_addr=inet_addr("127.0.0.1")}, 16) = 1242
setsockopt(3, SOL_TCP, TCP_REPAIR_WINDOW, "\4\0\0@+\205\0\0\377\377\0\0\377\377\377\177\0\0\0\0", 20) = 0
writev(3, [{"\270", 1}], 1)             = 1
setsockopt(3, SOL_TCP, TCP_REPAIR_OPTIONS, "\10\0\0\0\0\0\0\0\0\0\0\0|\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 386) = 0
writev(3, [{"\210v\r[\226\320t\231qwQ\204\264l\254\t\1\20\245\214p\350H\223\254;\\\37\345\307p$"..., 3144}], 1) = 3144

The 3rd system call looks odd :
setsockopt(3, SOL_TCP, TCP_REPAIR_QUEUE, [-1], 4) = 0

This patch makes sure bound checking is using an unsigned compare.

Fixes: ee9952831c ("tcp: Initial repair mode")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-05-16 10:10:24 +02:00
..
netfilter
netfilter: compat: prepare xt_compat_init_offsets to return errors
2018-04-26 11:02:21 +02:00
af_inet.c
net: accept UFO datagrams from tuntap and packet
2017-12-17 15:07:58 +01:00
ah4.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2017-06-23 14:17:31 -04:00
arp.c
arp: fix arp_filter on l3slave devices
2018-04-12 12:32:22 +02:00
cipso_ipv4.c
tcp/dccp: fix ireq->opt races
2017-10-21 01:33:19 +01:00
datagram.c
…
devinet.c
ipv4: igmp: guard against silly MTU values
2018-01-02 20:31:06 +01:00
esp4_offload.c
esp: Fix GRO when the headers not fully in the linear part of the skb.
2018-02-25 11:07:46 +01:00
esp4.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2017-09-01 17:42:05 -07:00
fib_frontend.c
ipv4: Fix use-after-free when flushing FIB tables
2018-01-02 20:31:09 +01:00
fib_lookup.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fib_notifier.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fib_rules.c
net: fib_rules: Implement notification logic in core
2017-08-03 15:35:59 -07:00
fib_semantics.c
route: check sysctl_fib_multipath_use_neigh earlier than hash
2018-04-12 12:32:27 +02:00
fib_trie.c
ipv4: do metrics match when looking up and deleting a route
2017-08-23 20:37:10 -07:00
fou.c
gue: fix remcsum when GRO on and CHECKSUM_PARTIAL boundary is outer UDP
2017-08-01 16:09:14 -07:00
gre_demux.c
…
gre_offload.c
gso: fix payload length when gso_size is zero
2017-10-08 10:12:15 -07:00
icmp.c
icmp: don't fail on fragment reassembly time exceeded
2017-12-20 10:10:37 +01:00
igmp.c
net: igmp: add a missing rcu locking section
2018-02-13 10:19:47 +01:00
inet_connection_sock.c
Revert "defer call to mem_cgroup_sk_alloc()"
2018-02-13 10:19:48 +01:00
inet_diag.c
inet_diag: allow protocols to provide additional data
2017-09-01 18:38:09 -07:00
inet_fragment.c
net: Fix hlist corruptions in inet_evict_bucket()
2018-03-31 18:10:40 +02:00
inet_hashtables.c
soreuseport: fix initialization race
2017-10-22 02:03:51 +01:00
inet_timewait_sock.c
soreuseport: initialise timewait reuseport field
2018-05-16 10:10:24 +02:00
inetpeer.c
inetpeer: fix uninit-value in inet_getpeer
2018-05-16 10:10:24 +02:00
ip_forward.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ip_fragment.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ip_gre.c
ip_gre: fix potential memory leak in erspan_rcv
2018-03-24 11:01:27 +01:00
ip_input.c
IPv4: early demux can return an error code
2017-10-01 03:55:47 +01:00
ip_options.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ip_output.c
udp: remove unreachable ufo branches
2017-08-22 14:27:18 -07:00
ip_sockglue.c
net: Only honor ifindex in IP_PKTINFO if non-0
2018-03-31 18:10:41 +02:00
ip_tunnel_core.c
net: store port/representator id in metadata_dst
2017-06-25 11:42:01 -04:00
ip_tunnel.c
net: don't call update_pmtu unconditionally
2018-05-09 09:51:48 +02:00
ip_vti.c
net: don't call update_pmtu unconditionally
2018-05-09 09:51:48 +02:00
ipcomp.c
…
ipconfig.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ipip.c
ipip: only increase err_count for some certain type icmp in ipip_err
2017-10-27 23:43:31 +09:00
ipmr.c
rtnetlink: make rtnl_register accept a flags parameter
2017-08-09 16:57:38 -07:00
Kconfig
ip: update policy routing config help
2017-10-12 22:57:11 -07:00
Makefile
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
netfilter.c
…
ping.c
net: convert sock.sk_refcnt from atomic_t to refcount_t
2017-07-01 07:39:08 -07:00
proc.c
tcp: Revert "tcp: remove header prediction"
2017-08-30 11:20:09 -07:00
protocol.c
…
raw_diag.c
net: ipv6: add second dif to raw socket lookups
2017-08-07 11:39:22 -07:00
raw.c
net: ipv4: fix for a race condition in raw_sendmsg
2018-01-02 20:31:08 +01:00
route.c
ipv4: fix uninit-value in ip_route_output_key_hash_rcu()
2018-05-16 10:10:24 +02:00
syncookies.c
tcp/dccp: fix ireq->opt races
2017-10-21 01:33:19 +01:00
sysctl_net_ipv4.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
tcp_bbr.c
tcp_bbr: fix pacing_gain to always be unity when using lt_bw
2018-02-13 10:19:48 +01:00
tcp_bic.c
tcp: consolidate congestion control undo functions
2017-08-06 21:25:10 -07:00
tcp_cdg.c
tcp: consolidate congestion control undo functions
2017-08-06 21:25:10 -07:00
tcp_cong.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2017-09-01 17:42:05 -07:00
tcp_cubic.c
tcp: consolidate congestion control undo functions
2017-08-06 21:25:10 -07:00
tcp_dctcp.c
…
tcp_diag.c
tcp_diag: report TCP MD5 signing keys and addresses
2017-09-01 18:38:09 -07:00
tcp_fastopen.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
tcp_highspeed.c
tcp: consolidate congestion control undo functions
2017-08-06 21:25:10 -07:00
tcp_htcp.c
tcp: fix cwnd undo in Reno and HTCP congestion controls
2017-08-06 21:25:10 -07:00
tcp_hybla.c
…
tcp_illinois.c
tcp: consolidate congestion control undo functions
2017-08-06 21:25:10 -07:00
tcp_input.c
tcp: don't read out-of-bounds opsize
2018-04-29 11:33:11 +02:00
tcp_ipv4.c
tcp md5sig: Use skb's saddr when replying to an incoming segment
2018-01-02 20:31:07 +01:00
tcp_lp.c
…
tcp_metrics.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
tcp_minisocks.c
tcp/dccp: block bh before arming time_wait timer
2017-12-17 15:07:57 +01:00
tcp_nv.c
tcp_nv: fix potential integer overflow in tcpnv_acked
2018-04-26 11:02:13 +02:00
tcp_offload.c
gso: validate gso_type in GSO handlers
2018-01-31 14:03:47 +01:00
tcp_output.c
tcp_bbr: better deal with suboptimal GSO
2018-03-08 22:41:13 -08:00
tcp_probe.c
tcp: remove redundant argument from tcp_rcv_established()
2017-07-24 17:28:12 -07:00
tcp_rate.c
tcp: invalidate rate samples during SACK reneging
2018-01-02 20:31:09 +01:00
tcp_recovery.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
tcp_scalable.c
tcp: consolidate congestion control undo functions
2017-08-06 21:25:10 -07:00
tcp_timer.c
tcp: purge write queue upon aborting the connection
2018-03-31 18:10:38 +02:00
tcp_ulp.c
tcp: ulp: avoid module refcnt leak in tcp_set_ulp
2017-08-14 22:17:05 -07:00
tcp_vegas.c
tcp: fix under-evaluated ssthresh in TCP Vegas
2017-12-25 14:26:30 +01:00
tcp_vegas.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
tcp_veno.c
tcp: consolidate congestion control undo functions
2017-08-06 21:25:10 -07:00
tcp_westwood.c
tcp: Revert "tcp: remove CA_ACK_SLOWPATH"
2017-08-30 11:20:08 -07:00
tcp_yeah.c
tcp: consolidate congestion control undo functions
2017-08-06 21:25:10 -07:00
tcp.c
tcp: fix TCP_REPAIR_QUEUE bound checking
2018-05-16 10:10:24 +02:00
tunnel4.c
…
udp_diag.c
net: ipv6: add second dif to udp socket lookups
2017-08-07 11:39:22 -07:00
udp_impl.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
udp_offload.c
gso: validate gso_type in GSO handlers
2018-01-31 14:03:47 +01:00
udp_tunnel.c
net: add infrastructure to un-offload UDP tunnel port
2017-07-24 13:52:59 -07:00
udp.c
udplite: fix partial checksum initialization
2018-03-08 22:41:10 -08:00
udplite.c
…
xfrm4_input.c
xfrm: Reinject transport-mode packets through tasklet
2018-03-03 10:24:25 +01:00
xfrm4_mode_beet.c
…
xfrm4_mode_transport.c
…
xfrm4_mode_tunnel.c
…
xfrm4_output.c
…
xfrm4_policy.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xfrm4_protocol.c
…
xfrm4_state.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xfrm4_tunnel.c
…