Yoshihiro Shimoda 8d425fae2c dmaengine: sh: rcar-dmac: avoid to write CHCR.TE to 1 if TCR is set to 0 ...

[ Upstream commit 538603c602 ]

This patch fixes an issue that unexpected retransfering happens
if TCR is set to 0 before rcar_dmac_sync_tcr() writes DE bit to
the CHCR register. For example, sh-sci driver can reproduce this
issue like below:

 In rx_timer_fn():		/* CHCR DE bit may be set to 1 */
  dmaengine_tx_status()
   rcar_dmac_tx_status()
    rcar_dmac_chan_get_residue()
     rcar_dmac_sync_tcr()	/* TCR is possible to be set to 0 */

According to the description of commit 73a47bd0da ("dmaengine:
rcar-dmac: use TCRB instead of TCR for residue"), "this buffered data
will be transferred if CHCR::DE bit was cleared". So, this patch
doesn't need to check TCRB register.

Fixes: 73a47bd0da ("dmaengine: rcar-dmac: use TCRB instead of TCR for residue")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-09-26 08:39:42 +02:00

..

bestcomm

treewide: kmalloc() -> kmalloc_array()

2018-06-12 16:19:22 -07:00

dw

dmaengine: dw: simplify getting .drvdata

2018-04-22 11:50:56 +05:30

dw-axi-dmac

dmaengine: dw-axi-dmac: fix spelling mistake: "catched" -> "caught"

2018-03-27 17:44:39 +05:30

hsu

…

ioat

treewide: kzalloc() -> kcalloc()

2018-06-12 16:19:22 -07:00

ipu

treewide: Use array_size() in vmalloc()

2018-06-12 16:19:22 -07:00

mediatek

dmaengine: mediatek: Add MediaTek High-Speed DMA controller for MT7622 and MT7623 SoC

2018-03-27 15:18:15 +05:30

ppc4xx

Merge branch 'topic/ppc4xx' into for-linus

2017-09-06 21:54:41 +05:30

qcom

Merge tag 'dmaengine-4.18-rc1' of git://git.infradead.org/users/vkoul/slave-dma

2018-06-08 11:02:21 -07:00

sh

dmaengine: sh: rcar-dmac: avoid to write CHCR.TE to 1 if TCR is set to 0

2018-09-26 08:39:42 +02:00

ti

dmaengine: ti: omap-dma: Fix OMAP1510 incorrect residue_granularity

2018-06-19 09:59:13 +05:30

xilinx

treewide: kzalloc() -> kcalloc()

2018-06-12 16:19:22 -07:00

acpi-dma.c

…

altera-msgdma.c

dmaengine: altera: Use IRQ-safe spinlock calls in the error paths as well

2017-10-20 11:51:10 +05:30

amba-pl08x.c

dmaengine: amba-pl08x: Use vchan_terminate_vdesc() instead of desc_free

2017-12-04 22:33:51 +05:30

at_hdmac_regs.h

dmaengine: at_hdmac: Remove unnecessary 0x prefixes before %pad

2017-11-08 10:47:04 +05:30

at_hdmac.c

dmaengine: at_hdmac: simplify getting .drvdata

2018-04-22 21:34:58 +05:30

at_xdmac.c

dmaengine: at_xdmac: simplify getting .drvdata

2018-04-22 21:36:10 +05:30

bcm2835-dma.c

dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free

2017-12-04 22:33:51 +05:30

bcm-sba-raid.c

treewide: Use struct_size() for devm_kmalloc() and friends

2018-06-06 11:15:43 -07:00

coh901318_lli.c

…

coh901318.c

dmaengine: coh901318: Remove unnecessary 0x prefixes before %pad

2017-11-08 10:46:46 +05:30

coh901318.h

…

dma-axi-dmac.c

dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-05-02 10:06:42 +05:30

dma-jz4740.c

dmaengine: jz4740: disable/unprepare clk if probe fails

2017-12-11 09:00:06 +05:30

dma-jz4780.c

dmaengine: dma-jz4780: Use vchan_terminate_vdesc() instead of desc_free

2017-12-04 22:33:51 +05:30

dmaengine.c

fix a series of Documentation/ broken file name references

2018-06-15 18:10:01 -03:00

dmaengine.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

dmatest.c

dmaengine: dmatest: Remove use of VLAs

2018-04-16 21:05:54 +05:30

ep93xx_dma.c

…

fsl_raid.c

…

fsl_raid.h

…

fsl-edma.c

dmaengine: fsl-edma: disable clks on all error paths

2017-12-15 09:53:04 +05:30

fsldma.c

dmaengine: fsldma: simplify getting .drvdata

2018-04-22 21:37:17 +05:30

fsldma.h

…

idma64.c

dmaengine: idma64: simplify getting .drvdata

2018-04-22 21:37:37 +05:30

idma64.h

…

img-mdc-dma.c

dmaengine: img-mdc-dma: Use vchan_terminate_vdesc() instead of desc_free

2017-12-04 22:33:51 +05:30

imx-dma.c

dmaengine: imx-dma: Switch to SPDX identifier

2018-05-23 11:10:32 +05:30

imx-sdma.c

dmaengine: imx-sdma: Switch to SPDX identifier

2018-05-23 11:10:31 +05:30

iop-adma.c

…

k3dma.c

dmaengine: k3dma: Off by one in k3_of_dma_simple_xlate()

2018-06-28 11:57:21 +05:30

Kconfig

dmaengine: ti: New directory for Texas Instruments DMA drivers

2018-04-25 14:56:21 +05:30

lpc18xx-dmamux.c

…

Makefile

dmaengine: ti: New directory for Texas Instruments DMA drivers

2018-04-25 14:56:21 +05:30

mic_x100_dma.c

treewide: Use array_size() in vzalloc()

2018-06-12 16:19:22 -07:00

mic_x100_dma.h

…

mmp_pdma.c

…

mmp_tdma.c

…

moxart-dma.c

treewide: Use struct_size() for kmalloc()-family

2018-06-06 11:15:43 -07:00

mpc512x_dma.c

…

mv_xor_v2.c

dmaengine: mv_xor_v2: kill the tasklets upon exit

2018-09-26 08:39:29 +02:00

mv_xor.c

treewide: kzalloc() -> kcalloc()

2018-06-12 16:19:22 -07:00

mv_xor.h

…

mxs-dma.c

dmaengine: mxs-dma: Switch to SPDX identifier

2018-05-23 11:10:31 +05:30

nbpfaxi.c

treewide: Use struct_size() for devm_kmalloc() and friends

2018-06-06 11:15:43 -07:00

of-dma.c

dmaengine: Convert to using %pOF instead of full_name

2017-07-19 09:30:44 +05:30

pch_dma.c

dmaengine: pch_dma: Replace PCI pool old API

2017-10-31 17:01:06 +05:30

pl330.c

dmaengine: pl330: fix irq race with terminate_all

2018-09-26 08:39:23 +02:00

pxa_dma.c

…

s3c24xx-dma.c

treewide: devm_kzalloc() -> devm_kcalloc()

2018-06-12 16:19:22 -07:00

sa11x0-dma.c

treewide: Use struct_size() for kmalloc()-family

2018-06-06 11:15:43 -07:00

sirf-dma.c

…

sprd-dma.c

Merge tag 'dmaengine-4.18-rc1' of git://git.infradead.org/users/vkoul/slave-dma

2018-06-08 11:02:21 -07:00

st_fdma.c

…

st_fdma.h

…

ste_dma40_ll.c

…

ste_dma40_ll.h

…

ste_dma40.c

dmaengine: ste_dma40: simplify getting .drvdata

2018-04-22 21:37:52 +05:30

stm32-dma.c

dmaengine: stm32-dma: properly mask irq bits

2018-04-04 11:49:36 +05:30

stm32-dmamux.c

dmaengine: stm32-dmamux: fix a potential buffer overflow

2018-03-22 10:51:35 +05:30

stm32-mdma.c

dmaengine: stm32-mdma: fix spelling mistake: "avalaible" -> "available"

2018-05-02 09:57:37 +05:30

sun4i-dma.c

…

sun6i-dma.c

dmaengine: sun6i: Retrieve channel count/max request from devicetree

2017-10-23 11:44:03 +05:30

tegra20-apb-dma.c

dmaengine: tegra-apb: Support non-flow controlled slave configuration

2017-11-29 19:35:05 +05:30

tegra210-adma.c

dmaengine: tegra210-adma: fix of_irq_get() error check

2017-08-09 11:39:16 +05:30

timb_dma.c

dmaengine: timb_dma: fix spelling mistake: "Couldnt" -> "Couldn't"

2017-12-11 08:57:38 +05:30

TODO

…

txx9dmac.c

dmaengine: txx9dmac: simplify getting .drvdata

2018-04-22 21:38:06 +05:30

txx9dmac.h

…

virt-dma.c

dmaengine: virt-dma: Add helper to free/reuse a descriptor

2017-12-04 22:33:51 +05:30

virt-dma.h

dmaengine: virt-dma: Support for race free transfer termination

2017-12-04 22:33:51 +05:30

xgene-dma.c

dmaengine: xgene-dma: remove unused xgene_dma_invalidate_buffer

2017-08-22 22:13:44 +05:30

zx_dma.c

treewide: devm_kzalloc() -> devm_kcalloc()

2018-06-12 16:19:22 -07:00