John Pittman
aee3d110a1
dm kcopyd: avoid softlockup in run_complete_job
[ Upstream commit 784c9a29e9 ]
It was reported that softlockups occur when using dm-snapshot ontop of
slow (rbd) storage. E.g.:
[ 4047.990647] watchdog: BUG: soft lockup - CPU#10 stuck for 22s! [kworker/10:23:26177]
...
[ 4048.034151] Workqueue: kcopyd do_work [dm_mod]
[ 4048.034156] RIP: 0010:copy_callback+0x41/0x160 [dm_snapshot]
...
[ 4048.034190] Call Trace:
[ 4048.034196] ? __chunk_is_tracked+0x70/0x70 [dm_snapshot]
[ 4048.034200] run_complete_job+0x5f/0xb0 [dm_mod]
[ 4048.034205] process_jobs+0x91/0x220 [dm_mod]
[ 4048.034210] ? kcopyd_put_pages+0x40/0x40 [dm_mod]
[ 4048.034214] do_work+0x46/0xa0 [dm_mod]
[ 4048.034219] process_one_work+0x171/0x370
[ 4048.034221] worker_thread+0x1fc/0x3f0
[ 4048.034224] kthread+0xf8/0x130
[ 4048.034226] ? max_active_store+0x80/0x80
[ 4048.034227] ? kthread_bind+0x10/0x10
[ 4048.034231] ret_from_fork+0x35/0x40
[ 4048.034233] Kernel panic - not syncing: softlockup: hung tasks
Fix this by calling cond_resched() after run_complete_job()'s callout to
the dm_kcopyd_notify_fn (which is dm-snap.c:copy_callback in the above
trace).
Signed-off-by: John Pittman <jpittman@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-09-15 09:46:53 +02:00
..
2018-09-09 10:32:41 +02:00
2018-04-03 15:04:23 -04:00
2018-06-08 11:53:14 -04:00
2018-06-08 11:53:14 -04:00
2018-04-30 11:51:39 -04:00
2018-04-30 15:40:40 -04:00
2018-09-09 10:32:33 +02:00
2018-06-12 16:19:22 -07:00
2018-06-08 11:53:14 -04:00
2018-06-08 11:53:14 -04:00
2018-09-09 10:32:33 +02:00
2018-01-17 09:16:15 -05:00
2018-04-03 15:04:10 -04:00
2018-04-04 12:12:39 -04:00
2018-09-09 10:32:33 +02:00
2018-06-05 08:47:43 -06:00
2018-06-08 09:50:15 -04:00
2018-09-15 09:46:53 +02:00
2018-05-22 23:18:31 -07:00
2018-05-30 15:33:32 -06:00
2018-05-22 23:18:31 -07:00
2018-05-14 08:55:12 -06:00
2018-01-29 13:44:58 -05:00
2018-05-04 10:35:20 -04:00
2018-06-22 14:51:12 -04:00
2018-06-12 18:28:00 -07:00
2018-05-30 15:33:32 -06:00
2018-01-29 13:44:58 -05:00
2018-04-03 15:04:23 -04:00
2018-06-12 16:19:22 -07:00
2018-06-12 16:19:22 -07:00
2018-05-22 23:18:31 -07:00
2018-06-12 16:19:22 -07:00
2018-06-28 16:06:14 -04:00
2018-04-03 15:04:15 -04:00
2018-06-22 14:51:11 -04:00
2018-09-09 10:32:33 +02:00
2018-04-03 15:04:15 -04:00
2018-06-05 10:48:05 -07:00
2018-05-30 15:33:32 -06:00
2018-06-12 16:19:22 -07:00
2018-04-03 15:04:29 -04:00
2018-09-09 10:32:34 +02:00
2018-01-17 09:16:15 -05:00
2018-06-22 14:51:12 -04:00
2018-06-28 16:06:14 -04:00
2018-01-17 09:16:06 -05:00
2018-06-08 11:59:51 -04:00
2018-06-08 11:59:51 -04:00
2018-06-12 16:19:22 -07:00
2018-06-12 16:19:22 -07:00
2018-05-30 15:33:32 -06:00
2018-05-30 15:33:32 -06:00
2018-06-12 16:19:22 -07:00
2018-05-30 15:33:32 -06:00
2018-06-18 09:46:13 -07:00
2018-06-09 12:01:36 -07:00
2018-06-12 16:19:22 -07:00
2018-06-12 16:19:22 -07:00
2018-05-30 15:33:32 -06:00
2018-05-30 15:33:32 -06:00
2018-02-21 09:40:40 -08:00
2018-05-30 15:33:32 -06:00
2018-06-12 16:19:22 -07:00
2018-06-09 12:01:36 -07:00
2018-06-28 13:04:49 -07:00
2018-05-30 15:33:32 -06:00