Danila Chernetsov 8990dbb706 ext2: fix ignored return value of generic_write_sync() ...

[ Upstream commit a4659be0bc ]

Fix ext2_dio_write_iter() to propagate the error returned by
generic_write_sync() instead of silently discarding it, which could
cause write(2) to return success to userspace on O_SYNC/O_DSYNC files
even when the sync failed.

The correct pattern, already used in ext2_dax_write_iter() in the same
file and in ext4, xfs, f2fs among others, is:
    if (ret > 0)
        ret = generic_write_sync(iocb, ret);

Found by Linux Verification Center (linuxtesting.org) with SVACE.

[JK: Reflect also filemap_write_and_wait() return value]

Fixes: fb5de4358e ("ext2: Move direct-io to use iomap")
Signed-off-by: Danila Chernetsov <listdansp@mail.ru>
Link: https://patch.msgid.link/20260530122311.136803-1-listdansp@mail.ru
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2026-07-24 16:03:06 +02:00

..

acl.c

…

acl.h

…

balloc.c

…

dir.c

…

ext2.h

…

file.c

ext2: fix ignored return value of generic_write_sync()

2026-07-24 16:03:06 +02:00

ialloc.c

…

inode.c

ext2: reject inodes with zero i_nlink and valid mode in ext2_iget()

2026-05-17 17:13:28 +02:00

ioctl.c

…

Kconfig

…

Makefile

…

namei.c

…

super.c

…

symlink.c

…

trace.c

…

trace.h

…

xattr_security.c

…

xattr_trusted.c

…

xattr_user.c

…

xattr.c

…

xattr.h

…