mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-03-04 18:39:28 +01:00
76489955c6
The comapt_xxx_class symbols aren't declared in anything that
lib/comapt_audit.c is including (arm64 build) which is causing
the following sparse warnings:
lib/compat_audit.c:7:10: warning: symbol 'compat_dir_class'
was not declared. Should it be static?
lib/compat_audit.c:12:10: warning: symbol 'compat_read_class'
was not declared. Should it be static?
lib/compat_audit.c:17:10: warning: symbol 'compat_write_class'
was not declared. Should it be static?
lib/compat_audit.c:22:10: warning: symbol 'compat_chattr_class'
was not declared. Should it be static?
lib/compat_audit.c:27:10: warning: symbol 'compat_signal_class'
was not declared. Should it be static?
Trying to fix this by chaning compat_audit.c to inclde <linux/audit.h>
does not work on arm64 due to compile errors with the extra includes
that changing this header makes. The simpler thing would be just to
move the definitons of these symbols out of <linux/audit.h> into
<linux/audit_arch.h> which is included.
Fixes: 4b58841149 ("audit: Add generic compat syscall support")
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
[PM: rewrite subject line, fixed line length in description]
Signed-off-by: Paul Moore <paul@paul-moore.com>
34 lines
784 B
C
34 lines
784 B
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/* audit_arch.h -- Arch layer specific support for audit
|
|
*
|
|
* Copyright 2021 Red Hat Inc., Durham, North Carolina.
|
|
* All Rights Reserved.
|
|
*
|
|
* Author: Richard Guy Briggs <rgb@redhat.com>
|
|
*/
|
|
#ifndef _LINUX_AUDIT_ARCH_H_
|
|
#define _LINUX_AUDIT_ARCH_H_
|
|
|
|
enum auditsc_class_t {
|
|
AUDITSC_NATIVE = 0,
|
|
AUDITSC_COMPAT,
|
|
AUDITSC_OPEN,
|
|
AUDITSC_OPENAT,
|
|
AUDITSC_SOCKETCALL,
|
|
AUDITSC_EXECVE,
|
|
AUDITSC_OPENAT2,
|
|
|
|
AUDITSC_NVALS /* count */
|
|
};
|
|
|
|
extern int audit_classify_compat_syscall(int abi, unsigned syscall);
|
|
|
|
/* only for compat system calls */
|
|
extern unsigned compat_write_class[];
|
|
extern unsigned compat_read_class[];
|
|
extern unsigned compat_dir_class[];
|
|
extern unsigned compat_chattr_class[];
|
|
extern unsigned compat_signal_class[];
|
|
|
|
#endif
|