averello/macvim-mirror
1
0
Fork 0
mirror of https://github.com/macvim-dev/macvim.git synced 2026-06-07 15:37:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix switching to fullscreen loses keyboard focus if titlebar is hidden

Browse Source 
For some reason, when the titlebar is hidden, if we use `set fullscreen`
in native full screen mode, the focus will be lost and the user needs to
manually click on the screen to be able to type in MacVim. Current
theory is that because fullscreen window always has a title bar,
sometime that resulted in the window being defocused when the OS is
fixing it up.

For an easy fix, simply assert the focus by using `makeFirstResponder`
on the text view. This may not work well if the program is more
complicated but for MacVim the text view should always be where the
focus goes.

Fix #1078
This commit is contained in:
Yee Cheng Chin
2020-09-14 01:33:32 -07:00
parent 8b25779788
commit 560fae4e09
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/MacVim/MMWindowController.m
+20
View File
@@ -1419,6 +1419,11 @@
// full-screen using :fullscreen option (including Ctrl-Cmd-f).
[vimController sendMessage:BackingPropertiesChangedMsgID data:nil];
}
// Sometimes full screen will de-focus the text view. This seems to happen
// when titlebar is configured as hidden. Simply re-assert it to make sure
// text is still focused.
[decoratedWindow makeFirstResponder:[vimView textView]];
}
- (void)windowDidFailToEnterFullScreen:(NSWindow *)window
@@ -1436,6 +1441,11 @@
[[vimView tabBarControl] setStyleNamed:tabBarStyle];
[self updateTablineSeparator];
[window setFrame:preFullScreenFrame display:YES];
// Sometimes full screen will de-focus the text view. This seems to happen
// when titlebar is configured as hidden. Simply re-assert it to make sure
// text is still focused.
[decoratedWindow makeFirstResponder:[vimView textView]];
}
- (NSArray *)customWindowsToExitFullScreenForWindow:(NSWindow *)window
@@ -1500,6 +1510,11 @@
}
[self updateTablineSeparator];
// Sometimes full screen will de-focus the text view. This seems to happen
// when titlebar is configured as hidden. Simply re-assert it to make sure
// text is still focused.
[decoratedWindow makeFirstResponder:[vimView textView]];
}
- (void)windowDidFailToExitFullScreen:(NSWindow *)window
@@ -1515,6 +1530,11 @@
[[vimView tabBarControl] setStyleNamed:tabBarStyle];
[self updateTablineSeparator];
[self maximizeWindow:fullScreenOptions];
// Sometimes full screen will de-focus the text view. This seems to happen
// when titlebar is configured as hidden. Simply re-assert it to make sure
// text is still focused.
[decoratedWindow makeFirstResponder:[vimView textView]];
}
#endif // (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_7)