9c92cc1617
chore: Suppress last known impure static properties
...
We will keep these legacy ones for now. We can search for the
ImpureStaticProperty suppression and add special treatement for them in
the frankenphp PR if needed.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-02 09:46:20 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
d8e8703796
chore: add missing Override attribute to app code
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:28 +02:00
e4244c5fc8
fix(encryption): Improve type strictness on decryption check
...
Otherwise decrypting a falsy value like '0' would be seen as a
decryption failure.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-02-23 14:49:03 +01:00
ae73f7aaf5
refactor(setup-manager): Use ISetupManager instead of SetupManager
...
Keep using the OC API in the mount manager and OC_Utils, but the rest is
now using the public API.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-01-27 15:19:19 +01:00
26e2ff9dca
fix: removed the -n option from options, added the check and made default answer to both questions true to support -n run directly
...
Signed-off-by: yemkareems <yemkareems@gmail.com >
2025-11-19 15:52:47 +05:30
d420b3f157
fix: added the interactive condition to the password question and in non-interactive mode sent the password directly
...
Signed-off-by: yemkareems <yemkareems@gmail.com >
2025-11-14 16:05:14 +05:30
a3442be054
refactor: fix psalm issues from encryption commands
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-10-01 16:07:41 +02:00
8330f149b0
chore(encryption): Remove unused attribute $uid in KeyManager::getFileKey
...
It’s a private API in the application, no need to keep an unused
attribute.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:28 +02:00
bc5e29f9f2
fix(tests): Fix type issues and other problems with encryption tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:18 +02:00
94254db001
chore(encryption): Cleanup typing in EncryptAll/DecryptAll
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:18 +02:00
b74c7538ac
fix(encryption): Do not depend upon user in session unless really necessary
...
Should fix a bunch of stuff when encryption listener is triggered by events from occ commands or background jobs
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:17 +02:00
f95fef9938
chore(encryption): Adapt tests to code changes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-08-04 11:53:19 +02:00
d711d68701
fix(encryption): Ignore shared files in encrypt-all command
...
Copying and renaming a share will not encrypt it anyway. It will get
encrypted when the owner’s files get encrypted.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-08-04 10:42:04 +02:00
4427050f84
fix(encryption): Correctly handle file opening and copying failures
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-07-03 15:19:34 +02:00
1285ebc3cf
fix(encryption): Catch exceptions in encrypt-all command and continue
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-07-03 15:19:34 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-21 12:37:59 +02:00
f3aa004b1c
refactor(encryption): Migrate away from Hooks to typed events
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de >
Co-authored-by: Louis <louis@chmn.me >
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com >
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-10-15 18:33:06 +02:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-10-15 10:40:25 +02:00
51d9d63a01
chore: Use more gender neutral language
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-14 13:59:24 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
95cd524771
fix: Autodetect legacy filekey instead of trusting the header for legacy header
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-06-04 17:20:20 +02:00
5b7dcc1427
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-29 08:58:16 +02:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
3e176f58af
Improve typing as suggested by review
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-08-08 09:14:16 +02:00
1e06b61f59
Migrate away from ILogger in encryption
...
And modernize code a bit
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-08-08 09:14:16 +02:00
bd08849866
Fix sharing of encrypted files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-07-18 09:42:57 +02:00
9646474e9a
fix(i18n) Changed grammar related to "login"
...
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com >
2023-07-15 15:51:53 +02:00
2a6f347430
Increase from 100000 to 600000 iterations for hash_pbkdf2
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-05-23 20:53:33 +00:00
c9c49bfef8
Log failures to delete legacy file key
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-05-04 17:50:51 +02:00
b952066140
Merge pull request #37724 from nextcloud/fix/encryption-signature-check-logic
...
Cleanup signature checking logic in encryption
2023-04-17 17:39:34 +02:00
0b88b513be
Merge pull request #36351 from nextcloud/bugfix/noid/move-encryption-password-email-to-template
...
Move encrypt-all password email to EmailTemplate
2023-04-14 14:48:47 +02:00
2f653c8be8
Cleanup signature checking logic in encryption
...
Signed-off-by: jld3103 <jld3103yt@gmail.com >
2023-04-14 09:07:20 +02:00
430009b8e2
Add a test for multiKeyEncrypt/Decrypt methods
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-03-20 14:19:13 +01:00
24e762c59f
Fix encryption file key management
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-03-17 11:08:59 +01:00
8900d030d1
Adapt code to new encryption system
...
fileKey gets deleted upon save as it’s stored in shareKeys instead now.
We use presence of a fileKey to detect if a file is using the legacy
system or the new one, because we do not always have access to header
data.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-03-17 11:08:58 +01:00
fbe282caeb
Getting rid of openssl_seal and rc4 in server side encryption
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-03-17 11:08:50 +01:00
0f7146c652
Move encrypt-all password email to EmailTemplate
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2023-03-08 12:15:18 +01:00
f2912ce8bc
Set functions as private to be able to refactor later
...
Also a few comment fixes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-02-21 13:36:25 +00:00
71482576ad
Move to phpseclib implementation of RC4
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-02-21 13:36:25 +00:00
bd626e3693
Strong type custom openssl_seal implementation
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-02-21 13:36:25 +00:00
deed6393fb
Always wrap rc4, and throws on unknown cipher
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-02-21 13:36:25 +00:00
81638436e5
introduce wrapped_openssl_seal() and wrapped_openssl_open() to circument RC4 problems with OpenSSL v3
...
Signed-off-by: Kevin Niehage <k.niehage@syseleven.de >
2023-02-21 13:36:25 +00:00
7ebbb6b2ca
Remove workarounds specific to 7.4
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-01-20 11:22:08 +01:00
9430899f16
Fix psalm issues related to signature changes from PHP 8.0
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-12-29 12:36:34 +01:00
71e490090f
Replace getSystemValue in encryption app
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com >
2022-12-05 14:30:58 +01:00
1258caeab7
Save encrypted files in binary format
...
Default to the more space-efficient binary encoding for newly encrypted files
instead of the traditional base64 encoding, eliminating the 33% overhead.
The new option 'encryption.use_legacy_encoding' allows to force the legacy
encoding format if needed. Files encoded in the old format remain readable.
Based on https://github.com/owncloud/encryption/pull/224 and
https://github.com/owncloud/core/pull/38249 by karakayasemi.
Signed-off-by: plumbeo <plumbeo@users.noreply.github.com >
2022-05-04 17:38:25 +02:00
aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-01-12 20:03:06 +01:00
Côme Chilliet
Ferdinand Thiessen
Carl Schwan
yemkareems
Carl Schwan
provokateurin
Daniel Kesselberg
Andy Scherzinger
Joas Schilling
rakekniven
Christoph Wurst
Joas Schilling
jld3103
Kevin Niehage
J0WI
plumbeo
Carl Schwan