Commit Graph

88 Commits

Author SHA1 Message Date
Côme Chilliet 1ab09ec753 chore: Apply new coding standard to all files
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-01 13:46:39 +02:00
Côme Chilliet 7439b3db64 fix(files_external): Migrate call to now-deprecated static methods
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-05-18 14:11:38 +02:00
Ferdinand Thiessen d8e8703796 chore: add missing Override attribute to app code
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-04-28 21:29:28 +02:00
Daniel Kesselberg 67d1fac6f6 fix: show configuration options for external storage backends
The occ files_external_backends command is supposed to list available backends along with their configuration options.

For the SMB backend, only the timeout option is currently shown, while options like host, share, root, and domain are missing. This makes configuring external storage via occ complicated.

Since the timeout option is marked as hidden but still shown, while the other options are not, the logic needs to be inverted so that all relevant configuration options are displayed correctly.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2026-02-25 15:24:20 +01:00
provokateurin f12cecb684 feat(rector): Enable SafeDeclareStrictTypesRector
Signed-off-by: provokateurin <kate@provokateurin.de>
2026-02-09 10:59:31 +01:00
Carl Schwan 4d47fdaa85 chore: Run rector with new rules for fetch
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-11-18 17:45:57 +01:00
Carl Schwan 7e1c49ad9d refactor: Port away from IQueryBuilder::execute in apps/
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-09-16 11:35:01 +02:00
provokateurin 5bd626bd40 chore: Fix all method calls with too many arguments
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-22 12:34:49 +02:00
Ferdinand Thiessen 5981b7eb51 chore: apply new CSFixer rules
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
Robin Appelman 6113278d4c feat: add --unscanned option to files_external:scan
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-06-02 16:48:40 +02:00
Robin Appelman f97495bf5a feat: add command to check files_external dependencies
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-13 09:46:19 +02:00
Kate c1a9dfd993 Merge pull request #52441 from nextcloud/scan-locked-error 2025-05-06 15:23:16 +02:00
provokateurin 01d2a9f76a fix(files_external): Convert VALUE_HIDDEN to FLAG_HIDDEN to allow combining VALUE_PASSWORD and FLAG_HIDDEN
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-05 13:19:43 +02:00
Robin Appelman bb4cf2830a fix: better error message when trying to scan a folder that is already being scanned
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-04-25 18:40:03 +02:00
Ferdinand Thiessen c82337f3b9 fix: incorrect types detected by updated stubs
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 19:07:39 +01:00
Benjamin Gaussorgues 12452f7f22 fix(files_external): wrong type for external mount id
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-12-13 10:27:50 +01:00
Côme Chilliet 1580c8612b chore(apps): Apply new rector configuration to autouse classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:40:25 +02:00
Joas Schilling 4219969c96 fix: Ensure we only pass string to writeln()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:38 +02:00
Joas Schilling c109ae9437 ci: Fix psalm by typing the QuestionHelper
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:27 +02:00
Joas Schilling 96f77d7b99 fix(filesexternal): Remove unneeded 3rdparty library use
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-02 23:27:44 +02:00
Côme Chilliet 1a4978c4ea chore: Apply rector configuration to apps folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-20 17:51:00 +02:00
provokateurin 9836e9b164 chore(deps): Update nextcloud/coding-standard to v1.3.1
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +02:00
Daniel Kesselberg af6de04e9e style: update codestyle for coding-standard 1.2.3
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +02:00
Andy Scherzinger c1555fc33e chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-06 18:05:37 +02:00
Robin Appelman 42e14cc4c7 feat: add command to scan external storages directly
the main use case of this over simply scanning through is the ability to provide a username and/or password for cases where login credentials are used

Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-06 19:11:08 +01:00
Maxence Lange 1a5b545fe8 full uppercase const
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-24 11:33:44 +01:00
John Molakvoæ 524ed97d62 fix: replace Account name by Login
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +01:00
Vincent Petry 839ddaa354 feat: rename users to account or person
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +01:00
Josh 2e00184eb4 fix(files_external) Add sensitive S3 values redacted by list command
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-02-07 10:05:46 -05:00
Joas Schilling aa5f037af7 chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Faraz Samapoor eab7818f0e Adds parameter type hints.
Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-09-28 09:02:10 +03:30
Faraz Samapoor 32838d8f0a Refactors files_external app commands.
To improve code readability.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-09-28 09:02:10 +03:30
Faraz Samapoor cfb921b26c Refactors "strpos" calls in /apps/files_external to improve code readability.
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-02 19:54:49 +03:30
Robin Appelman 570b64aafc handle not being able to write file for notify self-test
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-06 11:52:22 +02:00
Côme Chilliet 0c466b7ff5 Attempt at reducing psalm errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:09 +01:00
Carl Schwan 732badf552 Additional type hinting found by psalm
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-18 12:28:34 +02:00
Carl Schwan 2d75321c23 Add more typing to FilesExternal commands
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 10:58:25 +02:00
Carl Schwan c4bb69c143 Specify that userId can be null
This fixes a psalm false-positive where the method is called with null, since
the method actually handle this correctly already

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-16 23:35:33 +02:00
Carl Schwan d4d1952f67 Fix return value of updateParent
Port to executeStatement to guarantee that we will return an int and
remove a deprecated method call at the same time

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-16 23:33:52 +02:00
Carl Schwan a40ca520d4 Port away from removed IDBConnection->isConnected method
Instead track if the reconnection was successful with return value of
connect method

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-16 23:32:55 +02:00
Robin Appelman 94f0c10ec6 fix some types
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-16 13:56:26 +02:00
John Molakvoæ (skjnldsv) 215aef3cbd Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Robin Appelman 98c3eb6cad add dry-run option to files_external:notify
and add some additional logging

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:28:04 +01:00
dependabot-preview[bot] eb502c02ff Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
blizzz 060286c51a Merge pull request #23021 from nextcloud/notify-saved-login-auth
allow using saved login credentials for notify
2020-10-13 19:39:31 +02:00
Robin Appelman ea80d1d68f also give storage backend it's change to manipulate the config
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-07 15:43:44 +02:00
Robin Appelman 6fed17a342 allow using saved login credentials for notify
when only the user is provided, we use to provided user to try and get saved login credentials

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-23 15:49:27 +02:00
Robin Appelman a79f9605b4 add option to disable notify self check
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-23 15:16:16 +02:00
Christoph Wurst 2a054e6c04 Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Daniel Kesselberg 6f8147b18f Fix some MissingDocblockType or InvalidDocblock warnings.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-14 15:10:48 +02:00