6220ae9175
fix(sharing): restore STATUS_ACCEPTED for OC-migrated group share subshares
...
When an ownCloud-migrated group share (which has no per-user USERGROUP
subshare) is renamed for the first time, DefaultShareProvider::move()
inserted a new USERGROUP row without setting `accepted`. The column
defaulted to 0 (STATUS_PENDING), causing MountProvider to skip the
share on the next login — the shared file disappeared for the recipient.
Fix: set accepted = STATUS_ACCEPTED explicitly on the INSERT in
DefaultShareProvider::move() for the TYPE_GROUP branch.
Secondary fix: SharedMount::moveMount() silently returned true when
updateFileTarget() threw (e.g. group no longer exists on an OC-migrated
instance). Set $result = false in the catch block so View::rename()
propagates the failure instead of silently corrupting VFS state.
An opt-in occ command (sharing:fix-owncloud-group-shares) with --dry-run
support is included to repair existing broken instances. It targets only
TYPE_USERGROUP subshares with accepted=STATUS_PENDING and permissions!=0
(shares that were accepted but broken by the missing column default),
leaving explicitly declined shares (permissions=0) untouched.
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com >
Signed-off-by: Anna Larch <anna@nextcloud.com >
2026-05-26 17:28:39 +02:00
d8e8703796
chore: add missing Override attribute to app code
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:28 +02:00
fbf84e6473
chore: Replace MoveableMount usage with IMovableMount
...
The former is private API while the IMovableMount is public.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-04-24 10:14:37 +02:00
3979c493f9
refactor: Apply second batch of comments
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:52:51 +01:00
d71c6796ca
feat: perform share mount validation on share instead of on mount
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-01-21 16:35:53 +01:00
4d47fdaa85
chore: Run rector with new rules for fetch
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-11-18 17:45:57 +01:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
bcbf0e76a7
fix: more optimized caching for share target verification
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-04-08 16:42:01 +02:00
64863c9d46
chore: Apply new rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-02-13 11:46:42 +01:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-21 12:37:59 +02:00
c254855222
chore(db): Correctly apply query types
...
fix: psalm
fix: error
fix: add batch
fix: fatal error
fix: add batch
chore: add batch
chore: add batch
fix: psalm
fix: typo
fix: psalm
fix: return bool
fix: revert Manager
2024-10-17 09:21:07 +02:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-10-15 10:40:25 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
1e04619675
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-06-06 22:53:41 +02:00
c0ce272e9c
chore: Migrate away from OC::$server->getLogger
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-02-13 17:32:30 +01:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
dec880b285
optimize builtin storage wrappers
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-11-08 15:26:10 +01:00
b8c61b3515
fix(caching): Avoid checking existence before fetching
...
The cache might expire between checking for key existence and fetching
the value. In this rare case the code continues with a null value when
it doesn't expect one.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2023-06-12 09:44:48 +02:00
60cf0c8f5f
add command for getting fileinfo for debugging
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-04-17 16:23:52 +02:00
c105b6a85d
still include the share target in the cache key for validating share mount
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-01-16 13:09:50 +01:00
927174e325
fix cache key used to verify shared mountpoints
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-01-09 13:48:44 +01:00
d5c23dbb9f
Move CappedMemoryCache to OCP
...
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-07-14 15:54:31 +02:00
ec6b83cc18
Add stricter psalm type for CappedMemoryCache
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-05-12 15:06:18 +02:00
bda8601648
cache the verification of the share mountpoint
...
after the initial verification this can only really be invalidated by a system mount (external/group/etc) being created at the share target since any normal file/folder creation will already conflict with the share
Signed-off-by: Robin Appelman <robin@icewind.nl >
2022-04-21 18:08:35 +02:00
db2418be85
invalidate mount cache after share rename
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2022-03-24 17:36:56 +01:00
cfb7923e08
store mountprovider for each mount in the mounts table
...
this enabled more fine grained filesystem setup
Signed-off-by: Robin Appelman <robin@icewind.nl >
2022-02-23 18:02:33 +01:00
961f8958c0
Let users choose a share_folder
2021-09-06 16:39:11 +02:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com >
2021-06-04 22:02:41 +02:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-12-16 18:48:22 +01:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-08-24 14:54:25 +02:00
6f8147b18f
Fix some MissingDocblockType or InvalidDocblock warnings.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2020-08-14 15:10:48 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 14:19:56 +02:00
841f2f3b04
Allow to overwrite share target mountpoints
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2020-02-17 09:04:19 +01:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2019-12-05 15:38:45 +01:00
67f3d6f0a6
cache parent exists status during share setup
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2018-08-16 21:28:01 +02:00
b5217b6f63
don't check if target dir exists when using the default share target directory
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2018-08-16 21:27:51 +02:00
b79f338e71
re-use view instances for shared storages
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2018-08-16 21:27:48 +02:00
bc4f10ad83
more efficient way to detect added and removed mounts
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2018-08-16 21:27:45 +02:00
3155c1bd9a
more efficient unique share target generation
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2018-08-16 19:54:42 +02:00
dd34cb7540
Less deprecated calls to OCP\Util::writeLog
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-04-22 20:41:49 +02:00
a661f043e1
Remove unneeded semicolon and parentheses
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-01-26 23:46:40 +01:00
0eebff152a
Update license headers
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2017-11-06 16:56:19 +01:00
ab9a36e872
allow apps to set custom mount types
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2017-04-28 09:38:21 +02:00
cc511ac7b8
Typecast filecache 'storage' as int to return it as documented, fixes #3461
...
Signed-off-by: Frédéric Fortier <frederic.fortier@oronospolytechnique.com >
2017-02-20 22:23:27 -05:00
9e353f6289
Fix overwriting parameter
...
Fixes #2641
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2016-12-13 22:28:09 +01:00
bbe24d29ca
reuse cacheentry
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2016-12-13 12:30:29 +01:00
246bb9f33d
Move OC\Files\Storage\Shared to the right namespace
2016-10-20 20:27:44 +02:00
423378ea17
Added closeCursor in SharedMount numeric id
2016-08-30 19:49:31 +02:00
669b0bc2ae
Prevent error with orphaned shares when updating user mount cache
2016-08-30 19:49:23 +02:00
95570d607c
reuse existing root id
2016-08-22 12:27:20 +02:00
Anna Larch
Ferdinand Thiessen
Carl Schwan
Carl Schwan
Robin Appelman
Côme Chilliet
provokateurin
Git'Fellow
Andy Scherzinger
Joas Schilling
Christoph Wurst
Carl Schwan
Hinrich Mahler
John Molakvoæ (skjnldsv)
Daniel Kesselberg
Morris Jobke
Frédéric Fortier
Roeland Jago Douma
Joas Schilling
Vincent Petry