93a4f887ea
perf: avoid DIing IRootFolder at every shared storage init
...
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com >
2026-06-23 11:10:27 +02:00
b7c97ea269
fix: stop calling DI container in SharedStorage
...
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com >
2026-06-22 23:33:46 +02:00
9c92cc1617
chore: Suppress last known impure static properties
...
We will keep these legacy ones for now. We can search for the
ImpureStaticProperty suppression and add special treatement for them in
the frankenphp PR if needed.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-02 09:46:20 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
d8e8703796
chore: add missing Override attribute to app code
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:28 +02:00
5eec4fd69c
refactor: Apply rector changes
...
Signed-off-by: GitHub <noreply@github.com >
2026-03-15 14:53:03 +00:00
7fa44717e0
refactor(share): Remove some deprecated method usages
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-03-10 11:39:57 +01:00
af94028bdb
refactor: Remove old Share backend
...
This has been implicitely deprecated for a while with Share20 containing
the new implementation.
The only use was to determine whether remote sharing was enabled or not,
which we can do much more easily.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-03-10 10:09:40 +01:00
4eada2d804
refactor(Files): Modernize Wrapper
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-17 06:43:16 +01:00
b6313f68d3
perf(s3): Expose pre-signed urls for S3
...
This is faster than going back to nextcloud to download the files.
This is an opt-in setting that can be enabled by setting
use_presigned_url in the object store config.
Additionally add support for the proxy config which is needed in a
docker setup. See https://github.com/juliusknorr/nextcloud-docker-dev/pull/431
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-12-09 11:21:35 +01:00
af907388d0
fix: make share recursion error more informative
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-10-03 15:50:43 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
fb3e60862f
fix: disable direct download for shares
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-04-11 17:42:21 +02:00
228ac86fa2
Merge pull request #50769 from nextcloud/checkStorageIdSetCache
...
fix(SharedStorage): Check if storage ID is set on cache
2025-02-14 14:17:00 +01:00
64863c9d46
chore: Apply new rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-02-13 11:46:42 +01:00
bc3be77a69
fix(SharedStorage): Check if storage ID is set on cache
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
2025-02-13 08:29:20 +01:00
2786ca579a
fix: don't use cached root info from shared cache if the watcher has detected an update
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-02-06 19:41:43 +01:00
bc53a8ab87
perf: improve performance of SharedStorage::getWatcher
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-11-29 18:10:30 +01:00
0de4843b73
refactor(Storage): Align all Storage constructors
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-23 13:24:18 +02:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-21 12:37:59 +02:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-10-15 10:40:25 +02:00
1642a34e8a
refactor(files_sharing): Add Storage parameter strong types
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-07 15:00:07 +02:00
376d5665bb
fix(files_sharing): Fix all IStorage return types
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-26 17:29:47 +02:00
d2d1e3284d
fix(Storage): Fix method docs inheritance
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-17 10:20:38 +02:00
8ca6fcace7
fix(Storage): Document getOwner() can return false
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-17 10:10:50 +02:00
22822d5e9b
fix: Fix other uses of removed Storage interface
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-09-16 18:11:36 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
4bbcbc5206
feat: Make ISharedStorage public API and reuse where possible
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-08-12 11:42:10 +02:00
7343da4a9c
fix: try to find non-recursive share source
...
instead of always picking the first one, try to find one that won't blow up
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-07-30 15:32:07 +02:00
23cdb539ce
fix: fix recursive share check
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-07-30 07:41:26 +02:00
1e04619675
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-06-06 22:53:41 +02:00
85b5dd0a43
fix: add extra check to ensure wrapped shared storage is set
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-03-20 14:48:55 +01:00
f46209a34e
chore: improve typing for SharedStorage::$storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-03-14 11:22:17 +01:00
0ace9a4efa
fix: don't return null for SharedStorage::getWrapperStorage with share recursion
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-03-14 11:21:05 +01:00
ea8a774a0a
fix: add some recrusive detection/prevention
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-03-08 14:20:14 +01:00
e7a7b4a401
perf: switch places that always use the first getById result to getFirstNodeById
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-03-04 13:57:31 +01:00
0eba9570eb
Merge branch 'master' into share-external-watcher
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com >
2024-02-23 21:51:44 +01:00
e50c176428
also improe cache ci for shared cache
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-02-09 14:00:26 +01:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
d6eb127f76
improve logic for getting the watcher for a shared external storage
...
with the new-ish lazy mount loading the underlying mount might not be loaded yet, so ask the mount cache instead
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-09-11 15:00:32 +02:00
df71b4d734
pass the share to the cache instead of having to ask the storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-08-18 13:38:08 +02:00
29c1848eda
Migrate files sharing to PSR LoggerInterface
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-07-06 14:08:42 +02:00
dcf6ebebab
Fix inherited parameter names
...
Signed-off-by: jld3103 <jld3103yt@gmail.com >
2023-04-03 08:29:33 +02:00
3bcb4fc024
Put back the variable but make sure it is properly declared
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-12-05 11:51:16 +01:00
26033653a8
Remove dymanic var $mountOptions to fix PHP 8.2 compatibility
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-11-24 11:52:07 +01:00
a5ea677370
Rename file1 and file2 to source and target in Storage abstraction
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-10-18 17:21:47 +02:00
9d26671f05
Fix typos in apps/ subdirectory
...
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`
Signed-off-by: luz paz <luzpaz@github.com >
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com >
2022-09-05 12:59:54 +00:00
4333c215cb
Cache display name
...
This should saves some query in the share backend when displaying the
owner and it's not important if the display name is 10 minutes outdated
as it is very rare that this gets changed.
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-04-22 10:22:15 +02:00
e3ade5507d
also apply the fix for the other storage types
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2022-04-21 15:00:42 +02:00
f6d5eb9a75
improve optimization for SharedStorage::instanceOfStorage(Common)
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2022-04-21 14:51:09 +02:00
Salvatore Martire
Côme Chilliet
Ferdinand Thiessen
nextcloud-command
Carl Schwan
provokateurin
Carl Schwan
Robin Appelman
Christoph Wurst
Git'Fellow
Daniel Kesselberg
Andy Scherzinger
John Molakvoæ
Joas Schilling
Benjamin Gaussorgues
jld3103
Carl Schwan
luz paz