734904e7f0
feat(oauth2): Add commands for adding and deleting clients
...
Refactor the code for doing that from the controller to a seperate
service.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-15 13:06:09 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
4b1c3fbe3b
fix(settings,oauth2): preserve wipe state across admin deletion paths
...
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com >
2026-05-26 16:41:02 +02:00
59b3d7a5b2
fix(oauth): rotate the auth token only if the access token rotation was successful
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2026-04-22 11:23:47 +02:00
c639dfdbfc
fix(oauth): make the throttling reason more specific
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2026-04-22 11:23:47 +02:00
72c4d0f72a
fix(oauth): wrap token rotation in a transaction, only rotate if the token hasn't been modified since we have read it
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2026-04-22 11:23:47 +02:00
5c1b58c380
fix(oauth2): Do not store the code in throttle metadata
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-03-19 14:40:12 +01:00
11cf69d8ba
fix(psalm): Fix static analysis issues in apps/*/tests
...
There are still 1200 more to fix before we can enable static analysis
for the tests.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-01-16 12:00:51 +01:00
d6d6747a73
refactor: apply rector rules for PHPUnit 10
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-10-27 21:56:04 +01:00
49d522717c
refactor(dbal): Port away from remaining IQueryBuilder::execute calls
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-10-13 13:44:15 +02:00
aa15f9d16d
chore: run rector
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-07-01 22:45:52 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
246da73a36
fix(oauth2): retain support for legacy ownCloud clients
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud >
2025-04-01 11:25:52 +02:00
64863c9d46
chore: Apply new rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-02-13 11:46:42 +01:00
75f8bb51ed
fix: Rename config option to skipAuthPickerApplications to match what it does
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-01-07 10:34:30 +01:00
cca0e84480
feat(oauth2): Add a test for skipping auth page
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-01-07 10:34:30 +01:00
99e0867f0a
chore: Adapt tests to added constructor parameters
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-01-07 10:34:30 +01:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-10-15 10:40:25 +02:00
1a4978c4ea
chore: Apply rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-09-20 17:51:00 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
49dd79eabb
refactor: Add void return type to PHPUnit test methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2024-09-15 22:32:31 +02:00
120e7e838c
fix(oauth2): fix tests
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2024-09-02 14:38:39 +02:00
034917b790
fix(oauth2): store hashed secret instead of encrypted
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2024-09-02 14:38:39 +02:00
84ee79fe43
fix: expect invalidateTokensOfUser only be called for seen users
...
Signed-off-by: Artur Neumann <artur@jankaritech.com >
2024-08-16 10:33:56 +02:00
cc1686dba9
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-31 10:38:47 +02:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
32f984c520
adjust oauth tests
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2023-10-05 14:24:02 +02:00
c6da99474e
rename oauth2_access_token's created_at to code_created_at
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2023-10-05 14:24:02 +02:00
ddfc124767
add test for refusing to get an oauth token from a code when we're not in authorization state
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2023-10-05 14:24:02 +02:00
2995b0948f
add tests for oauth2 authorization code expiration
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2023-10-05 14:24:02 +02:00
807f173dec
make oauth2 authorization code expire after 10 minutes
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2023-10-05 14:24:02 +02:00
25309bcb45
techdebt(DI): Use public IThrottler interface which exists since Nextcloud 25
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2023-08-28 15:50:45 +02:00
629adc318f
add bruteforce protection in OauthApiController
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2023-06-19 11:18:06 +02:00
8086d7e41b
add test that inserts a long oauth client secret
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2023-06-14 17:21:38 +02:00
808819a4d0
fix oauth2 tests
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2023-06-08 13:02:40 +02:00
18c742a901
encrypt oauth2 client secrets
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2023-06-07 11:36:08 +02:00
e97540b9c6
move mocks into private variables
...
Signed-off-by: Artur Neumann <artur@jankaritech.com >
2023-03-14 17:18:56 +01:00
707e69b203
adjust SettingsController tests
...
Signed-off-by: Artur Neumann <artur@jankaritech.com >
2023-03-14 17:13:29 +01:00
21be557e2a
invalidate existing tokens when deleting an oauth client
...
Signed-off-by: Artur Neumann <artur@jankaritech.com >
2023-03-14 17:13:23 +01:00
9b26c4a277
Fix PHP error on PHP >= 8.2 about dynamic property use in tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-12-19 15:58:46 +01:00
539162ba8b
Remove at matchers from tests in:
...
* apps/oauth2
* tests/Test/Repair/Owncloud
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-08-02 15:27:52 +02:00
53db418ee9
Cleanup oauth2 admin settings
...
- Use more vue components
- Add link to doc
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-07-14 12:16:13 +02:00
617528312a
Fix last tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2021-12-02 10:39:49 +01:00
c6ae53096c
More test fixing
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2021-12-01 22:17:19 +01:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com >
2021-06-04 22:02:41 +02:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-12-16 18:48:22 +01:00
39131519b2
Make the test pass on repeating calls
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2020-11-10 15:34:35 +01:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-08-24 14:54:25 +02:00
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2020-08-12 13:55:19 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-31 14:52:54 +02:00
Carl Schwan
Côme Chilliet
Peter Ringelmann
Julien Veyssier
Ferdinand Thiessen
Carl Schwan
Robin Appelman
Richard Steinmetz
provokateurin
Christoph Wurst
Artur Neumann
Andy Scherzinger
Joas Schilling
Carl Schwan
John Molakvoæ (skjnldsv)
Morris Jobke