1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
b49ef46e72
perf: remove unneeded sort when listing mail shares
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-05-08 18:11:08 +02:00
d8e8703796
chore: add missing Override attribute to app code
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:28 +02:00
545a9c1c73
fix: update email button text to 'Open shared item'
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
2026-03-31 11:27:58 +02:00
c091ae4098
perf: Replace getById call with getFirstNodeById
...
Avoid looking at all the mounts
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-02-05 12:55:18 +01:00
c8989d853c
refactor(IShare): Add typing for node
...
This might also improve a bit the performance.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-01-27 11:19:33 +01:00
a011cb7780
refactor: Rename some variables in external share's manager
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-12-17 10:14:40 +01:00
4d47fdaa85
chore: Run rector with new rules for fetch
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-11-18 17:45:57 +01:00
83a691709c
refactor: use IEmailValidator.isValid instead of IMailer.validateEmailAddress
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2025-10-04 21:54:22 +02:00
665a38573c
fix(IShareProvider): Add missing getChildren method to the interface
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-07-29 10:26:33 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
ae16a28758
perf(Share20): Add interface to query all shares in a folder without filtering by user
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-05-08 15:29:40 +02:00
b464469bc1
perf(sharing): Use oc_share.{item_type, share_type} IN instead of OR equals
...
to improve performance by using the db index
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2025-03-25 09:42:06 +01:00
095ab4419e
fix(l10n): Improve english source strings
...
- No leading/trailing whitespace
- Use asci single quote
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-02-26 09:54:32 +01:00
72b6508d91
fix: Show recipient email addresses in share owner notification email
...
Previously, the share owner notification email did not display the recipient email addresses,
making it difficult for the owner to know who the share was sent to.
This fix ensures that the recipient email addresses are included in the notification email.
Signed-off-by: nfebe <fenn25.fn@gmail.com >
2025-01-29 12:42:43 +01:00
305e1bb260
fix: Ensure label is always a string
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-01-26 20:41:31 +01:00
20215fbd09
fix(shares): Remove noisy text from emails
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
2024-12-16 15:16:33 +01:00
f86fb0fee2
fix(share): Don't print twice the same information
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
2024-12-10 18:27:31 +01:00
db94e10af0
fix: Prevent breaking change in IQueryBuilder
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-10-17 18:31:44 +02:00
ee02e3246d
feat(AppFramework): Add full support for date / time / datetime columns
...
This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added.
But especially those types are the important ones, as our **Entity** class works by detecting changes through setters.
Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here.
Similar the parameter types needed to be added.
`Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity.
Also added more tests, especially to make sure the mapper really serializes the values correctly.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de >
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com >
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-10-17 18:31:42 +02:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-10-15 10:40:25 +02:00
0e282ea21a
fix(tests): Fix sharebymail tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-10-08 16:53:51 +02:00
59e4e4bfba
fix(sharebymail): Fix share update when node id changed
...
This fixes transfering an email share from a user to another one when using
objectstore as primary storage.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-10-07 15:36:53 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
457eaee2b3
fix(files_sharing): Add missing check for null & use bool instead of int for reminder_sent field
...
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me >
2024-09-03 17:23:31 +02:00
d633b9bce6
fix(files_sharing): Make share reminders more stable & fix issues
...
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me >
2024-09-03 13:37:17 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
dd58e5290f
feat: Use new password context in sharing API
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-08-22 19:16:55 +02:00
60eaef6696
feat(sharebymail): improve share email format
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com >
2024-08-06 09:42:19 +02:00
967b3848e0
fix(files_sharing): phpunit & openapi fixes
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com >
2024-07-12 20:14:30 +02:00
30f9ef414e
fix: psalm, cs, autoloader and lint
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com >
2024-07-12 20:14:30 +02:00
5ce4bb368f
chore(files_sharing): refactor share password mail
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com >
2024-07-12 20:14:30 +02:00
75ca4944c9
feat(files_sharing): allow mixed values in share attributes and allow storing email arrays
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com >
2024-07-12 20:14:30 +02:00
c253112cf7
chore(files_sharing): refactor mail handling
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com >
2024-07-12 20:14:30 +02:00
d388370c3b
feat(files_sharing): implement IShareProviderWithNotification and refactor sendMailNotification
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com >
2024-07-12 20:14:30 +02:00
443c48aefb
feat(files_sharing): add new file request option
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com >
2024-07-12 20:14:30 +02:00
afa48a4e0e
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-06-02 20:00:00 +02:00
ccd56672e8
refactor: remove non-shallow getSharesInFolder
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-05-01 16:46:06 +02:00
f45eb75e3d
ShareByMailProvider: getAccessList: set correct value for 'public'
...
PDOStatement::rowCount behavior is undefined for SELECT statements
for some database types, therefore manually set the value for 'public'
based on actual results fetched.
Signed-off-by: Adam Serbinski <adam@serbinski.com >
2024-03-21 18:25:31 -04:00
01e32340af
ShareByMailProvider: getAccessList: set both array keys 'public' and 'mail'
...
To preserve prior behaviour where 'public' was set 'true' if there
are any mail recipients. The 'mail' key will be an array of email
recipients.
Signed-off-by: Adam Serbinski <adam@serbinski.com >
2024-03-21 18:25:31 -04:00
34ca6bd46a
ShareByMailProvider: getAccessList: recommended style changes
...
Signed-off-by: Adam Serbinski <adam@serbinski.com >
2024-03-21 18:25:31 -04:00
9c528d412c
ShareByMailProvider: getAccessList: add token to returned array
...
This allows the share URI to be regenerated.
Signed-off-by: Adam Serbinski <adam@serbinski.com >
2024-03-21 18:25:31 -04:00
26ae5e6dfb
ShareByMailProvider: getAccessList: return full list of recipients
...
Previously was returning only boolean true if the Node was shared
by email, or false if not. Now provides an array containing the
list of email share recipients.
Signed-off-by: Adam Serbinski <adam@serbinski.com >
2024-03-21 18:25:31 -04:00
bfeb97c54a
fix: also filter by storage when getting shares in folder
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-03-06 15:33:05 +01:00
4a509dfe8e
fix: phpunit
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com >
2024-02-13 21:06:31 +01:00
839ddaa354
feat: rename users to account or person
...
Replace translated text in most locations
Signed-off-by: Vincent Petry <vincent@nextcloud.com >
2024-02-13 21:06:30 +01:00
303dadfaa9
sharebymail: remove ILogger and upgrade to PHP 8 syntax
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-08-30 18:36:29 +02:00
9ba9f9a7dc
Make sure to not pass null to DateTime::createFromFormat
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-11-14 16:23:50 +01:00
f525067930
Add argument to getSharesInFolder enable deep share lookup
...
Signed-off-by: Louis Chemineau <louis@chmn.me >
2022-07-26 12:17:46 +00:00
c1f054a9e0
Fix email shares not being shown to other users
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud >
2022-06-17 17:31:26 +02:00
Côme Chilliet
Robin Appelman
Ferdinand Thiessen
Git'Fellow
Carl Schwan
Carl Schwan
Daniel Kesselberg
provokateurin
Marcel Klehr
Joas Schilling
nfebe
Stefan Cherniakov
skjnldsv
Andy Scherzinger
Adam Serbinski
Vincent Petry
Benjamin Gaussorgues
Louis Chemineau
Richard Steinmetz