1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
279bface8e
refactor: Delete deprecated code from OC_Util
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-05-12 18:24:12 +02:00
428e76214e
chore: drop legacy WhatsNew
...
This feature was not used in 8 years and from frontend did not even
properly work anymore and was implemented using deprecated API.
So get rid of it.
The last version that was using a changelog from the changelog server
was Nextcloud 20.
We use the firstrunwizard nowadays for informing about Nextcloud
changes in new releases.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-01-21 23:23:10 +01:00
11cf69d8ba
fix(psalm): Fix static analysis issues in apps/*/tests
...
There are still 1200 more to fix before we can enable static analysis
for the tests.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-01-16 12:00:51 +01:00
7f3ef27cd5
refactor: adjust updater code to match code style
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com >
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
Signed-off-by: Louis Chmn <louis@chmn.me >
2025-10-21 12:20:34 +02:00
f600f26391
fix(updater): Stop expiring secret prematurely
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com >
2025-10-21 11:06:54 +02:00
aa15f9d16d
chore: run rector
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-07-01 22:45:52 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
ea0229dc86
test: Fix some apps/*/tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-05-15 08:26:15 +02:00
6e9b4eb0a8
refactor(updatenotification): add return types and fix typos
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-05-13 10:04:35 +02:00
ff318138a2
refactor(updatenotification): use OCP\ServerVersion
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-05-13 10:00:34 +02:00
957efe0670
fix(updatenotification): respect updatechecker config
...
If disabled:
- Hide admin settings
- Do not create Nextcloud server update notifications
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-05-12 18:06:41 +02:00
1ae3e8e77d
chore(tests): Adapt updatenotification tests to constructor change
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-03-25 14:58:26 +01:00
f758f565d4
fix: Replace getInstalledApps calls with getEnabledApps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-02-13 10:19:20 +01:00
e212f337a2
fix(updatenotification): Parse pre-release version of apps
...
The notitication is correctly created, but the changelog is not show.
We need to make sure the version passed to the manager is in the allowed
format (major.minor.patch).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-01-21 16:43:20 +01:00
db94aeb96e
chore(tests): Adapt tests to the countUsers refactor
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-01-14 16:34:15 +01:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-21 12:37:59 +02:00
71f1e0cb9c
refactor(updatenotification): Migrate legacy code
...
1. Remove hook usage and just provide an initial state
2. Replace jQuery code with modern non-deprecated frontend code
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-09-24 18:53:49 +02:00
8927510685
Merge pull request #48223 from nextcloud/feat/add-rector-config
...
Add rector config
2024-09-23 15:10:30 +02:00
1a4978c4ea
chore: Apply rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-09-20 17:51:00 +02:00
606241caeb
chore(legacy): Introduce public version ct plass and drop version methods from OC_Util
...
Signed-off-by: Julius Knorr <jus@bitgrid.net >
2024-09-20 14:53:34 +02:00
0e07c310a1
fix(ci): Remove more withConsecutive in apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-09-20 10:23:47 +02:00
0a7b4b597e
Merge pull request #48042 from nextcloud/refactor/elvis
...
refactor: Use the elvis operator + fix: Handle null checks with the ?? operator
2024-09-16 10:04:37 +02:00
49dd79eabb
refactor: Add void return type to PHPUnit test methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2024-09-15 22:32:31 +02:00
614f9ec0a2
refactor: Use the elvis operator
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2024-09-15 21:01:34 +02:00
cc1686dba9
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-31 10:38:47 +02:00
519e434573
fix(updatenotification): spread the use of new appconfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2024-03-13 02:22:11 -01:00
2c87fbf207
fix(updatenotification): Adjust tests for changed IAppConfig
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-03-08 01:53:59 +01:00
9c1a87aec4
fix(updatenotification): Update tests to match with changed constructors
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-03-07 22:40:30 +01:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
de4bc44f95
test(updatenotification): No internet
...
Signed-off-by: Christopher Ng <chrng8@gmail.com >
2023-08-11 11:23:30 -07:00
31f1354777
Add instance category while checking new updates
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-07-18 15:39:23 +02:00
72c7fad1c4
Fix job tests in updatenotification and user_ldap applications
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-12-05 11:32:49 +01:00
954f4940cf
Fix test update notification
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-09-15 18:18:30 +02:00
49334e4d9c
Fix many tests and warnings
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-08-08 17:03:51 +02:00
956d895920
Update tests after ResetTokenBackgroundJob changes
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr >
2022-06-15 10:29:16 +02:00
e8122f21c5
show warning in update admin overview
...
Signed-off-by: szaimen <szaimen@e.mail.de >
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com >
2022-03-24 23:04:33 +00:00
9b128d823b
Jitter the requests to the appstore and updater server over 3 minutes
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2021-07-16 16:58:09 +02:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com >
2021-06-04 22:02:41 +02:00
42140ab53f
Fix update notification tests
...
18) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #1 ('app2', '1.0.1', '1.0.0', '1.0.0', true, array('user1'), array(array('user1')))
Method notify may not return value of type Mock_INotification_2134ee38, its return declaration is ": void"
19) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #2 ('app3', '1.0.1', false, false, true, array('user2', 'user3'), array(array('user2'), array('user3')))
Method notify may not return value of type Mock_INotification_2134ee38, its return declaration is ": void"
Signed-off-by: Joas Schilling <coding@schilljs.com >
2021-04-20 17:15:31 +02:00
6ce469132c
Hide updater button when web updater is disabled
...
Whenever the web updater is disabled, the updater button and its
matching token requesting endpoints are disabled.
Signed-off-by: Vincent Petry <vincent@nextcloud.com >
2021-02-18 08:53:57 +01:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-12-16 18:48:22 +01:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-10-05 20:25:24 +02:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-08-24 14:54:25 +02:00
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2020-08-12 13:55:19 +02:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-29 11:57:22 +02:00
773e9d0554
Add tests for update notification controller for non-default updater server URL
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2020-04-28 15:28:47 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 14:19:56 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 10:35:09 +02:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-09 11:48:10 +02:00
Côme Chilliet
Carl Schwan
Ferdinand Thiessen
Louis Chmn
Josh Richards
Robin Appelman
Joas Schilling
provokateurin
Côme Chilliet
Julius Knorr
Christoph Wurst
Christoph Wurst
Andy Scherzinger
Maxence Lange
Christopher Ng
Benjamin Gaussorgues
Carl Schwan
Thomas Citharel
szaimen
John Molakvoæ (skjnldsv)
Vincent Petry
Morris Jobke