1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
d8e8703796
chore: add missing Override attribute to app code
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:28 +02:00
f12cecb684
feat(rector): Enable SafeDeclareStrictTypesRector
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-09 10:59:31 +01:00
2ae9626fec
refactor(user_ldap): Port most of the remaining deprecated IConfig usage
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-12-11 13:27:48 +01:00
4d47fdaa85
chore: Run rector with new rules for fetch
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-11-18 17:45:57 +01:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-21 12:37:59 +02:00
a1681b0756
chore(db): Apply query prepared statements
...
Fix: psalm
fix: bad file
fix: bug
chore: add batch
chore: add batch
chore: add batch
fix: psalm
2024-10-17 20:30:47 +02:00
8d8891c5bc
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-30 15:49:33 +02:00
875d0a27b0
fix(user_ldap): Ignore unserialize error in group membership migration
...
The memberships will be checked by the background job later and data
will be added to the table anyway.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-03-06 10:18:16 +01:00
92fc12918e
fix(migrations): Help developers to add description and copyright info
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-03-05 12:56:38 +01:00
303e2febc7
Merge pull request #43387 from nextcloud/fix/migrate-away-from-ilogger-in-jobs
2024-02-08 18:27:44 +01:00
898df41de9
Revert "Merge branch 'master' of github.com:nextcloud/server"
...
This reverts commit d9d60238c7ba3fdb0cdc
2024-02-08 15:31:19 +01:00
166773879b
fix!: Migrate jobs away from deprecated interfaces
...
BREAKING CHANGE: Removed ILogFactory::getCustomLogger deprecated method
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-02-08 10:28:29 +01:00
6d0f0fc01b
Fix upgrade of user_ldap when oc_group_members contains duplicated uids
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-01-04 11:51:33 +01:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
a0808111b4
Add unique index for user_ldap group memberships
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-08-10 10:57:37 +02:00
5425f7d3bd
Use BIGINT for new table id field
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-08-10 10:57:36 +02:00
ec13f22ae3
Add missing primary key for ldap_group_membership
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-08-10 10:57:33 +02:00
d8142b6a5a
Refactor user_ldap group membership to use flat DB
...
Move away from serialized arrays. Also use a QBMapper class for the new table.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-08-10 10:57:25 +02:00
b0938b9083
Refactors "strpos" calls in /apps/user_ldap to improve code readability.
...
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com >
2023-06-02 15:26:55 +03:30
1e5a879d2e
Fix createNamedParameter in LDAP migrations
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com >
2022-04-07 11:34:13 +02:00
d07208bd2c
Use the new octetLength function to filter lines to migrate
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-03-30 14:43:09 +00:00
52b57eb753
shrink ldap_dn column to 4000
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2022-03-30 14:43:08 +00:00
2f49f4a0fe
limit ldap_dn columns to 4000
...
- enlarging string cols from 255 to more than 4000 fails on default
Oracle installations for invalid datatype conversion
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2022-03-30 14:43:08 +00:00
efebbacca4
Add octetLength and charLength to function builder, and tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-03-24 20:35:02 +00:00
7dc3eb1e9e
Use getLengthExpression to measure field length instead of like
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-03-24 20:35:02 +00:00
4656753df0
do not forget DB table prefix with truncate query
...
- as used in LDAP's AbstractMapping::clear() method
- and in Comment's ManagerTest::setUp()
- fixes a DB Exception with Oracle
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2022-03-18 16:59:46 +01:00
ccab35f23f
Fix similar potential problems with fetchOne loops
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-03-08 12:10:52 +01:00
65a866556b
Fix duplicated UUID detection when there are empty uuids
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-03-08 11:57:33 +01:00
16b6504cc6
code style
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2022-03-03 21:32:54 +01:00
f3668f2748
be conservative when reading from fresh created column
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2022-03-03 21:26:18 +01:00
601ce05dab
allow to re-run migration step when backup DB is already created
...
- to heal incomplete states from broken upgrades
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2022-02-10 10:14:59 +01:00
71fb44953e
invalidated duplicated UUIDs prior to migration change
...
- in a proper setup there are no duplicated UUIDs
- not all setups are proper
- log warning to admin
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2022-02-10 10:14:58 +01:00
843b20c4e8
Remove useless indexes with duplicated names on backup table
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-01-13 17:21:26 +01:00
7e4e919408
Fix user_ldap migration for long DNs support
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-01-13 14:06:59 +01:00
23845755f2
Move duplicated code to a base class for group_mapping migrations
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com >
2022-01-13 14:06:59 +01:00
d4cabf8a84
Split dropTable and createTable in two migrations
...
It is not possible to drop and create the same table in one migration
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-01-13 14:06:58 +01:00
e64e08ecac
Fix primary key change in user_ldap migration
...
Use a backup table to copy the data, drop table and recreate it with
correct primary key, then copy the data back and drop the backup table.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-01-13 14:06:58 +01:00
57fda4414f
Add missing copyright headers in migration steps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-12-09 17:42:17 +01:00
a35904749f
Use clearer names for variables
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-23 09:20:31 +01:00
514324916b
Add an index for directory_uuid as well
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-23 09:20:30 +01:00
14f00208e2
Add the columns and alter the index in Version1010Date20200630192842
...
This is to ensure new installations do not need to go through migration
history.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-23 09:20:30 +01:00
c4d8bd9c05
Fixes in migration step
...
We cannot set ldap_dn_hash column as notnull because it is empty for
existing users before postSchemaChange is called
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-23 09:20:29 +01:00
ce5192a461
Fixed migration step for user_ldap
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-23 09:20:29 +01:00
9a1df9ddca
Fix variable names
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2021-11-23 09:19:50 +01:00
31a503b387
Change column names to ldap_dn and ldap_dn_hash and add migration
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-23 09:19:50 +01:00
662e3240b0
Support LDAP dns longer than 255 characters
...
Adds an ldap_full_dn column to store the dn, and only store a sha256
hash in the ldap_dn which is shorter and can be indexed without
trouble.
Migration still needs to be implemented.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-23 09:19:49 +01:00
6ab30a669b
ensure that user and group IDs in LDAP's tables are also max 64chars
...
- limitation by core tables (e.g. sharing), IDs are always 64chars
- when longer group IDs were requested they are hashed (does not affect
displaynames)
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2021-09-24 17:29:29 +02:00
f62c066459
unset ldap provider when disabling user_ldap
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2021-06-30 15:25:00 +02:00
Côme Chilliet
Ferdinand Thiessen
provokateurin
Carl Schwan
Git'Fellow
Andy Scherzinger
Joas Schilling
Côme Chilliet
Louis Chemineau
Faraz Samapoor
John Molakvoæ
Arthur Schiwon