1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
b7d6822592
fix(user_ldap): fix lastLogin reading wrong appid and configkey
...
fetchDetails() was calling getValueInt($uid, 'user_ldap', 'email')
instead of getValueInt($uid, 'login', 'lastLogin'), causing lastLogin
to always return 0 for offline LDAP users.
Fixes #58421
Signed-off-by: hamid <hamid@webpick.net >
2026-04-03 13:06:49 +01:00
0ace547307
fix(LDAP): do not use count() inside a loop
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2026-03-18 11:34:35 +01:00
1c01895796
fix(LDAP): use displayname from DB, before reaching out to LDAP
...
As we do it with other information of the user, we now use the known value
of a users displayname, and leave the updating to the background job. This
improves performance of user facing actions where the display name is
required and reduces queries to the LDAP server that are typically more
expensive.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2026-03-18 11:34:35 +01:00
5d0d0c17e5
chore(rector): Run rector on apps, core and tests directory
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:23:23 +01:00
f2a5a8d70e
fix(user_ldap): Fix crash in some code path when a DN is longer that 64
...
UserConfig throws in this case.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-01-27 14:05:53 +01:00
1661855f5b
refactor: Make some code a bit more correct
...
- Use PHP_FLOAT_EPSILON for float comparaison
- Simplify some getValueBool code
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-12-11 13:27:50 +01:00
2ae9626fec
refactor(user_ldap): Port most of the remaining deprecated IConfig usage
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-12-11 13:27:48 +01:00
14daf4ca16
refactor(user_ldap): Port User\User to IUserConfig
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-12-11 13:27:48 +01:00
1d43f6b4a9
Merge pull request #53714 from Mark-PAS/master
...
Only attempt $result array access if array not empty.
2025-07-14 11:25:27 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
b04760af6e
Only attempt $result array access if array not empty.
...
Signed-off-by: Mark <mark@perkinsadministrationservices.com.au >
2025-07-01 07:44:20 +09:30
78a175fc74
refactor: Apply rector refactorings
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-05-14 15:29:02 +02:00
1ae3fa4003
chore: replace leagcy OC_Helper calls with OCP\Util
...
- Replace legacy calls with OCP\Util
- Add missing deprecation notices
- Inline implementation in OCP\Util and call it from OC_Helper
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-05-14 10:18:04 +02:00
1eb9000b0d
fix(LDAP): inlcude ldapExpertUsernameAttr in general attribute list
...
fixes corner cases in which an LDAP record might be loaded and used,
where the user is still not mapped - and then this information is
missing though expected.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2025-04-17 17:00:31 +02:00
64863c9d46
chore: Apply new rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-02-13 11:46:42 +01:00
12d1d1d389
fix(user_ldap): Remove now unused class FilesystemHelper
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-01-13 17:12:19 +01:00
e75dd1fc92
fix(user_ldap): Strong type User class and fix most type issues
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-01-13 17:12:19 +01:00
40920ddb77
fix(user_ldap): Always update avatar from LDAP when we have the data
...
Should be at login, in sync job, and when running ldap:check-user --update
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-01-13 16:23:26 +01:00
d2f118f147
chore(user_ldap): Improve typing in user_ldap User class
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-01-13 16:01:39 +01:00
c0cb8ec7d4
chore(user_ldap): Rename avatar setting method to a more suited name
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-01-13 15:54:48 +01:00
486f0eda71
fix(user_ldap): retrieve from LDAP first "email shaped" value instead of first value
...
Signed-off-by: Thatoo <Thatoo@users.noreply.github.com >
2024-11-20 16:55:44 +01:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-21 12:37:59 +02:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-10-15 10:40:25 +02:00
51d9d63a01
chore: Use more gender neutral language
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-14 13:59:24 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
26abc86eca
feat: add profile pronouns
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com >
2024-09-17 22:20:36 +02:00
614f9ec0a2
refactor: Use the elvis operator
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2024-09-15 21:01:34 +02:00
d2bc636a79
fix(user_ldap): Correctly cache that user exists to avoid a request on mapping new user
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-08-27 10:06:43 +02:00
4fb1d2f3e5
fix(user_ldap): Avoid extra LDAP request when mapping a user for the first time
...
Avoids using several LDAP searches to get UUID, display name and
internal name, now gets all attributes at the same time.
Also avoids extra request to build an unused user object in userExists.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-08-27 10:05:12 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
2d62b0a936
Merge pull request #45573 from nextcloud/chore/noid/spdx-batch9
...
Add SPDX header - batch 9
2024-05-30 19:24:53 +02:00
dee0eb2f0b
Merge pull request #36942 from nextcloud/unmark-login-date
2024-05-30 18:09:49 +02:00
8d8891c5bc
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-30 15:49:33 +02:00
f863290572
feat(ldap): sync additional properties to profile and SAB
...
Synced from LDAP to profile:
- Date of birth
Synced from LDAP to SAB (via the profile):
- Biography
- Date of birth
Original code by Jake Nabasny (GitHub: @slapcat)
Co-authored-by: Jake Nabasny <jake@nabasny.com >
Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud >
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud >
2024-05-30 12:01:13 +02:00
61a6013798
fix: php lint
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com >
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com >
2024-05-27 10:14:26 -04:00
36cb845f05
unmark deleted users if their last login date is more recent than deleted date
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-05-27 10:14:26 -04:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-02 14:16:21 +02:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
7f5b61c66d
Update apps/user_ldap/lib/User/User.php
...
Co-authored-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2023-09-29 13:48:06 +02:00
66f6e94d7d
LDAP: Increase profile picture limit to 512
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2023-09-29 12:47:48 +02:00
7a59d2ec07
Remove deprectated ILogger uses from user_ldap application
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-09-19 15:22:45 +02:00
4054a7ddc8
fix(LDAP): add return type hint and description
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2023-07-07 10:46:00 +02:00
92a082d823
fix(ldap): avatar is not being fetched
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2023-07-05 17:13:43 +02:00
b2f01b72fe
Merge pull request #34443 from nextcloud/feat/add-enabled-user-backend
...
Add IProvideEnabledStateBackend interface
2023-07-03 10:19:32 +02:00
b0938b9083
Refactors "strpos" calls in /apps/user_ldap to improve code readability.
...
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com >
2023-06-02 15:26:55 +03:30
684a81e4bd
Use the new IProvideEnabledStateBackend interface in user_ldap
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-05-23 11:25:22 +02:00
621c6c3c56
code styling
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com >
Signed-off-by: Marc Hefter <marchefter@march42.net >
2023-04-24 10:21:45 +02:00
aa210365ec
Update apps/user_ldap/lib/User/User.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com >
Signed-off-by: Marc Hefter <marchefter@march42.net >
2023-04-24 10:14:17 +02:00
e83520617d
removed profile data from LDAP will get removed
...
If attribute mapping is configured and no value present in LDAP, the
according profile field is emptied. Removing an attribute e.g. phone
from LDAP will cause the phone number being removed from profile.
Signed-off-by: Marc Hefter <marchefter@gmail.com >
2023-04-21 10:35:44 +02:00
Côme Chilliet
hamid
Arthur Schiwon
Carl Schwan
Joas Schilling
Ferdinand Thiessen
Mark
provokateurin
Thatoo
John Molakvoæ (skjnldsv)
Christoph Wurst
Daniel Kesselberg
Andy Scherzinger
John Molakvoæ
Jake Nabasny
Robin Appelman
Joas Schilling
Marcel Klehr
Côme Chilliet
Faraz Samapoor
Marc Hefter
Marc Hefter