averello/nextcloud-server-mirror
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-29 12:24:50 +02:00
Code Issues Packages Projects Releases Wiki Activity
88,512 Commits 1,008 Branches 1,229 Tags
executeUpdateRemove
Commit Graph

83 Commits

Author SHA1 Message Date
Anna Larch bbf05d3b8f fix(user_ldap): allow editing profile fields not managed by LDAP 
canEditProperty() was returning true (editable) when an LDAP attribute
was configured for a field, and false when no attribute was configured.
This is inverted: a field with an LDAP attribute mapping is owned by
LDAP and should not be user-editable, while a field with no mapping is
not sourced from LDAP and the user should be free to set it themselves.

Fixes profile fields being uneditable for all LDAP users whose admin
has not configured attribute mappings for those fields.

Assisted-by: ClaudeCode:claude-sonnet-4-6
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2026-06-04 12:07:10 +02:00
Côme Chilliet 1ab09ec753 chore: Apply new coding standard to all files 
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-06-01 13:46:39 +02:00
Carl Schwan 11cf69d8ba fix(psalm): Fix static analysis issues in apps/*/tests 
There are still 1200 more to fix before we can enable static analysis
for the tests.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-01-16 12:00:51 +01:00
Ferdinand Thiessen c99d27436f chore: adjust duplicated use in User_LDAPTest 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-10-27 21:56:04 +01:00
Ferdinand Thiessen d6d6747a73 refactor: apply rector rules for PHPUnit 10 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-10-27 21:56:04 +01:00
Robin Appelman aa15f9d16d chore: run rector 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-07-01 22:45:52 +02:00
Joas Schilling 6c7f8ea55b test: Migrate User LDAP to phpunit 10 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-28 10:10:45 +02:00
Côme Chilliet 0cf4f3cc71 fix: Replace all usages of OC_User backend method calls by IUserManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-04-10 11:29:21 +02:00
Côme Chilliet 64863c9d46 chore: Apply new rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 11:46:42 +01:00
Côme Chilliet 1580c8612b chore(apps): Apply new rector configuration to autouse classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-15 10:40:25 +02:00
provokateurin 9836e9b164 chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Christoph Wurst 49dd79eabb refactor: Add void return type to PHPUnit test methods 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 22:32:31 +02:00
Côme Chilliet c3029c70d5 fix(user_ldap): Fix user_ldap tests by mocking new method exists in manager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-08-27 12:14:34 +02:00
Daniel Kesselberg af6de04e9e style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
Akhil b1230cd53d Use cache in LDAP backend's checkPassword 
Signed-off-by: Akhil <akhil@e.email>
 2024-08-16 17:55:47 +05:30
Arthur Schiwon 0447aa4e62 fix(LDAP): remove unneeded dependencies 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2024-08-01 20:13:11 +02:00
Andy Scherzinger 8d8891c5bc chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-30 15:49:33 +02:00
Côme Chilliet d4229f9f59 fix(user_ldap): Fix tests using wrong types 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-09 10:01:47 +02:00
Joas Schilling aa5f037af7 chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Côme Chilliet b2f01b72fe Merge pull request #34443 from nextcloud/feat/add-enabled-user-backend 
Add IProvideEnabledStateBackend interface
 2023-07-03 10:19:32 +02:00
Faraz Samapoor b0938b9083 Refactors "strpos" calls in /apps/user_ldap to improve code readability. 
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-06-02 15:26:55 +03:30
Côme Chilliet add59d2309 Use DI for DeletedUsersIndex and fix tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-05-25 12:18:28 +02:00
Côme Chilliet dab5ea958a Fix unit tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-03 16:35:06 +01:00
Gary Kim b78f3a57d1 Migrate HintException to OCP 
Signed-off-by: Gary Kim <gary@garykim.dev>
 2021-06-30 15:28:02 -04:00
John Molakvoæ (skjnldsv) 215aef3cbd Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Arthur Schiwon fd1fd5afa4 user share manager to determine share ownership 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-10-26 16:05:28 +01:00
Christoph Wurst d9015a8c94 Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00
Morris Jobke 234b510652 Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-12 13:55:19 +02:00
Arthur Schiwon b8bef4ded0 fix strings being passed where arrays where expected 
also brought type hints up to internal API level

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-06-24 23:34:37 +02:00
Christoph Wurst caff1023ea Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst 14c996d982 Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst afbd9c4e6e Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst 1a9330cd69 Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Christoph Wurst b80ebc9674 Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst 2ee65f177e Use the shorter phpunit syntax for mocked return values 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:21:27 +01:00
Arthur Schiwon f657ded6ec remove superfluous tests 
- user_ldap is not exposed to public api, it is always behind ldap_proxy
- this is too much for a unit test
- integration tests cover userExists implicitly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-08 09:21:22 +01:00
Arthur Schiwon 1068b860ff adjust tests 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-08 09:21:22 +01:00
Arthur Schiwon 411a47cadb relax strict getHome behaviour for LDAP users in a shadow state 
* simplifies deletion process
* less strange behaviour when looking up home storage (as long as it is local)
* thus could enable transfer ownerships after user went invisible on ldap

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-08 09:21:21 +01:00
Christoph Wurst 5bf3d1bb38 Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-05 15:38:45 +01:00
Roeland Jago Douma 3a7cf40aaa Mode to modern phpunit 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-27 15:27:18 +01:00
Roeland Jago Douma c007ca624f Make phpunit8 compatible 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-27 13:34:41 +01:00
Roeland Jago Douma 68748d4f85 Some php-cs fixes 
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-22 20:52:10 +01:00
Arthur Schiwon 108227ca6c invalidates user when plugin reported deletion success 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-06-26 14:18:28 +02:00
Arthur Schiwon 660fbd64e3 ensures mapping of chosen userid 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-06-19 17:02:28 +02:00
Arthur Schiwon a1f2dbe29c caches the displayname after an LDAP plugin set it 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-06-18 12:42:03 +02:00
Vinicius Cubas Brand c4dbc428f9 fix user creation using LDAP Plugin 
Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
 2019-03-21 10:20:46 +01:00
Arthur Schiwon 2b903aa267 fix unit tests 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-08-15 16:11:07 +02:00
Arthur Schiwon 846ab25fc0 adjust and add more unit tests 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-07-05 11:50:49 +02:00
Arthur Schiwon a4dda465c2 let user set avatar in nextcloud von LDAP provides invalid image data 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-07-03 01:45:07 +02:00
Arthur Schiwon 552da85df8 Iron User_LDAP tests 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-07-03 00:29:34 +02:00