Trying to create an auth token from an authtoken
returns 403 now, not 503 (which is more correct)
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
The Remote API classes (OC\Remote\* and OCP\Remote\*) were removed in
#60953, but the remoteapi Behat integration suite was not updated. This
caused fatal PHP errors when Behat tried to bootstrap RemoteContext,
breaking the integration test run on master.
Remove RemoteContext.php, remote.feature, and the remoteapi suite entry
in behat.yml since there is nothing left to test.
Assisted-by: ClaudeCode:claude-sonnet-4-6
Signed-off-by: Anna Larch <anna@nextcloud.com>
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Add @BeforeScenario hooks to reset auth/server state and sharing state
between scenarios, preventing state bleed across test runs.
- BasicStructure: reset currentUser, currentServer, baseUrl, apiVersion,
requestToken and cookieJar (baseUrl and currentServer go together via
usingServer(), so both must be reset)
- Sharing: reset lastShareData, storedShareData and savedShareId
Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
It has quite nasty overwrites in place for appconfig and storages
which break too often and can otherwise only be noticed by low privileged
users
Signed-off-by: Joas Schilling <coding@schilljs.com>
UserPlugin reads `shareapi_restrict_user_enumeration_full_match_userid`
(no underscore) while Manager.php and the frontend both use
`shareapi_restrict_user_enumeration_full_match_user_id` (with underscore).
This mismatch causes the "disable exact match by user ID" admin setting
to have no effect on actual sharee search results.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Update expected values in ManagerTest to reflect the new behavior
where share expiration dates are set to 23:59:59 instead of 00:00:00.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Birthdate was missing in editable fields while being editable, and the
order was checked while having no importance.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This removes all the read after write and we don't need to queries all
the time the same share in the same request anymore.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
Starting with PHPUnit 11.3, some complex outputs of certain asserts
(like "assertStringContainsString") require the output of PHPUnit to be
explicitly setup. Otherwise when the assert fails a type error is
thrown (although it does not seem to affect asserts with simpler
outputs, like "assertEquals").
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>