Commit Graph

133 Commits

Author SHA1 Message Date
Carl Schwan a459b9cc1f refactor(server): Register alias when needed
And remove useless service registration

Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-06-10 23:22:24 +02:00
Côme Chilliet 1ab09ec753 chore: Apply new coding standard to all files
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-01 13:46:39 +02:00
Anna Larch c4356e1b25 fix(appstore): address review comments on GenericFileException handling
- Attempt delete before logging the warning, so the warning only fires
  when we know recovery will succeed
- Log an error (not silently return) when delete itself fails
- Use catch (\Exception) without variable (PHP 8)
- Replace willReturnArgument(1) with explicit willReturn(true) in test
- Add blank lines between logical blocks in test for readability

Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-19 16:52:52 +02:00
Anna Larch 5113b18739 fix(appstore): catch GenericFileException when reading cache file in Fetcher
When the appstore cache file exists but getContent() throws a
GenericFileException (I/O error or OS-level permission failure), explicitly
delete the file and recreate it before writing fresh data — mirroring the
NotFoundException recovery path. If deletion itself fails, return [] cleanly.

Previously, the unhandled exception caused the entire apps settings page to
crash. The new test covers both the recovery path and deletion failure.

Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-19 16:34:06 +02:00
Ferdinand Thiessen 3f8710500c chore: apply strict rector rules on appstore
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-05-05 10:41:04 +02:00
Ferdinand Thiessen e7a2f660c7 refactor(Fetcher): properly type AppStore fetcher
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-04-30 14:01:56 +02:00
Ferdinand Thiessen e0ba4d71b6 chore: add missing Override attribute to OC
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-04-28 21:29:27 +02:00
provokateurin f12cecb684 feat(rector): Enable SafeDeclareStrictTypesRector
Signed-off-by: provokateurin <kate@provokateurin.de>
2026-02-09 10:59:31 +01:00
Kate 86ef7781c0 Merge pull request #55420 from nextcloud/fix/40082/appstore-timeout 2025-09-30 17:18:37 +02:00
Marcel Müller 31481701f3 fix(appstore): Make appstore timeout configurable
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2025-09-30 13:00:06 +02:00
Marcel Müller 31b8d36802 fix(appstore): Also catch ClientException and ServerException
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2025-09-30 11:27:47 +02:00
provokateurin 5bd626bd40 chore: Fix all method calls with too many arguments
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-22 12:34:49 +02:00
Ferdinand Thiessen 5981b7eb51 chore: apply new CSFixer rules
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
Côme Chilliet c85f7eacb8 fix: Throw AppNotFoundException from installer when application is not found
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 17:03:16 +02:00
Julius Knorr 606241caeb chore(legacy): Introduce public version ct plass and drop version methods from OC_Util
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-20 14:53:34 +02:00
provokateurin 9836e9b164 chore(deps): Update nextcloud/coding-standard to v1.3.1
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +02:00
Grigorii K. Shartsev 70ed4aec39 fix(appstoreFetcher): get app list from custom app store
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-17 01:29:25 +02:00
Grigorii K. Shartsev ce679c3da4 fix(appstoreFetcher): remove unneeded warning
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-17 01:24:49 +02:00
Git'Fellow 413ba1a718 Merge pull request #47854 from nextcloud/validAppsFromAppStore
fix(appstore): Ensure returned apps from AppStore are valid
2024-09-13 10:55:33 +02:00
Git'Fellow dccfb6d68a fix: check if key is set
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-13 09:49:09 +02:00
Julius Knorr 38e0a89972 fix: Add whiteboard to education and public sector bundle
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-12 09:13:42 +02:00
Git'Fellow 8585b05357 fix(appstore): Ensure returned apps from AppStore are valid
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: lint

chore: remove space

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: check if response array is null

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

chore: Add log
2024-09-11 11:12:59 +02:00
John Molakvoæ 4d3168fb24 fix(appstore): disabled appstore log level bump from debug to info
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-10 16:00:56 +02:00
Git'Fellow 2ac8d9a3db fix(appstore): return if appstore is manually disabled
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: camel case

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: log a debug log

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: typing

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: typo

fix: typing
2024-09-09 09:56:22 +02:00
Marcel Müller b2c2c93a03 fix(appstore): Cache apps.json also on dev instances
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-09-04 21:56:58 +02:00
Julius Härtl 3ca7480829 fix: Do not throw if appstore is unavailable during upgrade
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-09-04 09:31:13 +02:00
Jérôme Herbinet c221090c86 fix: unify bundle naming
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-08-06 11:14:07 +02:00
Git'Fellow 8665a9ba16 chore: add warning in case of failure
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-16 18:13:25 +02:00
Git'Fellow b010474c78 fix(appstore): Return an empty array in case of fail
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-16 11:42:35 +02:00
Andy Scherzinger dae7c159f7 chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-24 13:11:22 +02:00
Ferdinand Thiessen 63f19661d2 fix(AppStore\Fetcher): Ensure get returns an array
When fetch fails and the `data` prop contains null (e.g. `json_decode` failed),
then we should return an empty array instead of null.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-22 15:01:16 +01:00
Ferdinand Thiessen bae133bf4f fix(AppDiscoverFetcher): Do not remove entries as expired that have no expiry date
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-19 09:36:06 +01:00
Ferdinand Thiessen df502c114d feat(settings): Cache app discover images to ensure privacy of users
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-14 20:45:25 +01:00
Ferdinand Thiessen f4efb762ec feat: Allow to fetch app discover json and provide frontend API route
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-14 20:45:24 +01:00
sorbaugh 82a17248f0 feat: Adding PublicSectorBundle
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-03-12 10:26:50 -07:00
Julius Härtl e13fb468cf fix: Fetch custom app store url without internet connection
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-04 12:47:14 +01:00
Hamid Dehnavi cf17db2fe6 Fix psalm errors
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2024-02-23 15:53:41 +01:00
Hamid Dehnavi b6ef67edfc Make adjustments based on the psalm review
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2024-02-23 15:53:41 +01:00
Hamid Dehnavi 7a8d79b85c Fix code style
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2024-02-23 15:53:41 +01:00
Hamid Dehnavi 84749d53a9 Refactor lib/private/App
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2024-02-23 15:53:41 +01:00
Joas Schilling 57a30e9bbe fix(appstore): Only send subscription keys to valid appstores
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-15 15:39:45 +01:00
Joas Schilling aa5f037af7 chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Hamid Dehnavi ea06cf2f39 Convert isset ternary to null coalescing operator
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-28 17:44:19 +03:30
Faraz Samapoor e7cc7653b8 Refactors "strpos" calls in lib/private to improve code readability.
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>
2023-05-15 15:17:19 +03:30
Côme Chilliet 426c0341ff Use typed version of IConfig::getSystemValue as much as possible
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 12:50:08 +02:00
Côme Chilliet f5c361cf44 composer run cs:fix
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +01:00
Arthur Schiwon a133a8a9d7 remove getDefaultInstallationBundle
- because all apps are shipped now it was returning an empty result

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-22 15:11:39 +02:00
Arthur Schiwon 759eaee5ed remove Core Bundle
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-22 13:20:37 +02:00
acsfer bebf888c72 Fix #30003
Fix #30003
2022-06-21 16:54:13 +00:00
Joas Schilling a9ba631e4d Also allow pre-releases and nightlies when installing from git
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 16:10:25 +01:00