averello/nextcloud-server-mirror
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-29 12:24:50 +02:00
Code Issues Packages Projects Releases Wiki Activity
88,512 Commits 1,008 Branches 1,229 Tags
executeUpdateRemove
Commit Graph

65 Commits

Author SHA1 Message Date
Côme Chilliet 1ab09ec753 chore: Apply new coding standard to all files 
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-06-01 13:46:39 +02:00
Anna Larch c4356e1b25 fix(appstore): address review comments on GenericFileException handling 
- Attempt delete before logging the warning, so the warning only fires
  when we know recovery will succeed
- Log an error (not silently return) when delete itself fails
- Use catch (\Exception) without variable (PHP 8)
- Replace willReturnArgument(1) with explicit willReturn(true) in test
- Add blank lines between logical blocks in test for readability

Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
 2026-05-19 16:52:52 +02:00
Anna Larch 5113b18739 fix(appstore): catch GenericFileException when reading cache file in Fetcher 
When the appstore cache file exists but getContent() throws a
GenericFileException (I/O error or OS-level permission failure), explicitly
delete the file and recreate it before writing fresh data — mirroring the
NotFoundException recovery path. If deletion itself fails, return [] cleanly.

Previously, the unhandled exception caused the entire apps settings page to
crash. The new test covers both the recovery path and deletion failure.

Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
 2026-05-19 16:34:06 +02:00
Ferdinand Thiessen e7a2f660c7 refactor(Fetcher): properly type AppStore fetcher 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2026-04-30 14:01:56 +02:00
Kate 86ef7781c0 Merge pull request #55420 from nextcloud/fix/40082/appstore-timeout 2025-09-30 17:18:37 +02:00
Marcel Müller 31481701f3 fix(appstore): Make appstore timeout configurable 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2025-09-30 13:00:06 +02:00
Marcel Müller 31b8d36802 fix(appstore): Also catch ClientException and ServerException 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2025-09-30 11:27:47 +02:00
provokateurin 5bd626bd40 chore: Fix all method calls with too many arguments 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-07-22 12:34:49 +02:00
Ferdinand Thiessen 5981b7eb51 chore: apply new CSFixer rules 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
 2025-07-01 16:26:50 +02:00
Julius Knorr 606241caeb chore(legacy): Introduce public version ct plass and drop version methods from OC_Util 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
 2024-09-20 14:53:34 +02:00
Grigorii K. Shartsev 70ed4aec39 fix(appstoreFetcher): get app list from custom app store 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
 2024-09-17 01:29:25 +02:00
Marcel Müller b2c2c93a03 fix(appstore): Cache apps.json also on dev instances 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2024-09-04 21:56:58 +02:00
Julius Härtl 3ca7480829 fix: Do not throw if appstore is unavailable during upgrade 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-09-04 09:31:13 +02:00
Andy Scherzinger dae7c159f7 chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-24 13:11:22 +02:00
Ferdinand Thiessen 63f19661d2 fix(AppStore\Fetcher): Ensure get returns an array 
When fetch fails and the `data` prop contains null (e.g. `json_decode` failed),
then we should return an empty array instead of null.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-22 15:01:16 +01:00
Ferdinand Thiessen f4efb762ec feat: Allow to fetch app discover json and provide frontend API route 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-14 20:45:24 +01:00
Julius Härtl e13fb468cf fix: Fetch custom app store url without internet connection 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-03-04 12:47:14 +01:00
Hamid Dehnavi 84749d53a9 Refactor lib/private/App 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
 2024-02-23 15:53:41 +01:00
Joas Schilling 57a30e9bbe fix(appstore): Only send subscription keys to valid appstores 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-01-15 15:39:45 +01:00
Joas Schilling aa5f037af7 chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Côme Chilliet 426c0341ff Use typed version of IConfig::getSystemValue as much as possible 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 12:50:08 +02:00
Côme Chilliet f5c361cf44 composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00
Julien Veyssier facb50ebcc fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController 
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
 2021-10-18 12:39:43 +02:00
John Molakvoæ 1f76423500 Send the subscription key to the appstore requests 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2021-10-14 14:48:45 +02:00
John Molakvoæ (skjnldsv) 215aef3cbd Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Joas Schilling 56ae87c281 Less ILogger 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-27 14:34:32 +02:00
Christoph Wurst d89a75be0b Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Julius Härtl 4512c73293 Only retry fetching app store data once every 5 minutes in case it fails 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-10-16 14:32:58 +02:00
Christoph Wurst 2a054e6c04 Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
John Molakvoæ (skjnldsv) 9e962fb69f Allow to update to nightly 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-08-07 13:51:39 +02:00
Joas Schilling b6d5979d0a Increase timeout of the appstore requests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-12 13:01:06 +02:00
Morris Jobke 8123737a40 Revert "Compress the appstore requests by default" 
This reverts commit 6ffde128ad.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-05-20 13:37:28 +02:00
Morris Jobke 6ffde128ad Compress the appstore requests by default 
In test it reduced the transfered data from 5 MB to 2 MB. This should reduce the load on the appstore significantly.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-05-20 09:51:07 +02:00
Morris Jobke 3e0d8df036 Cache appstore requests for 60 instead of 5 minutes 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-05-20 09:51:06 +02:00
Christoph Wurst cb057829f7 Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Christoph Wurst 28f8eb5dba Add visibility to all constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:54:27 +02:00
Christoph Wurst 74936c49ea Remove unused imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:08:08 +01:00
Roeland Jago Douma 1bf44e1d97 Merge pull request #18860 from nextcloud/fix/license-headers 
Fix license headers
 2020-01-13 16:47:12 +01:00
Christoph Wurst 6127c288e8 Fix license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-01-13 14:23:49 +01:00
Georg Ehrke 2f89f5fd13 AppFetcher: Distinguish between fileName and endpointName 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-01-09 17:29:00 +01:00
Georg Ehrke f0bef8881d Restore old behavior allowing to set custom appstore 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2019-12-22 15:06:31 +01:00
Christoph Wurst 1b46621cd3 Update license headers for 18 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-20 09:23:25 +01:00
Daniel Kesselberg dbb1eef446 Don't log the stack trace for ConnectException 
The stack trace for ConnectException could contain the old apps.json content and is probably huge.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2019-12-08 18:17:06 +01:00
Christoph Wurst 5bf3d1bb38 Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-05 15:38:45 +01:00
Roeland Jago Douma 68748d4f85 Some php-cs fixes 
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-22 20:52:10 +01:00
Joas Schilling 8e278a2c38 Enable pre-releases for beta and daily channel 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-04-08 15:23:44 +02:00
Arthur Schiwon 38a90130ce move log constants to ILogger 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-04-26 10:45:52 +02:00
Joas Schilling 029e8cdc5b Also allow to specify the cache file name 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-28 11:31:33 +01:00
Joas Schilling 2c840ca278 Log exceptions that happen when writing the app store reply to storage 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-21 14:14:33 +01:00
Morris Jobke c5f852d90c Also log exception for failed appstore request 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-02 09:40:03 +01:00