5dda39a61e
refactor(dbal): move to modern calls
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-24 10:35:00 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
b2c9273e5f
fix(appconfig,userconfig): restore pre-migration fallback for ownCloud migration
...
AppConfig and UserConfig unconditionally queried NC-only columns (type,
lazy, flags, indexed) that don't exist in ownCloud's database schema,
breaking ownCloud → Nextcloud upgrades entirely before the schema
migration steps could run.
Restore the fallback pattern in both classes: on first loadConfig() call,
if a DBException with REASON_INVALID_FIELD_NAME is thrown, set
$migrationCompleted = false and retry selecting only the columns present
in ownCloud's schema. INSERT and UPDATE statements also omit NC-only
columns when $migrationCompleted is false.
The catch block also guards against infinite recursion: if $migrationCompleted
is already false when the exception fires, the exception is re-thrown
instead of triggering another recursive call.
Fixes: https://github.com/nextcloud/server/issues/57340
Signed-off-by: Anna Larch <anna@nextcloud.com >
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-28 09:46:49 +02:00
b86f463915
fix(config): add null coalescing fallback in getValueBool before strtolower
...
Followup to #59646 : guard against null reaching strtolower() in both
AppConfig and UserConfig getValueBool(). Also aligns AppConfig with the
(string) cast added in UserConfig by the original PR.
Signed-off-by: skjnldsv <skjnldsv@protonmail.com >
2026-05-22 10:23:50 +02:00
e0ba4d71b6
chore: add missing Override attribute to OC
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:27 +02:00
7b6078875b
refactor: Run rector on lib/private
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:50:18 +01:00
503a65ddd0
refactor: Run rector
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-11-18 17:45:54 +01:00
1538692987
feat(lexicon): add FLAG_INTERNAL
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-11-03 11:39:25 -01:00
46ced9df22
fix(lexicon): send single notice/warning when using unknown config key
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-09-02 10:51:44 -01:00
2f4a8bb89c
Merge pull request #54620 from nextcloud/fix/set-typed-value
...
fix(AppConfig#setTypedValue): Catch AppConfigUnknownKeyException
2025-08-26 16:59:26 +02:00
dbb5705152
fix(AppConfig#setTypedValue): Catch AppConfigUnknownKeyException
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2025-08-25 14:06:29 +02:00
b7cdfddeda
feat(preset): compare userconfig lexicon entries
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-08-25 11:05:56 -01:00
6eda5583db
feat(preset): compare default for all preset
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-08-19 10:50:24 -01:00
112178d3a0
fix: typos in cache and app config
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-08-18 18:35:54 +02:00
0ef58c96ab
refactor(Memcache\Factory): move prefix generation to the factory class
...
This removes a circular dependency between AppConfig and cache factory.
When a cache in the app config is used.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-08-18 13:24:18 +02:00
d5e2432bcd
fix: resolve invalid usage of AppConfig::getValue
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-08-18 13:24:18 +02:00
1c85548f86
feat(AppConfig): cache app config in local cache if available
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-08-18 13:24:18 +02:00
bbc9ed138c
fix(config): fix tests+psalm
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-08-08 11:00:49 -01:00
f32d865716
fix(lexicon): only filter out null default
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-08-08 10:58:58 -01:00
33c4fe504d
feat(preset): new PresetManager
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-08-08 10:58:58 -01:00
9380375cc6
feat(lexicon): add note and key-details
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-07-29 08:15:08 -01:00
33bff30e1d
feat(lexicon): moving out from unstable
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-07-24 15:56:33 -01:00
20b908cf3f
feat(appconfig): add searchKeys()
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-07-18 23:54:55 -01:00
e64be71e52
feat(lexicon): preset()
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-07-15 11:29:33 -01:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
d860cfd1cb
feat(lexicon): better numeric conversion
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-06-24 12:10:57 -01:00
d5e487078a
feat(lexicon): using configmanager
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-06-24 12:10:57 -01:00
e39ab65239
feat(lexicon): migrate config key/value
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-06-24 12:10:57 -01:00
e8370bf73a
fix: Use only enabled applications versions in the cache prefix
...
This makes sure the cached routes are updated after enabling a
previously disabled application
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-06-05 17:58:54 +02:00
b3f52ebbe8
feat(appconfig): getValueType() get data from lexicon if available
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-05-05 10:17:02 -01:00
8524955091
fix(config): Censor more app configs in system report
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-04-25 11:01:38 +02:00
c7037d7b38
fix: Move getAppInstalledVersions to AppConfig so that it can be used earlier
...
Call it from OC_App to make sure there is only one request to DB.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-03-25 16:20:21 +01:00
a572a5c515
feat(appconfig): removing pre-migration check
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-03-04 10:28:14 -01:00
525eb8312b
fix(config): drop value details
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-01-26 12:59:04 +01:00
815991741d
fix(lexicon): renaming and minor fixes
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2024-12-13 11:08:20 -01:00
96586ba709
feat(config): implementation of lexicon
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2024-12-13 11:08:20 -01:00
f237846e74
feat(appconfig): Only log lazy-appconfig when an app can do something about it
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-11-06 14:16:10 +01:00
77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-11-05 09:58:11 +01:00
1e5cb82cc1
fix(config): Mark more configs as sensitive
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-10-28 14:56:19 +01:00
7edb70a63e
fix(AppConfig): Add external JWT private key to sensitive keys
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-14 10:42:06 +02:00
c900ef9d8e
fix(config): Mark more app configs sensitive
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-10-07 10:58:03 +02:00
a8f46af20f
chore: Add proper deprecation dates where missing
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-09-20 00:46:03 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
8af7ecb257
chore: adjust code to adhere to coding standard
...
Signed-off-by: Anna Larch <anna@nextcloud.com >
2024-09-05 21:23:38 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-24 13:11:22 +02:00
eb25e10f55
fix: Avoid reference use in AppConfig
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-30 09:38:47 +02:00
a624a2b34f
fix(appconfig): returns correct value on details
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2024-04-17 16:28:02 -01:00
97e59b12a1
fix(appconfig): only convert single entry on searchValues()
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2024-04-05 17:49:34 -01:00
cc813fec23
fix(appconfig): format app values
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2024-04-05 17:49:34 -01:00
Git'Fellow
Côme Chilliet
Anna Larch
skjnldsv
Ferdinand Thiessen
Carl Schwan
Maxence Lange
Marcel Klehr
Joas Schilling
provokateurin
Daniel Kesselberg
Andy Scherzinger