f7f9a47ceb
fix: Do not set last-password-confirm for apptoken sessions
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-16 11:59:13 +02:00
802bce0a77
fix: Use token expiration for ephemeral sessions
...
This simplifies the code a lot.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-15 15:28:38 +02:00
165b050a2f
Merge pull request #60889 from nextcloud/jtr/cleanup-Request
...
docs(IRequest): streamline duplicate docs + update for clarity and accuracy
2026-06-11 10:19:10 +02:00
8325e6981b
revert: "Do not do redirect handling when loggin out"
...
This reverts commit 60e5a5eca4https://github.com/nextcloud/server/pull/16310
Signed-off-by: Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de >
2026-06-09 17:49:00 +02:00
e42fb08c6c
docs(Request): add/update/cleanup internal implementation docs
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:44 +02:00
0071a97f89
chore(RequestId): drop duplicate getId docblock from implementation
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:43 +02:00
6bcc618a1e
docs(Request): update implementation docblock properties
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:40 +02:00
f0f432c526
refactor(Request): drop docblocks already in IRequest
...
Oh and slighly refactor getHeader() since this was tied to some other work that lead to this cleanup.
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:37 +02:00
a62bff17f2
fix: Fix suppressing ImpureStaticProperty and suppress it in a few places
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-02 09:46:18 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
a118773895
Merge pull request #59168 from philiprenich/fix-ios-browsers
...
fix: treat all WebKit iOS browseres the same
2026-05-21 10:17:15 +02:00
1c23feae3d
refactor: migrate usage of OC_App to AppManager
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-05-13 14:01:49 +02:00
e21b7d1121
feat: Add generate session token to CsrfTokenManager
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-05-12 18:24:12 +02:00
279bface8e
refactor: Delete deprecated code from OC_Util
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-05-12 18:24:12 +02:00
32bc6f54d3
refactor: Replace old Utils::callRegister with new API
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-05-12 18:24:12 +02:00
ac15544703
Merge pull request #60299 from nextcloud/fix/remove-iservercontainer-from-core-apps
...
Chore: Remove references to deprecated interface IServerContainer
2026-05-12 07:48:58 +02:00
9680004b58
chore: Remove almost all uses of deprecated IServerContainer in lib/private
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-05-11 16:22:22 +02:00
bdfe8ed77e
fix: Add proper methods in IAppManager for namespace handling
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-05-11 14:53:29 +02:00
d8b9c6d6a0
Merge branch 'master' into fix-ios-browsers
2026-05-06 14:37:51 +12:00
5b756ad8bc
refactor: split appstore from settings
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-05-05 10:41:04 +02:00
e0ba4d71b6
chore: add missing Override attribute to OC
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:27 +02:00
dfadafc3c3
Merge pull request #59627 from nextcloud/carl/alternative-login-provider
...
feat(auth): Add IAlternativeLoginProvider
2026-04-15 01:53:33 +02:00
f4cae8c222
feat(auth): Add IAlternativeLoginProvider
...
IAlternativeLogin has a fatal flaw in that it is not possible to
register multiple alternative login dynamically but only statically.
IAlternativeLoginProvider fixes this limitation as the provider can then
provider multiple IAlternativeLogin.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-04-14 20:21:58 +02:00
7ed9191493
fix(controller): Add default range to $limit parameter
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2026-04-13 14:45:32 +02:00
7f3b9356ca
fix: treat all WebKit iOS browseres the same
...
Signed-off-by: Philip Renich <hello@philiprenich.com >
2026-03-24 16:02:10 +13:00
1b504bf4ec
Merge pull request #58863 from nextcloud/fix/annotation-attributes-fix
2026-03-18 08:46:31 +01:00
5f80f26799
chore: Fix SPDX header
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2026-03-16 08:38:16 +01:00
2bb9524c84
fix: Remove deprecated RFC7231 constant to avoid warnings on PHP 8.5
...
Signed-off-by: David Dreschner <david.dreschner@nextcloud.com >
2026-03-13 10:43:38 +01:00
c8380b1b62
Merge pull request #58869 from nextcloud/fix/pwd-confirmation
2026-03-12 09:54:15 +01:00
9b54b06de5
fix(SecurityMiddleware): return header to distinguish error type
...
Currently we return a 403 (Forbidden) when the password confirmation
failed - which itself seems to be inappropriate as its basically a login
failing so a 401 (not authorized) is more appropriate.
This is especially a problem because APIs might return 403 internally
for good reason (e.g. user missing permission) but 401 would not be a
problem.
But as this is a breaking change so my solution to be able to
distinguish API error from password confirmation error is:
Add a header inside the response that marks failed password confirmation
`X-NC-Auth-NotConfirmed`.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-03-11 15:11:29 +01:00
91334643dc
fix(tests): Adapt Middleware tests to API change
...
Removed a few tests rendered obsolete by the refactoring.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-03-11 14:27:45 +01:00
447ee17759
fix: Remove code duplication by using the new method
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-03-11 11:36:01 +01:00
520878338f
fix: Move hasAnnotationOrAttribute to the reflector
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-03-11 11:16:26 +01:00
3e78bf662d
Merge pull request #58648 from nextcloud/feat/add-files-sharing-raw-to-rootUrlApps
...
feat(routing): add files_sharing_raw to rootUrlApps
2026-03-10 15:31:02 +01:00
cbe8e4d90f
fix: add fallback to raw path info
...
Follow up to https://github.com/nextcloud/server/pull/56843
The raw path info method has no fallback for an empty array parameter
Signed-off-by: Anna Larch <anna@nextcloud.com >
2026-03-09 22:22:08 +01:00
663018455e
refactor: Apply rector changes
...
Signed-off-by: GitHub <noreply@github.com >
2026-03-01 14:43:11 +00:00
b24663db93
feat(routing): add files_sharing_raw to rootUrlApps
...
- Registers the files_sharing_raw app as a root-URL app so that its routes are served under /raw/{token} and /rss instead of the default /apps/files_sharing_raw/... prefix.
This is required for the files_sharing_raw app to generate correct canonical raw URLs via PublicUrlBuilder.
Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com >
2026-02-28 20:30:19 +01:00
9dc1d6372f
fix(IContainer): Fix parameter and return types
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-16 10:45:13 +01:00
b80816dfb7
Merge pull request #58098 from nextcloud/fix/appframework/types-phpstan
...
fix(AppFramework): Adjust types so PHPStan understands them
2026-02-12 14:00:47 +01:00
5c47ce9b40
fix(SimpleContainer): Adjust return type for PHPStan
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-11 11:42:37 +01:00
e8d4d435ed
fix(IRegistrationContext): Use SimpleContainer in registerService factory
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-11 11:42:37 +01:00
97c09753c3
fix(AppFramework): Adjust types so PHPStan understands them
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-09 14:08:42 +01:00
f12cecb684
feat(rector): Enable SafeDeclareStrictTypesRector
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-09 10:59:31 +01:00
65e769a861
refactor: Apply comments
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:50:46 +01:00
7b6078875b
refactor: Run rector on lib/private
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:50:18 +01:00
f81475445d
refactor: Move hasAnnotationOrAttribute to MiddlewareUtils
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-01-28 21:48:16 +01:00
6408ed0b51
feat(AppFramework): Add missing NoSameSiteCookieRequired attribute
...
Allow to replace the old annotation.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-01-28 21:48:16 +01:00
b040fb1c73
feat(AppFramework): Add missing NoTwoFactorRequired attribute
...
It's in our documentation but was never implemented.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-01-28 21:48:16 +01:00
6af64a5495
feat(ocm): event on ocm discovery and ocm request
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2026-01-07 17:54:26 -01:00
f2e2e4ea21
fix(controller): Support native int ranges
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2026-01-07 17:36:57 +01:00
Côme Chilliet
Louis
Sebastian Hasler
Josh
Andy Scherzinger
Ferdinand Thiessen
Carl Schwan
Kate
Philip Renich
Carl Schwan
Joas Schilling
Benjamin Gaussorgues
David Dreschner
Raphael Gradenwitz
Anna Larch
nextcloud-command
provokateurin
Carl Schwan
Maxence Lange