e42fb08c6c
docs(Request): add/update/cleanup internal implementation docs
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:44 +02:00
0071a97f89
chore(RequestId): drop duplicate getId docblock from implementation
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:43 +02:00
6bcc618a1e
docs(Request): update implementation docblock properties
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:40 +02:00
f0f432c526
refactor(Request): drop docblocks already in IRequest
...
Oh and slighly refactor getHeader() since this was tied to some other work that lead to this cleanup.
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:37 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
d8b9c6d6a0
Merge branch 'master' into fix-ios-browsers
2026-05-06 14:37:51 +12:00
e0ba4d71b6
chore: add missing Override attribute to OC
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:27 +02:00
7ed9191493
fix(controller): Add default range to $limit parameter
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2026-04-13 14:45:32 +02:00
7f3b9356ca
fix: treat all WebKit iOS browseres the same
...
Signed-off-by: Philip Renich <hello@philiprenich.com >
2026-03-24 16:02:10 +13:00
5f80f26799
chore: Fix SPDX header
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2026-03-16 08:38:16 +01:00
cbe8e4d90f
fix: add fallback to raw path info
...
Follow up to https://github.com/nextcloud/server/pull/56843
The raw path info method has no fallback for an empty array parameter
Signed-off-by: Anna Larch <anna@nextcloud.com >
2026-03-09 22:22:08 +01:00
7b6078875b
refactor: Run rector on lib/private
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:50:18 +01:00
f81475445d
refactor: Move hasAnnotationOrAttribute to MiddlewareUtils
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-01-28 21:48:16 +01:00
6408ed0b51
feat(AppFramework): Add missing NoSameSiteCookieRequired attribute
...
Allow to replace the old annotation.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-01-28 21:48:16 +01:00
b040fb1c73
feat(AppFramework): Add missing NoTwoFactorRequired attribute
...
It's in our documentation but was never implemented.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-01-28 21:48:16 +01:00
cb80ec7ebb
feat(log): Add script name and occ command to log details
...
This will help when troubleshooting issues. For web request we have
method and url, but for cron and occ currently we have no way to know if
it’s one or the other and which command.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-12-04 15:04:59 +01:00
f720925b06
fix(AppFramework): Check for responder existence
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-11-12 09:39:53 +01:00
336cc3fa35
feat(Db): Use SnowflakeId for previews
...
Allow to get an id for the storing the preview on disk before inserting
the preview on the DB.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-10-28 17:50:03 +01:00
7bf8e9699c
fix(http): handle getHttpProtocol being unset in $_SERVER['SERVER_PROTOCOL'] if called from occ
...
Due to the profiler app loading HttpDataCollector when running occ.
Signed-off-by: Thomas Citharel <tcit@tcit.fr >
2025-09-21 18:06:33 +02:00
9473f47c0d
fix(Dispatcher): Catch TypeErrors and turn them into bad request responses
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-09-05 00:49:23 +02:00
aab11d35d3
fix(OCS): Add IRequest::getFormat to determine the response Content-Type the same way everywhere
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-08-26 09:50:03 +02:00
4829ac57c1
fix: use OCP\Server
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com >
2025-08-01 17:00:09 +02:00
14b4d0327e
fix(AppFramework): Log malformed protocol values and unify fallback behavior
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2025-08-01 17:00:09 +02:00
9913bdda90
chore: Cleanup DIContainer class
...
Also removed deprecated tag from the class as this class will not be
removed, only the interface IAppContainer and associated methods should
be removed.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-07-08 13:32:12 +02:00
79f4e0de76
fix: Only attempt to decode JSON input if it is not an empty string
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-07-01 11:24:27 +02:00
e8bc35ec0a
fix(ocs): Return a proper error on JSON decoding failures
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-07-01 10:45:31 +02:00
87f98c88ab
chore: Rename property and type it to match its current use in Request
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-07-01 10:25:14 +02:00
6951053c90
docs(dispatcher): Correct described return values
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2025-04-23 22:43:03 +02:00
1909b981a4
fix(controller): Fix false booleans in multipart/form-data
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-11-28 12:18:30 +01:00
dd0ed02b91
feat(Dispatcher): Add debug log for controller methods returning raw data not wrapped in Response
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-11-15 10:09:59 +01:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
c82b17d0a3
fix: Support Safari mobile
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-08-21 13:01:23 +02:00
9d1705259c
fix(AppFramework): Allow requests with OCS-APIRequest header to pass CSRF checks
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-07-25 17:31:49 +02:00
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-24 13:11:22 +02:00
672923f0a6
fix: Fix newly spotted psalm issues, add exhaustive typed magic properties for LDAP classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-30 09:23:58 +02:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-02 14:16:21 +02:00
b8c5bff673
fix: Adjust user agent pattern for Edge
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2024-03-08 12:11:46 +01:00
696ed4a125
fix(CS): Fix coding style
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-02-14 15:38:15 +01:00
c4684089a8
fix(request): Fix regex handling and coding-style
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-02-13 16:51:13 +01:00
ffcadf25d4
fix(request): Handle reverse proxy setting a port in Forwarded-For
...
Signed-off-by: Mikael Peigney <Mika56@users.noreply.github.com >
2024-02-13 16:51:13 +01:00
f73f966c98
chore: Add missing ArrayAccess template parameters
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-02-06 10:24:41 +01:00
85978593fe
Merge pull request #42794 from nextcloud/fix/invalid-trusted-proxies
...
fix(Request): Catch exceptions in `isTrustedProxy`
2024-01-29 16:19:51 +01:00
30ad530814
code style: ommited space, reverted [code review]
2024-01-27 15:11:26 +01:00
446ecbc454
fixing bug #6914 : Config Param 'overwritecondaddr' not working
...
- just ignoring/removing extra parameter 'protocol' as suggested by
blizzz
Signed-off-by: Pavel Kryl <pavel@kryl.eu >
2024-01-27 15:11:26 +01:00
7620d230df
fix(Request): Catch exceptions in isTrustedProxy
...
The function fails if the configured trusted proxies contain invalid characters and the underlying IpUtils will throw.
But as it is used by `getRemoteAddress` which is used by logging / templating, thrown errors are not reported but silently fail with error 500.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de >
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com >
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-01-27 14:59:51 +01:00
f6b6776c93
fix(API): Use a distinct exception so apps can react to it and customize the return
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2023-11-28 06:11:57 +01:00
3fa43a529b
enh(dispatcher): enforce psalm ranges in the http dispatcher
...
- allows devs to provide int ranges for API arguments
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2023-11-24 12:46:38 +01:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
2fa78f6245
Reverse X-Forwarded-For list to read the correct proxy remote address
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2023-11-16 07:45:19 +01:00
Josh
Côme Chilliet
Philip Renich
Ferdinand Thiessen
Joas Schilling
Anna Larch
Carl Schwan
Carl Schwan
provokateurin
Thomas Citharel
John Molakvoæ
Daniel Kesselberg
Andy Scherzinger
Julius Härtl
Mikael Peigney
Pavel Kryl
Arthur Schiwon