Commit Graph

2159 Commits

Author SHA1 Message Date
Git'Fellow 5dda39a61e refactor(dbal): move to modern calls
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-06-24 10:35:00 +02:00
Carl Schwan 0b9e592796 refactor: Soft remove Emitter from IRootFolder interface
Move this to the private implementation in OC, so that using IRootFolder
in apps doesn't require dummy stubs.

This will create a new psalm warnings for users of this method but
considering that this is deprecated for a long time and that it still
works at runtime, this shouldn't cause any issue.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-06-23 16:11:23 +02:00
Carl Schwan e6b5f763a4 perf: Avoid sorting an already sorted array
Improve performance a bit as this is in the hotpath and take ~2s in
prod.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-06-23 13:11:42 +02:00
Micke Nordin a88fdcbed5 Merge pull request #57234 from enriquepablo/master
Implement token exchange from OCM
2026-06-18 11:33:24 +02:00
Robin Appelman 61037332f0 Merge pull request #60988 from nextcloud/search-operator-params
chore: fix SearchBinaryOperator constructor type hint
2026-06-17 13:16:24 +02:00
Enrique Pérez Arnaud 3616212ba2 feat(files_sharing): store and refresh OCM access tokens for external shares
Co-authored-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Enrique Pérez Arnaud <enrique@cazalla.net>
2026-06-17 11:01:16 +02:00
Arthur Schiwon 437952bd70 fix: ensure file names are string-typed
- `$child` was used as an array key earlier. If they are numeric, they
  are automatically converted to ints, leading to type issues later.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2026-06-16 13:13:38 +02:00
Robin Appelman 09d6942c11 chore: fix SearchBinaryOperator constructor type hint
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-06-12 17:43:42 +02:00
Andy Scherzinger 2ab629fd1b Merge pull request #53464 from nextcloud/correctParentStorageMtime-id
fix: pass parent id to correctParentStorageMtime when known
2026-06-11 17:17:52 +02:00
Louis a8135190f3 Merge pull request #59916 from nextcloud/jtr/fix-MoveFromCacheTrait-hardening
fix(Files/Cache): align `MoveFromCacheTrait` fallback validation with `Cache::moveFromCache`
2026-06-11 10:28:15 +02:00
Louis 5e4abd734d Merge pull request #59984 from nextcloud/jtr/docs-lock-ILockManager-API
docs(lock): clarify ILockManager API documentation
2026-06-11 10:26:49 +02:00
Benjamin Gaussorgues 2b7415ef4d Merge pull request #60960 from nextcloud/carl/querybuilder-magic-number
refactor: Use new IQueryBuilder::MAX_IN_PARAMETERS
2026-06-10 23:09:30 +02:00
Robin Appelman bae156db12 fix: pass parent id to correctParentStorageMtime when known
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-06-10 18:24:52 +02:00
Cristian Scheid 3592f83218 Merge pull request #60844 from nextcloud/fix/noid/files-join-ext-cache-select-fields
feat(file-search): add property to SearchQuery and check select fields to decide wheter to join extended cache
2026-06-10 16:26:55 +02:00
Stephan Orbaugh ef87e2e564 Merge pull request #58676 from nextcloud/jail-wrapper-null-paths
fix: don't return cache entries with null paths
2026-06-09 17:25:34 +02:00
Stephan Orbaugh 52d322aac7 Merge pull request #58608 from nextcloud/chunked-write-error-logging
fix: improve logging around failed chunked object store uploads
2026-06-09 17:25:19 +02:00
Carl Schwan d6f7805ae7 refactor: Improve log message
Co-authored-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2026-06-09 10:45:48 +02:00
Robin Appelman ccb1d9afa7 fix: improve logging around failed chunked object store uploads
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-06-09 10:45:48 +02:00
Robin Appelman 76ce9556ce fix: don't return cache entries with null paths
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-06-09 10:45:18 +02:00
Robin Appelman 17a7a95553 perf: delay loading storage info in Cache untill needed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-06-09 10:42:20 +02:00
Robin Appelman 48dfc2be3a chore: psalm fix
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-06-08 15:40:03 +02:00
Stephan Orbaugh cc48ec4420 Merge pull request #58541 from nextcloud/carl/frankenphp
feat: frankenphp
2026-06-08 14:18:33 +02:00
Stephan Orbaugh d3b8521ee3 Merge pull request #60453 from nextcloud/jtr/fix-dav-put-bookkeeping-consistency
fix(dav): finalize upload metadata before post-write hooks
2026-06-08 14:16:51 +02:00
Carl Schwan 774420a188 fix(filesystem): reset static members during frankenphp invokations
Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-06-05 11:03:05 +02:00
Carl Schwan 994565fec7 refactor: Use new IQueryBuilder::MAX_IN_PARAMETERS
Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-06-03 13:45:29 +02:00
Ferdinand Thiessen ce3b3b7689 Merge pull request #60787 from nextcloud/jtr/fix-storage-dav-client-proxyexclude
fix(Storage): use `proxyexclude` parameter in DAV client
2026-06-02 18:02:04 +02:00
Côme Chilliet 9c92cc1617 chore: Suppress last known impure static properties
We will keep these legacy ones for now. We can search for the
 ImpureStaticProperty suppression and add special treatement for them in
 the frankenphp PR if needed.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-02 09:46:20 +02:00
Côme Chilliet 504a02b04e fix: Remove static property use in SeekableHttpStream
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-02 09:46:18 +02:00
Côme Chilliet 9d7c277668 fix: Remove static vars in trashbin, versions and storages
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-02 09:46:16 +02:00
Côme Chilliet 1ab09ec753 chore: Apply new coding standard to all files
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-01 13:46:39 +02:00
Cristian Scheid 476a6f0774 feat(file-search): add property to SearchQuery and check select fields to decide wheter to join extended cache
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
2026-05-29 15:37:03 -03:00
Josh a494fcd2c6 chore(DAV): fixup proxyexclude default value check
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
2026-05-29 11:41:33 -04:00
Josh d68a7f0d94 chore(DAV): fixup for lint
Signed-off-by: Josh <josh.t.richards@gmail.com>
2026-05-29 11:41:33 -04:00
Josh 277154396f fix(Storage): use proxyexclude parameter in DAV client
Signed-off-by: Josh <josh.t.richards@gmail.com>
2026-05-29 11:41:33 -04:00
provokateurin b1724dbad0 chore(Cache): Remove deprecated insert and update events
Signed-off-by: provokateurin <kate@provokateurin.de>
2026-05-28 14:02:08 +02:00
nextcloud-command fd14234a6a refactor: Apply rector changes
Signed-off-by: GitHub <noreply@github.com>
2026-05-24 14:56:18 +00:00
Josh fff2a542ba chore(FileInfo): fixup code typo
Signed-off-by: Josh <josh.t.richards@gmail.com>
2026-05-18 08:40:31 -04:00
Josh 92a28290a3 fix(FileInfo): harden getChecksum()
- `checksum` is already optional/derived metadata in practice
- callers already treat `null`l / `''` as "no checksum"

Signed-off-by: Josh <josh.t.richards@gmail.com>
2026-05-18 08:35:20 -04:00
Benjamin Gaussorgues 91a4172e35 Merge pull request #60225 from nextcloud/remove-cache-order
perf: remove unneeded sort in getFolderContentsById
2026-05-13 16:49:24 +02:00
John Molakvoæ ee602dcfe4 fix: adjust wording in S3ConnectionTrait comment
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2026-05-12 09:07:20 +02:00
John Molakvoæ (skjnldsv) c26b1e4b07 fix(s3): add Content-MD5 header for DeleteObjects to fix AWS SDK v3.339.0+ compatibility
AWS SDK PHP v3.339.0+ introduced a breaking change requiring the Content-MD5
header for DeleteObjects operations. This causes 'MissingContentMD5' errors when
using S3-compatible services like MinIO.

Add middleware to automatically calculate and inject the Content-MD5 header on
all DeleteObjects requests. This is applied universally at the S3ConnectionTrait
level, fixing both external storage (AmazonS3) and core ObjectStore (S3) classes.

Fixes: https://github.com/aws/aws-sdk-php/issues/3068
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2026-05-12 09:07:20 +02:00
Carl Schwan 23447f1ec1 fix: Uploading files not chuncked
Co-authored-by: David Dreschner <david.dreschner@nextcloud.com>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-05-08 11:47:16 +02:00
Carl Schwan 8850c29505 fix: Check if it is deletable and updatable
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2026-05-08 11:47:16 +02:00
Carl Schwan 06f0765e19 fix: Fix permission issue when uploading a chunked file
Follow up from #59511

Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-05-08 11:47:16 +02:00
Robin Appelman 06c625f20c perf: remove unneeded sort in getFolderContentsById
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-05-07 17:40:19 +02:00
Benjamin Gaussorgues aa797a36f1 Merge pull request #59995 from nextcloud/quota-writestream-fopen 2026-05-04 10:06:18 +02:00
Robin Appelman 9f5535d01b fix: apply quota with writeStream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-05-02 14:04:09 +02:00
Robin Appelman f3a5bc8c17 fix: block writing empty files with 0 quota
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-05-02 14:04:09 +02:00
Robin Appelman 6a316b23b5 fix: chunk storage ids when preload storage info
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-05-02 14:04:01 +02:00
Git'Fellow 3bbe0ee570 refactor: use strict operator
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2026-04-30 00:51:29 +02:00