3616212ba2
feat(files_sharing): store and refresh OCM access tokens for external shares
...
Co-authored-by: Micke Nordin <kano@sunet.se >
Signed-off-by: Micke Nordin <kano@sunet.se >
Signed-off-by: Enrique Pérez Arnaud <enrique@cazalla.net >
2026-06-17 11:01:16 +02:00
48dfc2be3a
chore: psalm fix
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-06-08 15:40:03 +02:00
ce3b3b7689
Merge pull request #60787 from nextcloud/jtr/fix-storage-dav-client-proxyexclude
...
fix(Storage): use `proxyexclude` parameter in DAV client
2026-06-02 18:02:04 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
a494fcd2c6
chore(DAV): fixup proxyexclude default value check
...
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com >
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-05-29 11:41:33 -04:00
d68a7f0d94
chore(DAV): fixup for lint
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-05-29 11:41:33 -04:00
277154396f
fix(Storage): use proxyexclude parameter in DAV client
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-05-29 11:41:33 -04:00
23447f1ec1
fix: Uploading files not chuncked
...
Co-authored-by: David Dreschner <david.dreschner@nextcloud.com >
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-05-08 11:47:16 +02:00
8850c29505
fix: Check if it is deletable and updatable
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2026-05-08 11:47:16 +02:00
06f0765e19
fix: Fix permission issue when uploading a chunked file
...
Follow up from #59511
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-05-08 11:47:16 +02:00
9f5535d01b
fix: apply quota with writeStream
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-05-02 14:04:09 +02:00
f3a5bc8c17
fix: block writing empty files with 0 quota
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-05-02 14:04:09 +02:00
e0ba4d71b6
chore: add missing Override attribute to OC
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:27 +02:00
1b0410f333
fix(Wrapper): Type $storage as IStorage
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-04-14 16:09:12 +02:00
5d1e0a6e3a
fix(Wrapper): Always use getWrapperStorage()
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-04-14 16:08:37 +02:00
e96a89e630
feat: add permissions mask variant that only masks one directory
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-04-09 16:19:10 +02:00
cd2d09de64
fix: Remove static vars from core classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-03-23 16:34:54 +01:00
17ef1dbec9
Merge pull request #58808 from nextcloud/carl/remove-many-get-server
...
refactor: remove long deprecated IServerContainer methods
2026-03-10 15:00:48 +01:00
39c14c383b
refactor: remove long deprecated IServerContainer methods
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-03-10 10:36:35 +01:00
8b235c8f49
fix(files_sharing): respect config to skip certificate verification
...
This is important especially for local development, as certificate are
self-signed.
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com >
2026-03-09 18:21:15 +01:00
3f19e137e4
fix: correctly return false for filesize on non-existing file
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-02-24 15:46:03 +01:00
4eada2d804
refactor(Files): Modernize Wrapper
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-17 06:43:16 +01:00
5f4a5d8c67
refactor(Files): Remove deprecated streamCopy method
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-17 06:43:16 +01:00
c953ad9bcd
fix(Storage): Use correct return types for getMetaData and getDirectoryContent
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-17 06:43:16 +01:00
f12cecb684
feat(rector): Enable SafeDeclareStrictTypesRector
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-09 10:59:31 +01:00
3979c493f9
refactor: Apply second batch of comments
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:52:51 +01:00
7b6078875b
refactor: Run rector on lib/private
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:50:18 +01:00
b933156a3a
Merge pull request #57914 from nextcloud/feat/extendable-propfind
...
feat(dav): allow extending propfind properties via event
2026-02-05 10:49:59 +01:00
9d4b11587e
feat(dav): allow extending propfind properties via event
...
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com >
Update lib/public/Files/Events/BeforePropfindEvent.php
Co-authored-by: Julius Knorr <jus@bitgrid.net >
Signed-off-by: Benjamin Früh <134610227+benjaminfrueh@users.noreply.github.com >
Update lib/public/Files/Events/BeforePropfindEvent.php
Co-authored-by: Julius Knorr <jus@bitgrid.net >
Signed-off-by: Benjamin Früh <134610227+benjaminfrueh@users.noreply.github.com >
refactor: rename BeforePropfindEvent to BeforeRemotePropfindEvent
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com >
chore: update composer autoloader for new event class
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com >
Update lib/public/Files/Events/BeforeRemotePropfindEvent.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com >
Signed-off-by: Benjamin Früh <134610227+benjaminfrueh@users.noreply.github.com >
2026-02-02 11:45:10 +01:00
080335009b
refactor: use strict comparison operator
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
2026-01-28 21:11:47 +01:00
3c80b7f2b3
fix: Use strict array comparisons in lib/
...
To avoid surprises with corner cases.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-01-13 11:48:04 +01:00
5c625b7a07
feat: add an option to filter what paths get checked for updates
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-12-31 12:23:04 +01:00
b6313f68d3
perf(s3): Expose pre-signed urls for S3
...
This is faster than going back to nextcloud to download the files.
This is an opt-in setting that can be enabled by setting
use_presigned_url in the object store config.
Additionally add support for the proxy config which is needed in a
docker setup. See https://github.com/juliusknorr/nextcloud-docker-dev/pull/431
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-12-09 11:21:35 +01:00
30d567fd0e
fix(encryption): Increment lastChunkNr when size is off
...
When computing the unencrypted file size, we need the size of the last encrypted chunk as its size is usually not the regular 8192 bits.
To avoid reading the whole file, we seek directly to that last chunk based on the expected file size. When the expected file size is smaller than the actual one, we have a logic in place to continue reading until we reach the end of the file.
In that logic, we forgot to increment the `$lastChunkNr` which is important when we later check the signature of the chunk.
This commit adds that missing increment.
Signed-off-by: Louis Chmn <louis@chmn.me >
2025-11-21 17:34:19 +01:00
17104bf3a0
chore: better type hints for getAvailability
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-11-06 20:09:17 +01:00
2970232790
fix: make failed availability check apply in the same request
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-11-06 20:08:44 +01:00
475c84722f
refactor(IPropagator): Cleanup implementation
...
- Add missing type hinting
- Use only public methods from IStorage instead of relying on internal
\OC\Storage methods
- Refactor HomePropagator to use ignore argument from Propagator instead
of reimplementing the same logic.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-10-08 17:15:18 +02:00
34cd91cc86
refactor: Fix some easy psalm issues in Files
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-10-02 13:34:47 +02:00
ef279f6049
fix(files): Stop overwriting scan_permissions
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-09-28 14:11:47 +02:00
660f3f6fd1
refactor: use logical && || instead of weak and or operators
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-09-27 23:02:18 +02:00
14d6945054
fix(encryption): Take encryption enabled status into account
...
shouldEncrypt now returns false for all paths if encryption is disabled.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:18 +02:00
12532bb535
fix(encryption): Correctly set encrypted to 0 when copying
...
If encryption got disabled, copying should set encrypted to 0 for the
new unencrypted copy. For instance when using encryption:decrypt-all
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:18 +02:00
8c21f2b19c
fix(encryption): Fix TypeError when trying to decrypt unencrypted file
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-08-25 13:18:50 +02:00
4eee160c15
Merge pull request #53729 from nextcloud/dav-external-url-encoded-root
2025-08-01 09:31:14 +02:00
4427050f84
fix(encryption): Correctly handle file opening and copying failures
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-07-03 15:19:34 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
6d0119bf8d
fix: handle dav external storage roots with spaces
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-06-30 18:01:01 +02:00
de54bdb06b
fix: handle ambiguous IResponse.getBody return types
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2025-06-30 11:50:11 +02:00
01db539d0a
chore: move streamCopy implementation from OC_Helper to OCP\Files
...
The function was already there but called the legacy version.
So moved the implementation and migrated all usages of it.
Sadly the interface was slightly different so adjusted it to be
compatible with both legacy and the OCP one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-05-16 13:03:05 +02:00
b3b63020c9
Merge pull request #52812 from nextcloud/chore/oc-helper-rmdirr
2025-05-14 21:53:47 +02:00
Enrique Pérez Arnaud
Robin Appelman
Ferdinand Thiessen
Côme Chilliet
Josh
Carl Schwan
Carl Schwan
provokateurin
Côme Chilliet
Salvatore Martire
Carl Schwan
Julius Knorr
Benjamin Frueh
Git'Fellow
Carl Schwan
Louis Chmn
John Molakvoæ
Daniel Kesselberg