48dfc2be3a
chore: psalm fix
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-06-08 15:40:03 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
23447f1ec1
fix: Uploading files not chuncked
...
Co-authored-by: David Dreschner <david.dreschner@nextcloud.com >
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-05-08 11:47:16 +02:00
8850c29505
fix: Check if it is deletable and updatable
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2026-05-08 11:47:16 +02:00
06f0765e19
fix: Fix permission issue when uploading a chunked file
...
Follow up from #59511
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-05-08 11:47:16 +02:00
9f5535d01b
fix: apply quota with writeStream
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-05-02 14:04:09 +02:00
f3a5bc8c17
fix: block writing empty files with 0 quota
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-05-02 14:04:09 +02:00
e0ba4d71b6
chore: add missing Override attribute to OC
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:27 +02:00
1b0410f333
fix(Wrapper): Type $storage as IStorage
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-04-14 16:09:12 +02:00
5d1e0a6e3a
fix(Wrapper): Always use getWrapperStorage()
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-04-14 16:08:37 +02:00
e96a89e630
feat: add permissions mask variant that only masks one directory
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-04-09 16:19:10 +02:00
4eada2d804
refactor(Files): Modernize Wrapper
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-17 06:43:16 +01:00
5f4a5d8c67
refactor(Files): Remove deprecated streamCopy method
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-17 06:43:16 +01:00
7b6078875b
refactor: Run rector on lib/private
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:50:18 +01:00
b6313f68d3
perf(s3): Expose pre-signed urls for S3
...
This is faster than going back to nextcloud to download the files.
This is an opt-in setting that can be enabled by setting
use_presigned_url in the object store config.
Additionally add support for the proxy config which is needed in a
docker setup. See https://github.com/juliusknorr/nextcloud-docker-dev/pull/431
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-12-09 11:21:35 +01:00
30d567fd0e
fix(encryption): Increment lastChunkNr when size is off
...
When computing the unencrypted file size, we need the size of the last encrypted chunk as its size is usually not the regular 8192 bits.
To avoid reading the whole file, we seek directly to that last chunk based on the expected file size. When the expected file size is smaller than the actual one, we have a logic in place to continue reading until we reach the end of the file.
In that logic, we forgot to increment the `$lastChunkNr` which is important when we later check the signature of the chunk.
This commit adds that missing increment.
Signed-off-by: Louis Chmn <louis@chmn.me >
2025-11-21 17:34:19 +01:00
2970232790
fix: make failed availability check apply in the same request
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-11-06 20:08:44 +01:00
475c84722f
refactor(IPropagator): Cleanup implementation
...
- Add missing type hinting
- Use only public methods from IStorage instead of relying on internal
\OC\Storage methods
- Refactor HomePropagator to use ignore argument from Propagator instead
of reimplementing the same logic.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-10-08 17:15:18 +02:00
34cd91cc86
refactor: Fix some easy psalm issues in Files
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-10-02 13:34:47 +02:00
ef279f6049
fix(files): Stop overwriting scan_permissions
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-09-28 14:11:47 +02:00
660f3f6fd1
refactor: use logical && || instead of weak and or operators
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-09-27 23:02:18 +02:00
14d6945054
fix(encryption): Take encryption enabled status into account
...
shouldEncrypt now returns false for all paths if encryption is disabled.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:18 +02:00
12532bb535
fix(encryption): Correctly set encrypted to 0 when copying
...
If encryption got disabled, copying should set encrypted to 0 for the
new unencrypted copy. For instance when using encryption:decrypt-all
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:18 +02:00
8c21f2b19c
fix(encryption): Fix TypeError when trying to decrypt unencrypted file
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-08-25 13:18:50 +02:00
4427050f84
fix(encryption): Correctly handle file opening and copying failures
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-07-03 15:19:34 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
01db539d0a
chore: move streamCopy implementation from OC_Helper to OCP\Files
...
The function was already there but called the legacy version.
So moved the implementation and migrated all usages of it.
Sadly the interface was slightly different so adjusted it to be
compatible with both legacy and the OCP one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-05-16 13:03:05 +02:00
a86d917907
fix(encryption): Only prevent cache deletion if target is not object store in moveFromStorage
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-05-13 23:37:52 +02:00
a79b5dea7c
fix(encryption): Improve Update class and event listenening
...
to avoid back&forth between path and Node object
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-05-13 23:37:52 +02:00
e6275f8759
fix: Preserve file id when moving from object store even if encryption wrapper is present
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-05-13 23:37:52 +02:00
9bb0721d66
fix: Fix mtime preservation when moving a directory across storages with encryption registered
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-05-13 23:37:52 +02:00
8779ae38a4
fix(encryption): Fix filesize for part files in Encryption wrapper
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-05-13 23:37:52 +02:00
768b101a9d
Merge pull request #52706 from nextcloud/info-file-more-encryption-checks
...
feat: add more encryption checks to info:file
2025-05-12 13:17:26 +02:00
e6bdfcd8ed
Merge pull request #52665 from nextcloud/mountpoint-mkdir-quota
...
fix: create mountpoint folder even if the user has a quota of 0
2025-05-12 13:17:02 +02:00
b0b8159d6a
fix: throw a better error if we can't get the encrypted header size
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-05-09 22:33:45 +02:00
d9c53ef748
feat: add more encryption checks to info:file
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-05-09 16:35:31 +02:00
cd75876c1e
fix: create mountpoint folder even if the user has a quota of 0
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-05-08 15:15:36 +02:00
012a402cec
fix: restore updated encrypted version when copying versions
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-01-03 15:21:01 +01:00
27331d48e3
Merge pull request #48651 from nextcloud/artonge/fix/copy_cache_during_copy_operations
...
fix(files): Correctly copy the cache information during copy operations
2024-12-04 16:58:01 +01:00
ae30269eac
fix: don't set 'name' on null metadata
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-12-03 19:12:45 +01:00
199b0bd4d9
fix(files): Correctly copy the cache information on copy operations
...
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.
Signed-off-by: Louis Chemineau <louis@chmn.me >
2024-12-03 17:04:44 +01:00
60d956f39f
refactor(storage): Code adjustements and simplifications
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
2024-11-21 10:02:00 +01:00
0de4843b73
refactor(Storage): Align all Storage constructors
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-23 13:24:18 +02:00
43b1fd7bb8
Merge pull request #48623 from nextcloud/fix/allow-quota-wrapper-check
2024-10-09 18:39:42 +02:00
75381dfe0c
fix: Allow overriding shouldApplyQuota check from child classes
...
Signed-off-by: Julius Knorr <jus@bitgrid.net >
2024-10-09 08:25:30 +02:00
f28e74b7a8
refactor(Storage): Make all parameter types strong types
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-07 15:00:05 +02:00
4412b2b8a8
refactor(Wrapper\Encryption): Migrate to strong types
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-07 14:11:56 +02:00
e1998b6b6c
fix(Storage): Fix getDirectoryContent() return type
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-30 16:49:27 +02:00
7cdccd058f
fix(Storage): Fix IStorage return types
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-26 18:13:03 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
Robin Appelman
Côme Chilliet
Carl Schwan
Carl Schwan
Ferdinand Thiessen
provokateurin
Carl Schwan
Carl Schwan
Louis Chmn
Git'Fellow
Kate
Julius Knorr