e6b5f763a4
perf: Avoid sorting an already sorted array
...
Improve performance a bit as this is in the hotpath and take ~2s in
prod.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-23 13:11:42 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
680ddd93c2
fix(Scanner): Remove high level transaction during scans
...
Signed-off-by: Louis Chmn <louis@chmn.me >
2026-04-08 14:34:45 +02:00
72812b2b07
chore(Scanner): Use modern syntax and APIs
...
Signed-off-by: Louis Chmn <louis@chmn.me >
2026-04-08 12:26:55 +02:00
3d18cd7cc5
fix(preview): Fix files:app-data-scan for previews
...
And add unit tests for both migrated files and non-migrated files
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-02-12 00:26:20 +01:00
3979c493f9
refactor: Apply second batch of comments
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:52:51 +01:00
7b6078875b
refactor: Run rector on lib/private
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:50:18 +01:00
660f3f6fd1
refactor: use logical && || instead of weak and or operators
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-09-27 23:02:18 +02:00
809d638c05
fix: make early check if users filesystem have a mountpoint at /<user>/files/
...
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com >
2025-08-01 09:31:50 +02:00
bb4cf2830a
fix: better error message when trying to scan a folder that is already being scanned
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-04-25 18:40:03 +02:00
1e28657093
fix(PathHelper): Remove null bytes when normalizing path
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-01-13 15:21:21 +01:00
54a1ca0da0
fix: don't skip scanner users filesystem if they have a mountpoint at /<user>/files/
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-12-27 15:18:09 +01:00
7cdccd058f
fix(Storage): Fix IStorage return types
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-26 18:13:03 +02:00
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-24 13:11:22 +02:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-02 14:16:21 +02:00
45eb4a839d
Refactor OC\Server::getLockingProvider
...
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com >
2024-03-15 13:11:33 +01:00
3066687c7d
Merge branch 'master' into background-scan-catch-storage-error
2024-01-31 19:42:58 +01:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
a8e6d89d3b
continue background scanning different storages if one fails
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-10-20 16:31:48 +02:00
292c0e53f8
add summary of detected changes to files:scan output
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-06-16 17:56:34 +02:00
e7cc7653b8
Refactors "strpos" calls in lib/private to improve code readability.
...
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com >
2023-05-15 15:17:19 +03:30
54f61352f0
better error messages if the users home is not writable during scanning
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-04-05 13:21:30 +02:00
700444e218
split out some path manipulation logic
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2022-04-04 15:40:12 +02:00
6be7aa112f
Migrate from ILogger to LoggerInterface in lib/private
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-03-24 16:21:25 +01:00
9476ce70ed
Removes misleading error message in occ files:scan for new users.
...
Previously the occ files:scan command printed an error message for any
new users without any files/folders in the data directory.
With this change only users with any file/folder is scanned.
This fixes #25433 .
Signed-off-by: Christian Paier <hallo+git@cpaier.com >
2022-02-05 23:54:56 +01:00
f5fe887b4b
background scan the source storage when a background scan on a storage jail is triggered
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2021-12-02 17:34:58 +01:00
67ebe75d0e
Move storage encoding compatibility warning logic
...
The encoding check for file names is now happening the Scanner, and an
event will be emitted only if the storage doesn't contain the encoding
compatibility wrapper.
The event is listened to by the occ scan command to be able to display a
warning in case of file name mismatches when they have NFD encoding.
Signed-off-by: Vincent Petry <vincent@nextcloud.com >
2021-11-17 09:24:13 +01:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com >
2021-06-04 22:02:41 +02:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-12-16 18:48:22 +01:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 16:54:27 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 14:19:56 +02:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-26 16:34:56 +01:00
1b46621cd3
Update license headers for 18
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2019-12-20 09:23:25 +01:00
b81b824da1
Add typed events for the filesystem/scanner
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2019-12-13 09:41:05 +01:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2019-12-05 15:38:45 +01:00
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-11-22 20:52:10 +01:00
5e940366c2
Do scan the root storage in background scan
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2018-07-24 14:15:27 +02:00
b9e685236f
Add option to only scan the home storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2018-06-28 16:09:25 +02:00
21b9ad3978
feat: allow files:scan --shallow
...
Signed-off-by: Yuze Chi <i@blaok.me >
2018-05-18 14:50:32 -07:00
eb51f06a3b
Use ::class statement instead of string
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-01-29 12:03:47 +01:00
0eebff152a
Update license headers
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2017-11-06 16:56:19 +01:00
0721a7d5cc
Fix scanner after review
2017-04-26 13:26:47 +02:00
e3218ddffd
OCC scanner commit in batches
2017-04-26 13:26:27 +02:00
a0e5107c0b
check for existence before we start the db transaction
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2017-04-20 13:25:49 +02:00
fbedea0807
Add PHPDoc and handle exception in ScanAppData as well
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2017-04-19 17:04:16 -05:00
ce2dba0796
show error when trying to scan non existing path
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2017-04-19 14:36:38 +02:00
cbebfaaf2b
Skip FailedStorage in background scan
...
The background job that scans storages must skip failed storages to
avoid potential exceptions, especially when the failed storage comes
from a shared storage where the source is not accessible.
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2017-03-17 00:06:48 -06:00
00b17c3af5
Only check for local shared storages
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-01-10 16:14:21 +01:00
706655ef20
Skip local shares in bkg scan and occ files:scan ( #26590 )
...
Local shares should only be scanned when doing it for the owner to
avoid repeatedly rescanning the same shared storage over and over again
for every recipient.
2017-01-10 16:11:45 +01:00
412b5c5407
Store the shared propagator instance
...
This instead of recreating it for every call.
2016-08-10 10:57:49 +02:00
Carl Schwan
Côme Chilliet
Louis Chmn
Carl Schwan
Ferdinand Thiessen
Maksim Sukharev
Robin Appelman
provokateurin
Andy Scherzinger
Andrew Summers
Joas Schilling
Faraz Samapoor
Christian Paier
Vincent Petry
John Molakvoæ (skjnldsv)
Christoph Wurst
Roeland Jago Douma
Blaok
Morris Jobke
Vincent Petry