5dda39a61e
refactor(dbal): move to modern calls
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-24 10:35:00 +02:00
994565fec7
refactor: Use new IQueryBuilder::MAX_IN_PARAMETERS
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-03 13:45:29 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
e0ba4d71b6
chore: add missing Override attribute to OC
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:27 +02:00
7b6078875b
refactor: Run rector on lib/private
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:50:18 +01:00
f4b4cb5493
Revert "feat(group): Sanitize group names and ids on creation"
2025-11-07 10:37:50 +01:00
989011766e
feat(group): Sanitize group names and ids on creation
...
It does not make sense to allow group name with weird white space sequence going forward.
Same for group ids, in which we do not really want white space.
Signed-off-by: Louis Chmn <louis@chmn.me >
2025-11-05 18:31:38 +01:00
89a2cae40d
fix: join accounts_data instead of preferences when searching users
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com >
2025-10-23 08:59:10 +02:00
c4e6fbdae7
fix(query-builder): Don't catch UniqueConstraintViolationException
...
UniqueConstraintViolationException is no longer throw directly but
instead is now wrapped inside a \OCP\DB\Exception. So check the
exception reason.
Signed-off-by: Carl Schwan <carl.schwan@nextclound.com >
2025-09-02 11:55:58 +02:00
c21b8169ff
refactor(querybuilder): Port away from qb::execute() in lib/
...
Replace by either executeStatement or executeQuery
Signed-off-by: Carl Schwan <carl.schwan@nextclound.com >
2025-09-02 11:55:56 +02:00
77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-11-05 09:58:11 +01:00
c254855222
chore(db): Correctly apply query types
...
fix: psalm
fix: error
fix: add batch
fix: fatal error
fix: add batch
chore: add batch
chore: add batch
fix: psalm
fix: typo
fix: psalm
fix: return bool
fix: revert Manager
2024-10-17 09:21:07 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
4776b6600a
fix: Ensure database connection is setup when getting group details
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-08-06 13:41:04 +02:00
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-24 13:11:22 +02:00
7a6b1f8ae8
fix(groups): allows to save group names with more than 64 characters
...
Mimic behaviour from LDAP users and add a hard limit to 255 characters
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2024-04-22 15:26:55 +02:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-02 14:16:21 +02:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
d18bb7e9bb
Build query once instead of in-loop
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-09-07 17:07:47 +02:00
35069ad86a
Fix psalm spotted type errors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-09-05 16:56:48 +02:00
2c8b415c55
Move new methods to a new interface in OCP
...
This avoids breaking compatibility for group backends not based on
ABackend abstract class.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-09-05 16:56:48 +02:00
3270b7f12e
Add batch methods in user backends
...
This allows for faster group search with significantly less DB traffic
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2023-09-05 16:56:47 +02:00
4a86487859
fix: getGroups limit check syntax
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com >
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com >
2023-05-11 17:30:04 +02:00
7ad3574d71
also update groupinterface and database backend
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-05-11 17:30:03 +02:00
b6c17c6ce7
Clear up return types
...
usersInGroup index by int for BC, searchInGroup index by uid (string).
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-04-27 12:00:45 +02:00
a4c599c1c9
Split new method in a new group backend interface
...
Better for backward compatibility, also move new interfaces to nc 26
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2023-04-27 12:00:01 +02:00
35dc223500
Optimize retrieving display name when searching for users in a group
...
This is recurrent scenario that we are searching for users and then for
each users we fetch the displayName. This is inefficient, so instead try
to do one query to fetch everything (e.g. Database backend) or use the
already existing DisplayNameCache helper.
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2023-04-27 11:57:45 +02:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-01-20 11:45:08 +01:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com >
2021-06-04 22:02:41 +02:00
23dbbca1a0
Fix indentation error
...
Signed-off-by: tgrant <tom.grant760@gmail.com >
2021-03-17 23:04:15 +00:00
f1710b57bc
Fix null displayname crash as described in #21885
...
Signed-off-by: tgrant <tom.grant760@gmail.com >
2021-03-17 23:04:15 +00:00
2796ef80ff
Show group backends in occ group:list --info and group:info
...
Signed-off-by: Johannes Leuker <j.leuker@hosting.de >
2021-03-01 16:02:08 +01:00
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2021-01-08 11:45:19 +01:00
fee13e7ffd
Search also the email and displayname in user mangement for groups
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2020-08-05 14:14:05 +02:00
a636aef585
Allow group search by display name
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-06-10 11:44:07 +02:00
5ebb53593c
Improve group queries
...
Before we'd also get the diplayname for each group in the backend. In a
separate query. This is of course not ideal as this information is
obtained on each and every query. Now this is queried once and properly
cached.
Also added more caching to the manager.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2020-05-02 10:13:37 +02:00
734c62bee0
Format code according to PSR2
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 16:56:50 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 14:19:56 +02:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-09 16:07:47 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-09 13:54:22 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-09 10:16:08 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-31 14:52:54 +02:00
df9e2b828a
Fix mismatching docblock return types
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-06 16:38:25 +01:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2019-12-05 15:38:45 +01:00
62399c76e8
Allow group displaynames in the database backend ( #17221 )
...
Allow group displaynames in the database backend
2019-10-05 18:34:14 +02:00
6db51324fa
Fix DB usersInGroups fetching
...
* Follow the interface defaults
* Only set limit or offset if they are properly set
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-10-02 09:43:35 +02:00
b9f963225f
Do not allow to have an empty display name
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2019-09-27 14:29:57 +02:00
00859f46f3
Fix DI issue
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2019-09-27 14:29:56 +02:00
a54ff49c6b
Remove inherited docs
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2019-09-27 14:29:56 +02:00
653628c8fb
Allow to set the group display name in the database backend
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2019-09-27 14:29:56 +02:00
Git'Fellow
Carl Schwan
Côme Chilliet
Ferdinand Thiessen
Carl Schwan
Arthur Schiwon
Louis Chmn
skjnldsv
Carl Schwan
provokateurin
Daniel Kesselberg
Andy Scherzinger
Benjamin Gaussorgues
Joas Schilling
Carl Schwan
John Molakvoæ
Robin Appelman
Tom Grant
tgrant
Johannes Leuker
Christoph Wurst
Morris Jobke
Roeland Jago Douma