Carl Schwan
e02fa796c3
fix(preview): Do not recreate preview folder in filecache after cleanup
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-09 11:14:39 +02:00
Carl Schwan
d6f7805ae7
refactor: Improve log message
...
Co-authored-by: Josh <josh.t.richards@gmail.com >
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2026-06-09 10:45:48 +02:00
Robin Appelman
ccb1d9afa7
fix: improve logging around failed chunked object store uploads
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-06-09 10:45:48 +02:00
Robin Appelman
76ce9556ce
fix: don't return cache entries with null paths
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-06-09 10:45:18 +02:00
Robin Appelman
17a7a95553
perf: delay loading storage info in Cache untill needed
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-06-09 10:42:20 +02:00
Joas Schilling
b1e77f4294
fix(comments): Use capped memory cache for comments
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2026-06-09 07:17:59 +02:00
Andy Scherzinger
d3229157ba
Merge pull request #61071 from nextcloud/test-db-cleanup
...
test: cleanup users before userbackend test
2026-06-08 18:01:29 +02:00
Ferdinand Thiessen
6e44f30652
fix(comments): load comments styles when the comments app is loaded
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-06-08 16:51:56 +02:00
Robin Appelman
48dfc2be3a
chore: psalm fix
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-06-08 15:40:03 +02:00
Robin Appelman
775c1848b7
test: don't trigger file cache gc during tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-06-08 15:38:32 +02:00
Robin Appelman
a5ba481653
feat: allow unregistering group backends
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-06-08 15:35:07 +02:00
Carl Schwan
fc4938c3ed
fix(preview): Better handle errors while migrating previews
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-08 14:44:01 +02:00
Carl Schwan
c00f82aa82
fix(preview): Don't reuse same query builder for delete query
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-08 14:44:01 +02:00
Stephan Orbaugh
8ce1c9ae33
Merge pull request #61055 from nextcloud/fix/navigation
...
fix(NavigationManager): resolve entries only when needed
2026-06-08 14:37:34 +02:00
Stephan Orbaugh
cc48ec4420
Merge pull request #58541 from nextcloud/carl/frankenphp
...
feat: frankenphp
2026-06-08 14:18:33 +02:00
Stephan Orbaugh
d3b8521ee3
Merge pull request #60453 from nextcloud/jtr/fix-dav-put-bookkeeping-consistency
...
fix(dav): finalize upload metadata before post-write hooks
2026-06-08 14:16:51 +02:00
Stephan Orbaugh
3ab181d0d2
Merge pull request #60470 from nextcloud/jtr/docs-ITemplateManager
...
docs(templates): fully document ITemplateManager
2026-06-08 14:16:01 +02:00
Josh
57110aa0b9
chore(IRequest): lint/cs fixup
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:45 +02:00
Josh
e42fb08c6c
docs(Request): add/update/cleanup internal implementation docs
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:44 +02:00
Josh
9f8aee6e3c
docs(IRequestId): update to consistency with wrapped call in IRequest
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:43 +02:00
Josh
0071a97f89
chore(RequestId): drop duplicate getId docblock from implementation
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:43 +02:00
Josh
048fda26fd
docs(IRequest): update remaining method docblocks for accuracy and clarity
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:42 +02:00
Josh
4d1e20780b
docs(IRequest): improve same-site cookie method docblocks
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:42 +02:00
Josh
188d513a89
docs(IRequest): minor wording improvements to some of the simpler retriever methods
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:41 +02:00
Josh
755315565a
docs(IRequest): correct inaccuracies and improve clarity of request parameter set methods
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:41 +02:00
Josh
fb3f66ba2f
docs(IRequest): add missing magic properties to docblock
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:40 +02:00
Josh
6bcc618a1e
docs(Request): update implementation docblock properties
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:40 +02:00
Josh
ebdb684cfc
docs(IRequest): improve the accuracy and clarity class docblock
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:39 +02:00
Josh
f0f432c526
refactor(Request): drop docblocks already in IRequest
...
Oh and slighly refactor getHeader() since this was tied to some other work that lead to this cleanup.
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:37 +02:00
Josh
a7de91c44f
docs(IRequest): add/update based on implementation
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-06-08 11:36:15 +02:00
Ferdinand Thiessen
1b4243f5a3
fix(NavigationManager): resolve entries only when needed
...
The `init` method previously contained two different logics:
1. It set up the internal state of default apps and app order
2. It resolved the app navigation entries
The 1. is needed before `add` can be called, so it was always called by
the `add` method, but this also resolved all appinfo.xml entries on the
first `add` call even if never used.
The 2. is only needed when the navigations are actually fetched.
This splits the logic into two functions:
- `init` for the bare initialization
- `resolveAppNavigationEntries` for resolving the entries when
requesting to output them.
This should give a small performance improvement for API calls and fixes
a problem when navigations are added before all apps are registered.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-06-07 16:54:21 +02:00
Nextcloud bot
dbe23295e4
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2026-06-06 00:22:55 +00:00
Andrey Dyakov
136b88180b
fix(previews): ffprobe hangs
...
Signed-off-by: Andrey Dyakov <adduxa@gmail.com >
2026-06-05 16:06:16 +02:00
Carl Schwan
3750945cb8
fix(psalm): Fix psalm issues related to moving files
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-05 11:03:16 +02:00
Carl Schwan
774420a188
fix(filesystem): reset static members during frankenphp invokations
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-05 11:03:05 +02:00
Carl Schwan
b41709c8c8
refactor: Fix rebasing issues
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-05 11:03:04 +02:00
Côme Chilliet
f994955dd1
fix: cleanup some of the static vars
...
We’re gonna need a psalm rule
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-05 10:23:50 +02:00
Côme Chilliet
94102ac464
fix: Change back base.php to have the same behavior as before
...
Isolated OC in its own file instead so that index.php can do finer init.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-05 10:23:50 +02:00
Carl Schwan
6fc03681bd
feat: enabled frankenphp worker mode
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-05 10:23:50 +02:00
Côme Chilliet
d4c8781e82
Merge pull request #60481 from nextcloud/jtr/legacy-getTheme
...
refactor(legacy): simplify getTheme and clarify legacy theme docs
2026-06-04 15:57:52 +02:00
El Mehdi Abenhazou
e8c101fac8
fix(TaskProcessing): restrict allowed_classes in Manager cache deserialization
...
The availableTaskTypes cache stores serialized arrays containing
ShapeDescriptor objects, ShapeEnumValue objects, and EShapeType enum
values. The unserialize() call did not restrict which classes could
be instantiated.
Restrict deserialization to the three known types:
- OCP\TaskProcessing\ShapeDescriptor
- OCP\TaskProcessing\ShapeEnumValue
- OCP\TaskProcessing\EShapeType
This prevents PHP Object Injection if an attacker gains write access
to the distributed cache backend.
Signed-off-by: El Mehdi Abenhazou <mehdiananas007@gmail.com >
2026-06-04 10:49:23 +02:00
XananasX7
d0cce3da70
fix(TaskProcessing): add allowed_classes to unserialize() in Manager cache
...
The availableTaskTypes cache stores serialized arrays containing
ShapeDescriptor objects, ShapeEnumValue objects, and EShapeType enum
values. The unserialize() call did not restrict which classes could
be instantiated.
Restrict deserialization to the three known types:
- OCP\TaskProcessing\ShapeDescriptor
- OCP\TaskProcessing\ShapeEnumValue
- OCP\TaskProcessing\EShapeType
This prevents PHP Object Injection if an attacker gains write access
to the distributed cache backend (e.g., a Redis instance without
authentication or with weak ACLs), which is a known real-world attack
vector in shared hosting and container environments.
2026-06-04 10:34:12 +02:00
Nextcloud bot
b6d0e19876
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2026-06-04 00:23:44 +00:00
Daphne Muller
faa78c8a6b
Merge pull request #60167 from nextcloud/enh/noid/allow-http-progressive-stream-response
...
failing tests not related according to Julien
2026-06-03 16:24:48 +02:00
Tobias Kaminsky
3279c40632
Merge pull request #60953 from nextcloud/carl/IInstanceFactory
...
chore: Remove unused and long deprecated Remote components
2026-06-03 14:50:19 +02:00
Tobias Kaminsky
cfa3e1d900
Merge pull request #60954 from nextcloud/carl/IBroadcastEvent
...
chore: Deprecate IBroadcastEvent
2026-06-03 14:50:04 +02:00
Stephan Orbaugh
50b67c1e28
Merge pull request #60458 from nextcloud/refactor/navigation-manager
...
refactor(NavigationManager): move navigation definitions into apps
2026-06-03 14:46:42 +02:00
Julien Veyssier
04dc699a29
feat(guzzle): allow overriding the default curl handler when creating a new client
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2026-06-03 14:13:37 +02:00
Carl Schwan
4d74234f1e
chore: Deprecate IBroadcastEvent
...
Not used in any of the repos in github nextcloud namespace.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-03 13:46:10 +02:00
Carl Schwan
994565fec7
refactor: Use new IQueryBuilder::MAX_IN_PARAMETERS
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-03 13:45:29 +02:00